Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inline video previews #5791

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Handle inline video previews #5791

merged 3 commits into from
Nov 15, 2023

Commits on Nov 14, 2023

  1. webview: Open inline videos as links, just like YouTube previews 

    Fixes-partly: zulip#5781
    @gnprice
    gnprice committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f9806ae View commit details
    Browse the repository at this point in the history

  2. webview [nfc]: Fix readme about how static build works; update list 

    This README file accurately described how the build worked
when it was written.  But then a few months later we changed that,
in 0fb3d16, and we didn't update the README accordingly.

The automatic way seems like a nicer developer experience.  Probably
what this script ought to do is to ask Git for the list of files,
and copy those, in order to make it automatic while not getting
fooled by extraneous files in the directory.

For this legacy codebase, though, the way it actually works will
be fine.  Just fix the README to reflect that; and then update
the list to reflect the one change it should have gotten, from
commit ae7ad99 a few more months later.
    @gnprice
    gnprice committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c56822d View commit details
    Browse the repository at this point in the history

  3. webview: Style inline videos to show what they are 

    Fixes: zulip#5781
    @gnprice
    gnprice committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    df57212 View commit details
    Browse the repository at this point in the history