build(deps-dev): bump rollup from 2.79.1 to 3.29.5 #5893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 3.29.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.79.1...v3.29.5) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
CI failed because this changes the output of --- src/webview/js/generatedEs3.js
+++ src/webview/js/generatedEs3.js
@@ -877,15 +877,13 @@ var compiledWebviewJs = (function (exports) {
exports.handleInitialLoad = handleInitialLoad;
- Object.defineProperty(exports, '__esModule', { value: true });
-
return exports;
})({});
`;I'll do the upgrade directly. |
|
(That edit seems unrelated to the issue that prompted this PR — it was a change in 3.0.0. It's just that we haven't upgraded |
gnprice
added a commit
to gnprice/zulip-mobile
that referenced
this pull request
Sep 24, 2024
This is a library we use in tools/generate-webview-js , for producing the generated JS code to go in the message-list webview based on our several source files for it. This upgrade gets us a large number of changes that don't matter to us because they have no effect on the output JS. One of those is to fix an XSS vulnerability, CVE-2024-47068: GHSA-gcx4-mw62-g8wm which we learned about from Dependabot: zulip#5893 Even though the vulnerability doesn't affect us, it's good to upgrade past the fix to avoid having to ever re-evaluate whether it affects us. The fix is only in 3.x+, so go to the latest 3.x. There's also one change affecting the output, which is that the `__esModule` marker goes away. Seems fine. That happened in 3.0.0: https://github.com/rollup/rollup/blob/master/CHANGELOG.md#300
|
Closing in favor of #5894. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
chrisbobbe
pushed a commit
that referenced
this pull request
Sep 24, 2024
This is a library we use in tools/generate-webview-js , for producing the generated JS code to go in the message-list webview based on our several source files for it. This upgrade gets us a large number of changes that don't matter to us because they have no effect on the output JS. One of those is to fix an XSS vulnerability, CVE-2024-47068: GHSA-gcx4-mw62-g8wm which we learned about from Dependabot: #5893 Even though the vulnerability doesn't affect us, it's good to upgrade past the fix to avoid having to ever re-evaluate whether it affects us. The fix is only in 3.x+, so go to the latest 3.x. There's also one change affecting the output, which is that the `__esModule` marker goes away. Seems fine. That happened in 3.0.0: https://github.com/rollup/rollup/blob/master/CHANGELOG.md#300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rollup from 2.79.1 to 3.29.5.
Release notes
Sourced from rollup's releases.
... (truncated)
Changelog
Sourced from rollup's changelog.
... (truncated)
Commits
dfd233d3.29.52ef77c0Fix DOM Clobbering CVEa6448b93.29.44e92d60Deoptimize all parameters when losing track of a function (#5158)801ffd13.29.3353e462Fully deoptimize first level path when deoptimizing nested parameter paths (#...a1a89e7chore(deps): update dependency@vue/eslint-config-typescriptto v12 (#5148)cc14f70chore(deps): lock file maintenance minor/patch updates (#5149)1e8355bdocs: improve the docs repl appearance in the light mode (#5145)5950fc8Adapt branches in REPL workflowDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.