deps: Update rollup to 3.x, from the last 2.x #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a library we use in tools/generate-webview-js , for producing the generated JS code to go in the message-list webview based on our several source files for it. This upgrade gets us a large number of changes that don't matter to us because they have no effect on the output JS. One of those is to fix an XSS vulnerability, CVE-2024-47068: GHSA-gcx4-mw62-g8wm which we learned about from Dependabot: zulip#5893 Even though the vulnerability doesn't affect us, it's good to upgrade past the fix to avoid having to ever re-evaluate whether it affects us. The fix is only in 3.x+, so go to the latest 3.x. There's also one change affecting the output, which is that the `__esModule` marker goes away. Seems fine. That happened in 3.0.0: https://github.com/rollup/rollup/blob/master/CHANGELOG.md#300
|
I should add: I manually tested this version in a message list, and it worked. Long-pressing a message brought up the message action sheet, so the webview JS was indeed working. |
|
Sure, LGTM! Thanks; merging. |
|
When I cleared out Normally we would tidy those away, but I'm comfortable leaving them there in this legacy codebase. |
|
Yeah, agreed. (I saw similar warnings when developing this change, but forgot to mention them.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a library we use in tools/generate-webview-js , for producing the generated JS code to go in the message-list webview based on our several source files for it.
This upgrade gets us a large number of changes that don't matter to us because they have no effect on the output JS. One of those is to fix an XSS vulnerability, CVE-2024-47068:
GHSA-gcx4-mw62-g8wm
which we learned about from Dependabot:
#5893
Even though the vulnerability doesn't affect us, it's good to upgrade past the fix to avoid having to ever re-evaluate whether it affects us. The fix is only in 3.x+, so go to the latest 3.x.
There's also one change affecting the output, which is that the
__esModulemarker goes away. Seems fine. That happened in 3.0.0:https://github.com/rollup/rollup/blob/master/CHANGELOG.md#300