feat(ui): add nodes table filter + persistent UI settings #90

ahochsteger · 2020-12-18T10:22:00Z

This is a port of the nodes table filtering feature from zwave2mqtt (see OpenZWave/Zwave2Mqtt#823).

Tasks:

Port nodes table filter feature
Port persistent UI settings
Refactor to generic table header templates
Refactor to generic filter implementation (column-independent)
Fix node selection bug
Cleanup (fix TODOs, remove console.log(), consistent naming)
Add filter form input validation

coveralls · 2020-12-18T10:35:52Z

Pull Request Test Coverage Report for Build 449658008

0 of 816 (0.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.0%) to 25.492%

Changes Missing Coverage	Changed/Added Lines	%
src/modules/ColumnFilterHelper.test.js	36	0.0%
src/modules/Settings.js	61	0.0%
src/modules/ColumnFilterHelper.js	73	0.0%
src/modules/Settings.test.js	102	0.0%
src/components/nodes-table/nodes-table.js	110	0.0%
src/modules/NodeCollection.js	139	0.0%
src/modules/NodeCollection.test.js	295	0.0%

Totals
Change from base Build 449042411:	-3.0%
Covered Lines:	1951
Relevant Lines:	7819

💛 - Coveralls

ahochsteger · 2020-12-18T10:39:53Z

@robertsLando this is a fully working port of the nodes table filtering - adjusted to the new columns that are now in use by zwavejs2mqtt.

There are still some issues and questions, I'd like to discuss with you to make it easier to maintain by reducing redundancy and changes cluttered over several places in the code:

We could make the filtering code more generic, if the headers would be consistently named after the node propertes (e.g. header product is not consistently named after the node property productLabel). Can we rename the header to productLabel?
Would it make sense to you to put the filtering information (from filters) directly into the headers (e.g. { text: 'ID', value: 'id', type: 'number', filter: ...})? This way the filtering could be done by just iterating the headers list and filter according to the data type. (see nodes-table.js).
I'd like to use a generic way for the header templates in nodes-table/index.vue as well but unfortunately I found no way to generate templates by iterating over a list. Do you have an idea, if this would be possible somehow?
The tests (NodeCollection.test.js) still do not seam to work, even if there has nothing changed in both this file and NodeCollection.js.

Persisted settings: * Dark mode * Show hidden nodes * Number of items per page on nodes table * Column filters * Column sorting

src/components/nodes-table/nodes-table.js

robertsLando · 2020-12-21T08:49:45Z

src/components/nodes-table/nodes-table.js

+          this.filters.manufacturer
+            ? this.filters.manufacturer.selections
+              ? this.filters.manufacturer.selections
+              : []
+            : []


src/components/nodes-table/nodes-table.js

BREAKING CHANGE: entities names could change

Co-authored-by: Andreas Hochsteger <andreas.hochsteger@oeamtc.at>

BREAKING CHANGE: Hass entities ids will change Co-authored-by: V Aretakis <vassilis@aretakis.eu>

* feat(ui): groups values by command class * fix: remove genre from valueId * fix: lint issues

* fix: undefined values * fix: add more logging * fix(ui): show read only list values

* add notification part 1 * add translation from states to value_template * support both number and text * add motion sensor icon * add new icon for motion sensor * add TODO for icons. Add logic on mapped default value * patch default value, to show value_json.value when uknown mapping entry is posted * remove extra bracket * fix linting issues Co-authored-by: V. Aretakis <v.aretakis@elsevier.com>

ahochsteger · 2020-12-27T19:25:53Z

@robertsLando it took a bit longer than I hoped but now the refactored version of the node table filter + persistent UI settings with almost all duplicate patterns is finished.

robertsLando

@ahochsteger Really nice work here! Love the actual implementation, much more cleaner! GG. There are some things that need to be fixed, give them a check when you have time, thanks!

src/components/nodes-table/ColumnFilterDate.vue

src/components/nodes-table/ColumnFilterNumber.vue

src/components/nodes-table/ColumnFilterString.vue

src/modules/NodeCollection.js

src/components/nodes-table/index.vue

src/components/nodes-table/nodes-table.js

src/components/ControlPanel.vue

* Skip filter on invalid Regex * Add form input validation * Naming: until -> to * Naming: reset filter -> reset filters

ahochsteger · 2020-12-28T22:49:31Z

@robertsLando thanks for your feedback!
All suggested changes and the selection bug are fixed and ready for review / approval.

robertsLando

LGTM. GG @ahochsteger ! :)

robertsLando · 2020-12-29T07:43:46Z

Let you sqash and merge if you are done here. I have tested your changes and everything looks good

ahochsteger added 2 commits December 18, 2020 11:17

feat: Port nodes table filter to zwavejs2mqtt

b7753e3

fix: Lint errors

c9821ad

ahochsteger changed the title ~~feat: Nodes table filter~~ feat: Add nodes table filter Dec 18, 2020

fix: Lint errors

5a86567

ahochsteger added 4 commits December 18, 2020 19:22

refactor: Fix naming: product -> productLabel

f964ea6

fix: Remove unused function productName()

af6537f

refactor: Use generic header templates

f2b2bfb

fix: Wrong syntax for v-for with templates

e5c1a76

ahochsteger changed the title ~~feat: Add nodes table filter~~ feat: Add nodes table filter + persistent UI settings Dec 19, 2020

feat: Add persistent UI settings

e6d76c2

Persisted settings: * Dark mode * Show hidden nodes * Number of items per page on nodes table * Column filters * Column sorting

robertsLando requested changes Dec 21, 2020

View reviewed changes

ahochsteger and others added 17 commits December 27, 2020 19:30

refactor: Major refactoring of column filtering

7d4f788

chore(deps): bump zwave-js@5.6.1

19a21ba

Release 1.0.0-alpha.1

8244d1e

feat(docker): allow to update devices of driver during build (#86)

9fce33d

fix(hass): better notifications names (#98)

652b385

BREAKING CHANGE: entities names could change

fix: startup error in setupLogging() (#96)

81a87c4

Co-authored-by: Andreas Hochsteger <andreas.hochsteger@oeamtc.at>

fix(hass): discovery issues caused by spaces in topic (#99)

852647d

BREAKING CHANGE: Hass entities ids will change Co-authored-by: V Aretakis <vassilis@aretakis.eu>

feat(ui): group values by command classes (#103)

2a5cbc7

* feat(ui): groups values by command class * fix: remove genre from valueId * fix: lint issues

fix(ui): remove empty layout

d7d54b1

fix: read only list values in UI and better logging (#102)

5af038c

* fix: undefined values * fix: add more logging * fix(ui): show read only list values

fix: writeValue logs undefined valueId

eeb5834

feat: allow custom ZwaveOptions

833c027

fix: always include endpoint in topic when using named topics #69 (#74)

13e6a57

fix: Lint errors

ec9ed7f

fix: Lint errors

d1536ff

Merge branch 'master' into nodes-table-filter

f1c2489

fix: Lint errors

c3b9d14

ahochsteger marked this pull request as ready for review December 27, 2020 19:17

ahochsteger requested a review from robertsLando December 27, 2020 19:17

ahochsteger added 2 commits December 27, 2020 20:31

test: Add tests for ColumnFilterHelper

2e060a1

fix: Lint errors

5fed5f0

ahochsteger changed the title ~~feat: Add nodes table filter + persistent UI settings~~ feat(ui): add nodes table filter + persistent UI settings Dec 27, 2020

ahochsteger added 2 commits December 27, 2020 22:19

fix: Node selection + initSorting (node_id -> id)

e81770e

feat: add regex matching for string column filter

87e19d1

robertsLando requested changes Dec 28, 2020

View reviewed changes

ahochsteger and others added 3 commits December 28, 2020 22:52

fix: Error on invalid Regex

3ecd48c

* Skip filter on invalid Regex * Add form input validation * Naming: until -> to * Naming: reset filter -> reset filters

fix: Node selection does not work anymore

e367cdd

Merge branch 'master' into nodes-table-filter

8c9ba2d

robertsLando approved these changes Dec 29, 2020

View reviewed changes

ahochsteger merged commit 91998e0 into master Dec 29, 2020

ahochsteger deleted the nodes-table-filter branch December 29, 2020 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): add nodes table filter + persistent UI settings #90

feat(ui): add nodes table filter + persistent UI settings #90

ahochsteger commented Dec 18, 2020 •

edited

Loading

coveralls commented Dec 18, 2020 •

edited

Loading

ahochsteger commented Dec 18, 2020

robertsLando Dec 21, 2020

ahochsteger commented Dec 27, 2020

robertsLando left a comment

ahochsteger commented Dec 28, 2020

robertsLando left a comment

robertsLando commented Dec 29, 2020

feat(ui): add nodes table filter + persistent UI settings #90

feat(ui): add nodes table filter + persistent UI settings #90

Conversation

ahochsteger commented Dec 18, 2020 • edited Loading

coveralls commented Dec 18, 2020 • edited Loading

Pull Request Test Coverage Report for Build 449658008

💛 - Coveralls

ahochsteger commented Dec 18, 2020

robertsLando Dec 21, 2020

Choose a reason for hiding this comment

ahochsteger commented Dec 27, 2020

robertsLando left a comment

Choose a reason for hiding this comment

ahochsteger commented Dec 28, 2020

robertsLando left a comment

Choose a reason for hiding this comment

robertsLando commented Dec 29, 2020

ahochsteger commented Dec 18, 2020 •

edited

Loading

coveralls commented Dec 18, 2020 •

edited

Loading