Snippets

[boombuler]

I think I finally reached a state where the plugin is usable. (fix for #175)

What is currently missing:

• It's not yet added to the runtime.go
• some kind of keybinding might be nice but I leave that to you
• Some more testing might also be a good idea...

[zyedidia]

Wow! This looks really good and you did it so fast too. Very nice!

I have been testing it with the go.snippets and I have just a couple remarks:

For very simple snippets like

snippet bl
    bool

the cursor is moved to the start of the word after the snippet is inserted but it should be moved to the end.

For snippets like

snippet v
    ${1} := ${2}

where the cursor locations have to placeholders, an empty selection is created which isn't necessary and causes problems when at the end of the line with ${2} because it selects the newline, which then gets deleted.

Those are the only problems I found. Now comes the question of what should the keybindings be, and where should the snippets be stored.

[boombuler]

I will have a look at those two issues might take a day or two...
About the keybindings: Not sure how its handled but wouldn't it be possible to bind both to tab? And proceed to the next binding if nothing matched?

About the question where those snippets might get stored: Some kind of package management for plugins might be helpful. Including all packages and snippets within the binary might increase the file size more then needed for most users...

[boombuler]

ok the bugs you've mentioned should be fixed.
I've also reindented the script, added some more commands and did some minor cleanup.

[handicraftsman]

o_O

[handicraftsman]

MB, i'll add syntax-highlighting for snippet files

[zyedidia]

I changed the way plugin help files works in the last commit so the help.md help file needs to be changed. You should rename it to something like snippets.md and move it to a help directory if you'd like.

Then you can register it in the lua code with

AddRuntimeFile("snippets", "help", "help/snippets.md")

Also I'm not sure if this plugin should be provided by default with all the snippets. Perhaps this should be the first third-party plugin? If that's the case then we need to add some sort of plugin manager.

[zyedidia]

The new runtime file organization from your latest PR also means that other plugins can add their own snippets files with AddRuntimeFile("pluginName", "snippets", "filetype.snippets") even if "snippets" is not a filetype recognized by the core. I think it would be best if this plugin read snippet files using ListRuntimeFiles("snippets").

[boombuler]

Hi,

I've merged the master branch to keep this up to date and the plugin now reads the snippets from the runtime files as you said. (type snippets). The help is also provided via runtime files and I fixed a potential bug on windows systems. (Hint: if you concat file paths use the join function from the path/filepath go-package since it handles the system specific directory delimiter.

[boombuler]

Some kind of plugin manager would be great, since it would keep the binary small.
I think its even easier to provide since the runtime file PR. since the mentioned manifest file could be replaced by some AddRuntimeFile calls from the script.
If the core would provide some HTTP-Api for the plugins, it would be even possible to implement the plugin manager as a plugin. (Maybe the plugin-scripts should be handled by the runtime files too, that way the core-plugins could be updated without updating the editor)