Snippets core #370
Merged
Snippets core #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those changes were originally used for the snippet plugin which may not be part of the core.
matthias314
pushed a commit
to matthias314/micro
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've chosen to re-submit the changes in the core, which I've made for the snippets plugin.
Mostly because it will prevent merge conflicts on the core while the plugin is not yet accepted.
If you merge this PR, I will close #349 and recreate a new PR which contains only the plugin.
If we manage to create some kind of plugin-manager, I'll be happy to close the PR which will contain the plugin.
I hope this is ok with you.