Merge in first half of sprint ending 2018-10-09 #932

ryanhofdotgov · 2018-10-04T04:52:02Z

No description provided.

JSON has several phantom and 2 real validation errors. XML has 33 XSD validation errors. Submitting to e-QIP indicates 74 exception errors.

Military addresses are encoded differently when under an APOAFO element vs when they are in a multi-purpose Address element.

Work-around for #859

Work-around for #860

Work-around for #863

Work-around for #868

#848 corrected logic where frequency/method/etc. of contact wasn't been collected before

Get test case 7 validating against schemas

Catch lowercase states in location validator

Uppercase all state abbreviations

Set lastRefresh on initial form load

Add year only option to datecontrol component

Remove slack badge from README

Update addresses to display only APO/FPO when required

Fix margins on archival PDF, button sizes

ExistingConditions e-QIP XML

Fix incorrect foreign real estate text

Make mother and father-in-law required when married or separated

Combine civil marriage and civil union into one button

Remove question from existing conditions

codecov · 2018-10-04T05:13:14Z

Codecov Report

Merging #932 into master will increase coverage by 0.11%.
The diff coverage is 92.94%.

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   46.66%   46.77%   +0.11%     
==========================================
  Files         680      680              
  Lines       27397    27459      +62     
  Branches     3371     3386      +15     
==========================================
+ Hits        12784    12845      +61     
- Misses      14250    14251       +1     
  Partials      363      363

Flag	Coverage Δ
#backend	`7.92% <91.66%> (+0.17%)`	⬆️
#frontend	`90.19% <93.87%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
src/components/Section/History/History.jsx	`52.17% <ø> (ø)`	⬆️
src/components/Section/Psychological/Treatment.jsx	`100% <ø> (ø)`	⬆️
src/config/locales/en/relationships.js	`100% <ø> (ø)`	⬆️
...nents/Section/Foreign/Contacts/ForeignNational.jsx	`82.66% <ø> (ø)`	⬆️
...ents/Section/Psychological/Diagnoses/Diagnosis.jsx	`100% <ø> (ø)`	⬆️
...onents/Section/History/Education/EducationItem.jsx	`64.81% <ø> (ø)`	⬆️
...ents/Section/History/Employment/EmploymentItem.jsx	`74.32% <ø> (ø)`	⬆️
...ection/SubstanceUse/Alcohol/ReceivedCounseling.jsx	`97.5% <ø> (ø)`	⬆️
.../components/Section/Foreign/Activities/CoOwner.jsx	`100% <ø> (ø)`	⬆️
...Section/SubstanceUse/Alcohol/OrderedCounseling.jsx	`94.73% <ø> (ø)`	⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488a520...8b74390. Read the comment docs.

ryanhofdotgov and others added 30 commits September 27, 2018 02:33

Initial commit of test case 7

8d7687b

JSON has several phantom and 2 real validation errors. XML has 33 XSD validation errors. Submitting to e-QIP indicates 74 exception errors.

Encode HairColor correctly

3e2607d

Encode APOAFO elements correctly

dbd017d

Military addresses are encoded differently when under an APOAFO element vs when they are in a multi-purpose Address element.

Fix encoding of PurposeOfVisit, Other attribute

9ca47ee

Fix Drug/Type and Drug/Explanation encoding

ed77df3

Fix encoding of DrugUsed

6e548b9

Manually set tax year

e0c8757

Work-around for #859

Manually fix end-dates for additional employment

a3359c9

Work-around for #860

Manually change court address from APO to US

2310216

Work-around for #863

Manually fix agency address

4fc0db7

Work-around for #868

Update test 7 fixture to match recent fixes

b72b9d2

Update test7.json with contact meta-data

301f833

#848 corrected logic where frequency/method/etc. of contact wasn't been collected before

Uppercase all state abbreviations

a9c235d

Merge pull request #847 from 18F/initial-test7

dba2836

Get test case 7 validating against schemas

Catch lowercase states in location validator

a4d525b

Set lastRefresh on initial form load

e1d27ab

Merge pull request #904 from 18F/bh_zip_state_location

abb1f9e

Catch lowercase states in location validator

Merge pull request #903 from 18F/bh_testdata_states

7dd6830

Uppercase all state abbreviations

Merge pull request #906 from 18F/bh_initial_timeout

f0c685a

Set lastRefresh on initial form load

Update addresses to display only APO/FPO when required

c17f2fc

Support year only datecontrol component

91c0d35

Remove padding from pre-print page

054f77d

updates to print css and added class around history section

9c01d28

Fixing lint issues

ab96e49

Updating snapshot

5a07da6

Encode AdverselyAffected TreatmentOccurence

d42b510

Merge pull request #909 from 18F/bh_year_only

7a25993

Add year only option to datecontrol component

Remove slack badge from README

7226514

Merge pull request #917 from 18F/sw-remove-slack-badge

85522ff

Remove slack badge from README

Fix Decline encoding

b6d70f7

hursey013 and others added 16 commits October 2, 2018 12:21

Enable APO/FPO for items in schema which specify AllStates

9ed5423

Merge pull request #908 from 18F/apburnes/audit-addresses

c545969

Update addresses to display only APO/FPO when required

Merge pull request #885 from 18F/sw-pdf-margins

f83799c

Fix margins on archival PDF, button sizes

Fix incorrect foreign real estate text

49e46ae

Merge pull request #916 from 18F/initial-test8

d9f2796

ExistingConditions e-QIP XML

Make mother and father-in-law required when married or separated

db2e4c7

Merge pull request #920 from 18F/fix-nbib59-text

13183d3

Fix incorrect foreign real estate text

Add missing parentheses

3228e9d

More missing parentheses

36ef039

Combine civil marriage and civil union into one button

52b83d2

Merge pull request #921 from 18F/bh_require_mil_and_fil

38aabe3

Make mother and father-in-law required when married or separated

Remove maritalStatus api function

371bc80

Update switch statement

4ee5345

Remove question from existing conditions

7d57482

Merge pull request #927 from 18F/bh_combine_civilunion

ee3284a

Combine civil marriage and civil union into one button

Merge pull request #930 from 18F/bh_existing_conditions

8b74390

Remove question from existing conditions

ryanhofdotgov merged commit 652bb84 into master Oct 4, 2018

michaelccata added the Pull-Request label Mar 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge in first half of sprint ending 2018-10-09 #932

Merge in first half of sprint ending 2018-10-09 #932

ryanhofdotgov commented Oct 4, 2018

codecov bot commented Oct 4, 2018 •

edited

Loading

Merge in first half of sprint ending 2018-10-09 #932

Merge in first half of sprint ending 2018-10-09 #932

Conversation

ryanhofdotgov commented Oct 4, 2018

codecov bot commented Oct 4, 2018 • edited Loading

Codecov Report

codecov bot commented Oct 4, 2018 •

edited

Loading