[pull] main from hashicorp:main #3
Open
+93,004
−32,542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ces-without-change ephemeral resource deferrals
nodeExpandApplyableResource only does expansion related tasks, so remove the Execute method and move the logic all into DynamicExpand.
Ephemeral resource behavior is a strange mix of temporary values and existing resource types, and their operation during destroy is going to be more difficult to manage than normal resources. The pruneUnusedNodesTransformer is probably no longer equipped to handle the situation, and will probably need to be build in a different manner, but this minor change allows us to move forward for now.
Just like Descendants, Ancestors doesn't need to return an error.
backend/s3: s3 native locking changelog entry
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
Ephemeral expansion and add tests for ephemeral values
Apply and destroy evaluation of ephemeral resources (partial)
undeclared variables must be allowed during apply
* Complete equivalence test implementation * use proper github actions bot
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fix typo: correct "infrastruture" to "infrastructure"
Clarify single-removal behavior in `trimsuffix` and `trimprefix` docs
…nts-operators-reference Fix for incorrect rendering of > as ≥ in version constraints
* update noisy equivalence test * also run on opened PRs * don't need to ignore fields anymore
This includes sections on the introduction of S3 native state locking and the removal of deprecated root level attributes related to role assumption which have been replaced by the `assume_role` block.
* equivalence testing: use --intent-to-add to include new file diffs * also update github commit name
Co-authored-by: hc-github-team-tf-core <github-team-tf-core@hashicorp.com>
In Fedora Linux 41, which uses DNF5, backward compatibility with DNF4 was intentionally broken. The method for adding repositories via dnf config-manager has changed to use new sub-commands, such as addrepo. Signed-off-by: Bruno Schaatsbergen git@bschaatsbergen.com Signed-off-by: Bruno Schaatsbergen git@bschaatsbergen.com
* Update docs for .netrc integration with provider downloads * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * tidy up after weird auto-merge --------- Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
* Remove Interpolation-only expressions from website/docs files Interpolation-only expressions are deprecated in Terraform v0.12.14 See. https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.10.0/docs/rules/terraform_deprecated_interpolation.md * Revert whitespace trimming at the end of lines * Preserve interpolation-only expressions for JSON * Preserve interpolation-only expressions for < 0.11 samples * Remove Interpolation-only expressions from website/docs files
The forceDependsOn field when a remnant of when data sources were read during a separate refresh phase, and was now only complicating the dependency calls.
The dependsOn method of the ReferenceMap is only used to resolve dependencies for data sources. It therefor needs to account for all possible dependencies, and cant rely on the same optimizations made for the normal AttachDependenciesTransformer. While data sources will need to continue keeping the entire dependency tree available, they obviously used far less then managed resource within normal configurations, and the data resource dependencies are not recorded to state at all.
Limiting the destroy dependencies stored in the state doesn't help, and leaves us trying to reconstruct them again during apply which is more difficult during partial replacement scenarios.
Due to the need to search through parent directory depends_on for data sources, the dependencies listed for data sources can contain numerous duplicates. In the worst-case configurations, with nested modules that have multiple depends_on entries, duplicates can be listed hundreds of times. While `dag.Set` is not a great generic data structure, use that for de-duplication because it's the same structure used internally by `dag.Graph` so we can be sure nodes are consistently unique.
* jsonplan: deterministic relevant attribute order * simplify sort function
Co-authored-by: hc-github-team-tf-core <github-team-tf-core@hashicorp.com>
Revert some minor performance enhancements which turn into severe bottlenecks with complex configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )