Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_F469NI: allow the use of CAN2 instance when CAN1 is not activated #3880

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

adustm
Copy link
Member

@adustm adustm commented Mar 3, 2017

Description

On STM32F4 family, the CAN2 hw instance is using CAN1's filters.
HAL_CAN1_CLOCK_ENABLE must be activated.
This modification is not impacting other STM32 families behavior

Status

READY

Migrations

NO

Steps to test or reproduce

Use the can autoloop test with only CAN2 activated on DISCO_F469NI
(test name MBED_A27, with CAN can1(PB_5, PB_13); instead of CAN can1(PB_8, PB_9);)
Without the patch, thecan.readdoes not work (only write works) and MBED_A27 test is failed
With the patch, can.read works and MBED_A27 test is a success

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Mar 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@adustm
Copy link
Member Author

adustm commented Mar 6, 2017

Hello @0xc0170
Could you give me details about the CI/morph-test failure ? Let me know if I need to change something.
Kind regards

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2017

Java exception, not related to this patch I believe. Restarting

/morph test

@mbed-bot
Copy link

mbed-bot commented Mar 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@bridadan
Copy link
Contributor

bridadan commented Mar 6, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Mar 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1637

All builds and test passed!

@0xc0170 0xc0170 merged commit b272647 into ARMmbed:master Mar 6, 2017
@adustm adustm deleted the fix_can2_only branch March 13, 2017 09:58
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

3716: fix for issue #3715: correction in startup files for ARM and IAR, alignment of system_stm32f429xx.c files ARMmbed/mbed-os#3716
3741: STM32 remove warning in hal_tick_32b.c file ARMmbed/mbed-os#3741
3780: STM32L4 : Fix GPIO G port compatibility ARMmbed/mbed-os#3780
3831: NCS36510: SPISLAVE enabled (Conflict resolved) ARMmbed/mbed-os#3831
3836: Allow to redefine nRF's PSTORAGE_NUM_OF_PAGES outside of the mbed-os ARMmbed/mbed-os#3836
3840: STM32: gpio SPEED - always set High Speed by default ARMmbed/mbed-os#3840
3844: STM32 GPIO: Typo correction. Update comment (GPIO_IP_WITHOUT_BRR) ARMmbed/mbed-os#3844
3850: STM32: change spi error to debug warning ARMmbed/mbed-os#3850
3860: Define GPIO_IP_WITHOUT_BRR for xDot platform ARMmbed/mbed-os#3860
3880: DISCO_F469NI: allow the use of CAN2 instance when CAN1 is not activated ARMmbed/mbed-os#3880
3795: Fix pwm period calc ARMmbed/mbed-os#3795
3828: STM32 CAN API: correct format and type ARMmbed/mbed-os#3828
3842: TARGET_NRF: corrected spi_init() to properly handle re-initialization ARMmbed/mbed-os#3842
3843: STM32L476xG: set APB2 clock to 80MHz (instead of 40MHz) ARMmbed/mbed-os#3843
3879: NUCLEO_F446ZE: Add missing AnalogIn pins on PF_3, PF_5 and PF_10. ARMmbed/mbed-os#3879
3902: Fix heap and stack size for NUCLEO_F746ZG ARMmbed/mbed-os#3902
3829: can_write(): return error code when no tx mailboxes are available ARMmbed/mbed-os#3829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants