Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GaussMarkov sensor noise handling #881

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Natsoulas
Copy link
Contributor

Description

Followed user feedback about inconsistencies in how various sensors handle the GaussMarkov noise model. This PR addresses all the issues pointed out in issue #867 and updates relevant documentation. Necessary private class attributes are made accessible outside of the class via getter and setter methods introduced in this PR. Additionally, I edited sensor modules to initialize the GM noise models in their constructors rather than in their Reset() methods (this was only some sensors).

Verification

Each change/refactor was verified via passing unit tests and running scenarioGaussMarkovRandomWalk.py to ensure the refactor did not change any functionality of the code.

Documentation

Changed imuSensor name for walkBounds to errorBounds, and documented latex doc for the IMU Sensor called imuSensor/_Documentation/BasiliskCorruptions.tex

Future work

See if community desires any additional refactoring or clarification of Gauss Markov sensor noise modeling through additional documentation

@Natsoulas Natsoulas added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 21, 2024
@Natsoulas Natsoulas self-assigned this Dec 21, 2024
@Natsoulas Natsoulas requested a review from a team as a code owner December 21, 2024 19:52
@Natsoulas Natsoulas linked an issue Dec 21, 2024 that may be closed by this pull request
@Natsoulas Natsoulas force-pushed the refactor-sensor-noise-handling branch 8 times, most recently from 34b0b7e to a7c5408 Compare December 23, 2024 01:43
@sdunlap-afit
Copy link

@Natsoulas Looking through the code, it seems ImuSensor::Reset() is still setting the two AMatrix variables to I. If you remove these from Reset(), you may also want to remove this comment in scenarioGaussMarkovRandomWalk.py to avoid confusion: # Set IMU2's A Matrix to zero AFTER initialization.

@Natsoulas
Copy link
Contributor Author

Thanks @sdunlap-afit for looking over my changes. I'll incorporate that change this afternoon.

@Natsoulas Natsoulas force-pushed the refactor-sensor-noise-handling branch from a7c5408 to fc98f12 Compare December 23, 2024 23:02
@Natsoulas Natsoulas force-pushed the refactor-sensor-noise-handling branch from fc98f12 to e04558d Compare December 23, 2024 23:04
@Natsoulas
Copy link
Contributor Author

@sdunlap-afit I just removed the lines setting A as the identity in Reset(), and edited the comment in the scenario. Let me know if you have any more suggestions. I appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Inconsistent sensor noise handling
2 participants