-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GaussMarkov sensor noise handling #881
base: develop
Are you sure you want to change the base?
Conversation
34b0b7e
to
a7c5408
Compare
@Natsoulas Looking through the code, it seems |
Thanks @sdunlap-afit for looking over my changes. I'll incorporate that change this afternoon. |
a7c5408
to
fc98f12
Compare
fc98f12
to
e04558d
Compare
@sdunlap-afit I just removed the lines setting A as the identity in Reset(), and edited the comment in the scenario. Let me know if you have any more suggestions. I appreciate your help! |
Description
Followed user feedback about inconsistencies in how various sensors handle the GaussMarkov noise model. This PR addresses all the issues pointed out in issue #867 and updates relevant documentation. Necessary private class attributes are made accessible outside of the class via getter and setter methods introduced in this PR. Additionally, I edited sensor modules to initialize the GM noise models in their constructors rather than in their Reset() methods (this was only some sensors).
Verification
Each change/refactor was verified via passing unit tests and running scenarioGaussMarkovRandomWalk.py to ensure the refactor did not change any functionality of the code.
Documentation
Changed imuSensor name for walkBounds to errorBounds, and documented latex doc for the IMU Sensor called imuSensor/_Documentation/BasiliskCorruptions.tex
Future work
See if community desires any additional refactoring or clarification of Gauss Markov sensor noise modeling through additional documentation