cascading delete #2041
Merged
cascading delete #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2041.aam-digital.net/ |
sleidig
commented
Oct 20, 2023
TheSlimvReal
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Really nice job. I like how little places needed to be modified and also how little core code is necessary in general. Also a very extensive test suite makes pretty clear what happens.
My comments are mostly around making thins a bit more precise in terms of naming. Happy to discuss this a bit more.
sleidig
commented
Nov 2, 2023
src/app/core/entity/entity-actions/entity-anonymize.service.spec.ts
Outdated
Show resolved
Hide resolved
TheSlimvReal
reviewed
Nov 6, 2023
src/app/core/entity/entity-actions/entity-actions.service.spec.ts
Outdated
Show resolved
Hide resolved
src/app/core/entity/entity-actions/entity-actions-test-utils.ts
Outdated
Show resolved
Hide resolved
TheSlimvReal
reviewed
Nov 6, 2023
TheSlimvReal
approved these changes
Nov 15, 2023
| @@ -0,0 +1,14 @@ | |||
| <ng-container | |||
| *ngIf="!(displayAsAnonymized || isPartiallyAnonymized); else anonymized" | |||
There was a problem hiding this comment.
A bit annoying, that both of these properties are necessary. Every component that is also used in templates will have to implement both which is a bit against the idea that they can be used everywhere.
There was a problem hiding this comment.
yes, agreed. I wanted to reuse date-component's template for how month-component is displaying. Unfortunately isPartiallyAnonymized doubling as an @Input just gets overwritten ...
Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Simon <simon@aam-digital.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Snyk has created this PR to upgrade flag-icons from 6.11.1 to 6.11.2. See this package in npm: https://www.npmjs.com/package/flag-icons See this project in Snyk: https://app.snyk.io/org/aam-digital-ci/project/a4b5c50c-28f4-4e30-af2d-840962b9beaf?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io>
to enable their use in popup forms like NoteDetails, which are always in edit mode --------- This functionality has been developed for the project “codo”. codo is developed under the projects “Landungsbrücken – Patenschaften in Hamburg stärken” and “openTransfer Patenschaften”. It is funded through the program “Menschen stärken Menschen” by the German Federal Ministry of Family Affairs, Senior Citizens, Women and Youth. More information at https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” is a project of BürgerStiftung Hamburg in cooperation with the Mentor.Ring Hamburg. With a mix of networking opportunities, capacity building and financial support the project strengthens Hamburg’s scene of mentoring projects since its founding in 2016. The “Stiftung Bürgermut” foundation since 2007 supports the digital and real exchange of experiences and connections of active citizens. Within the federal program “Menschen stärken Menschen” the foundation as part of its program “openTransfer Patenschaften” offers support services for connecting, spreading and upskilling mentoring organisations across Germany. Diese Funktion wurde entwickelt für das Projekt codo. codo wird entwickelt im Rahmen der Projekte Landungsbrücken – Patenschaften in Hamburg stärken und openTransfer Patenschaften. Er ist gefördert durch das Bundesprogramm Menschen stärken Menschen des Bundesministeriums für Familie, Senioren, Frauen und Jugend. Mehr Informationen unter https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” ist ein Projekt der BürgerStiftung Hamburg in Kooperation mit dem Mentor.Ring Hamburg. Mit einer Mischung aus Vernetzungsangeboten, Qualifizierungsmaßnahmen und finanzieller Förderung stärkt das Projekt die Hamburger Szene der Patenschaftsprojekte seit der Gründung im Jahr 2016. Die Stiftung Bürgermut fördert seit 2007 den digitalen und realen Erfahrungsaustausch und die Vernetzung von engagierten Bürger:innen. Innerhalb des Bundesprogramms „Menschen stärken Menschen” bietet die Stiftung im Rahmen ihres Programms openTransfer Patenschaften Unterstützungsleistungen zur Vernetzung, Verbreitung und Qualifizierung von Patenschafts- und Mentoringorganisationen bundesweit. Co-authored-by: codo-mentoring <117934638+codo-mentoring@users.noreply.github.com>
closes #1872 --------- Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
closes #2081 --------- Co-authored-by: Sebastian <sebastian@aam-digital.com>
|
🎉 This PR is included in version 3.26.0-master.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #220