-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Setup Wizard / Admin UI #2057
Conversation
…f config from route data
# Conflicts: # src/app/core/entity-details/entity-details/entity-details.component.html # src/app/core/entity-details/entity-details/entity-details.component.ts
Deployed to https://pr-2057.aam-digital.net/ |
closes #1361 Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
closes #1362 Co-authored-by: Sebastian <sebastian@aam-digital.com>
all prettier rules are enforced by lint check now --------- Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
# Conflicts: # src/app/child-dev-project/attendance/add-day-attendance/add-day-attendance.component.ts # src/app/core/entity-details/entity-details/entity-details.component.html # src/app/core/entity-details/entity-details/entity-details.component.ts # src/app/core/ui/routed-view/routed-view.component.ts
This look and feel is really amazing. I love how intuitive and pretty the design is. It works just the way I would expect it. Really good job!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the opton to add permissions to admin routes is quite important. I don't think this is possible with the new system. Or should we have a default rule for that?
src/app/core/admin/admin-entity-panel-component/admin-entity-panel-component.component.html
Outdated
Show resolved
Hide resolved
src/app/core/entity-details/entity-details/entity-details.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Please have a look at the accidental changes to some comments.
src/app/core/entity-details/entity-details/entity-details.component.html
Show resolved
Hide resolved
src/app/features/conflict-resolution/auto-resolution/auto-resolution.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it now with the route guard and it works well. There is only a error message in synced mode when visiting admin/entity/Child/details
directly as I think the component is loaded before the config is available. When waiting for the config (using await firstValueFrom(this.configService.configUpdates)
the error is gone but it somehow navigates to a empty tab. I wasnt able to fix that.
# Conflicts: # src/app/core/config/config-fix.ts # src/app/core/config/dynamic-routing/router.service.ts # src/app/core/entity-details/entity-details/entity-details.component.spec.ts # src/app/core/permissions/permission-guard/entity-permission.guard.spec.ts # src/app/core/permissions/permission-guard/entity-permission.guard.ts
🎉 This PR is included in version 3.28.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see #1947, #2047 , #2048
Remaining bugs & issues:
prevent change of dataType to something that can't auto-transform existing data- or make datatype transformation more fault tolerant? (--> date, entity, location)Problems:
Form Designer
Field Details
savereturn the updated entity config to be savedLater (?):
configure array dataType - or make the types supporting arrays available as own dataTypes (like entity-array already)Config & Architecture discussions
{ header?: string; fields: FormFieldConfig[]; }