A Pegasus-IBC walkthrough tutorial #7533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endo integration
* fix: nextAuction timing when startFrequency is reduced * chore: change type of AuctionParams * chore: improved types for timestamps in governance --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
feat(zoe): error on unexpected properties from start()
…nce-label refactor(swingset-liveslots): rep vs instance label tests more similar
refactor(store): Use @endo/(pass-style,patterns,exo) and drop our stale copies
Now that `kindHandleToID` is a *strong* Map, KindHandles are held strongly, from definition/reanimation time through to the end of the incarnation. That means their prototype is no longer useful as a GC sensor, and we don't need to use `linkToCohort` or `unweakable` to prevent userspace from trying.
Previously, we stored both the static parts of a
DurableKindDescriptor (tag, stateShape) and the dynamic
part (nextInstanceID) in the same vatStore
key (`vom.dkind.${kindID}`). This meant we had to re-write the whole
thing each time we make a new instance, which seems like a waste.
This change splits the next instance ID out to a separate key:
* `vom.dkind.${kindID}.descriptor`: holds the static descriptor
* `vom.dkind.${kindID}.nextID`: holds the next instance ID
Note that KindIDs are always integers, and we always append the
.descriptor/.nextID suffix, so I'm not worried about vatstore key
confusion/collision.
It also changes the merely-virtual Kind descriptor key to match:
`vom.vkind.${kindID}.descriptor`. Note that we don't bother recording
a `nextID` for virtual Kinds, since these never outlive an
incarnation, so we can hold the nextInstanceID in RAM. We only write
out the descriptor for external tooling and debugging, anyways.
Internally, `nextInstanceID` is now a BigInt, because we use `Nat()`
on the value we get back from the vatstore. This is not exposed to
userspace, and vrefs are strings (which incorporate the ID).
closes Agoric#7364
VOM: split nextInstanceID into a separate vatstore key
Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
not relevant to test terms that aren't generated by bootstrap
refactor tests to use bootstrap to get the reserve surround the transfers for empty-checks.
…erve feat(auction): auction send leftovers to Reserve
…rnel-quiescent feat(cosmic-swingset): poll timer after swingset quiescent
7400 governance docs
fix(vbank): properly detect module accounts
…ript Add incarnation number to the transcript store records
Co-Authored-By: Brian Warner <warner@lothar.com>
fix(zcf): mint kind during reincarnation
refactor(cache): jessie-check where easy
…check refactor(casting): jessie-check where easy
…-jessie-check refactor(cosmic-swingset): jessie-check where easy
…-check refactor(notifier): jessie-check where easy
…-checks refactor(vat-data): jessie-check where easy
refactor(zone): jessie-check where easy
warner
added a commit
that referenced
this pull request
Apr 29, 2023
This changes the snapshot scheduling logic to be more consistent. We still use `snapshotInitial` to trigger a snapshot shortly after worker initialization, and `snapshotInterval` to trigger periodic ones after that. However the previous code compared `snapshotInitial` to the absolute deliveryNum, which meant it only applied to the first incarnation, and would not attempt to take a snapshot shortly after upgrade, leaving the kernel vulnerable to replaying the long `startVat` delivery for a larger window than we intended. And `snapshotInterval` was compared against the difference between the latest transcript and the latest snapshot, which changed with the addition of the load-worker pseudo-entry. The new code uses `snapshotInitial` whenever there is not an existing snapshot (so the first span of *all* incarnations), and compares it against the length of the current span (so it includes all the pseudo-events). `snapshotInterval` is also compared against the length of the current span. The result is simpler and more predictable set of rules: * in the first span of each incarnation, trigger a snapshot once we have at least `snapshotInterval` entries * in all other spans, trigger once we have at least `snapshotInterval` In addition, when triggering a snapshot, we perform a BringOutYourDead delivery before asking the worker to save a snapshot. This gives us one last chance to shake out any garbage (making the snapshot as small as possible), and reduces the variation we might see forced GC that happens during snapshot write (any FinalizationRegistry callbacks should get run during the BOYD, not the save-snapshot). closes #7533 closes #7504
|
oops, sorry, I wrote the wrong ticket number into my PR, it has nothing to do with Pegasus or IBC |
|
Hi @anilhelvaci ! Are you interested in updating this PR? I would be willing to review it. Sorry that it slipped through the cracks. |
|
Hey @michaelfig, sure! I would love to improve this, just need to make some time for in my schedule. To understand how much work it requires, can you point me to some docs regarding the questions below;
|
Let's hold off for now, until after we can make Pegasus permissionless and use the Orchestration APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7532
refs: #7532
Description
I've created a walkthrough tutorial for those who are new to both IBC and Pegasus. The architecture is as below:
gaiadandgmmake scenario2-run-chainPegasusPegasusSecurity Considerations
This process requires users to access
home.pegasusConnectionsin ag-solo. This is currently not allowed but also needed to use pegasus.Scaling Considerations
None.
Documentation Considerations
I don't believe there's any documentation for
PegasusTesting Considerations
This PR does not contain any new functionality to the sdk.