-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use ses-ava #9026
base: master
Are you sure you want to change the base?
test: use ses-ava #9026
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -6,7 +6,8 @@ import fs from 'fs'; | |||||||
import { tmpName } from 'tmp'; | ||||||||
import { type as osType } from 'os'; | ||||||||
import sqlite3 from 'better-sqlite3'; | ||||||||
import test from 'ava'; | ||||||||
// eslint-disable-next-line import/order | ||||||||
import { test } from '../tools/prepare-test-env-ava.js'; | ||||||||
Comment on lines
+9
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please avoid introducing a lint suppression. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aside from fixing endojs/endo#1467 , how? See previous discussion at endojs/endo#1439 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that seems to be the only way. Out of scope, I suppose. At the least please use
Suggested change
|
||||||||
import { makeMeasureSeconds } from '@agoric/internal'; | ||||||||
import { xsnap } from '@agoric/xsnap'; | ||||||||
import { getLockdownBundle } from '@agoric/xsnap-lockdown'; | ||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why does this file need to be repeated in every package? Shouldn't import test from '@endo/ses-ava'; This is how Ava works. I don't see why ses-ava needs to work so differently. |
||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* global Buffer */ | ||
import test from 'ava'; | ||
import { test } from './prepare-test-env-ava.js'; | ||
|
||
import { | ||
encode, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { wrapTest } from '@endo/ses-ava'; | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
import { wrapTest } from '@endo/ses-ava'; | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import '@endo/init/debug.js'; | ||
|
||
import rawTest from 'ava'; | ||
import { wrapTest } from '@endo/ses-ava'; | ||
|
||
/** @type {typeof rawTest} */ | ||
export const test = wrapTest(rawTest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason for upgrade tests to run under lockdown. They're scripting the chain which is fully locked down. Please leave these as is so we don't have this extra boilerplate to write the tests.