Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use ses-ava #9026

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason for upgrade tests to run under lockdown. They're scripting the chain which is fully locked down. Please leave these as is so we don't have this extra boilerplate to write the tests.


import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
3 changes: 2 additions & 1 deletion packages/SwingSet/test/test-bundle-handler.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../tools/prepare-test-env-ava.js';

import {
getLockdownBundleSHA256,
Expand Down
3 changes: 2 additions & 1 deletion packages/SwingSet/test/test-xsnap-store.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import fs from 'fs';
import { tmpName } from 'tmp';
import { type as osType } from 'os';
import sqlite3 from 'better-sqlite3';
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../tools/prepare-test-env-ava.js';
Comment on lines +9 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid introducing a lint suppression.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from fixing endojs/endo#1467 , how? See previous discussion at endojs/endo#1439 (comment)

Copy link
Member

@turadg turadg Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems to be the only way. Out of scope, I suppose.

At the least please use // eslint-disable-line so that reordering imports doesn't break the association of the comment with the line. Also would be good to indicate this is not to be emulated by linking to the issue.

Suggested change
// eslint-disable-next-line import/order
import { test } from '../tools/prepare-test-env-ava.js';
import { test } from '../tools/prepare-test-env-ava.js'; // eslint-disable-line import/order -- https://github.com/endojs/endo/issues/1467

import { makeMeasureSeconds } from '@agoric/internal';
import { xsnap } from '@agoric/xsnap';
import { getLockdownBundle } from '@agoric/xsnap-lockdown';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../../tools/prepare-test-env-ava.js';

import tmp from 'tmp';
import { kunser } from '@agoric/kmarshal';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../../tools/prepare-test-env-ava.js';

import { kunser } from '@agoric/kmarshal';
import { initSwingStore } from '@agoric/swing-store';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @ts-nocheck
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../../tools/prepare-test-env-ava.js';

import { kunser } from '@agoric/kmarshal';
import { initSwingStore } from '@agoric/swing-store';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @ts-nocheck
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from '../../tools/prepare-test-env-ava.js';
import { createHash } from 'crypto';

import { initSwingStore } from '@agoric/swing-store';
Expand Down
2 changes: 2 additions & 0 deletions packages/access-token/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"tmp": "^0.2.1"
},
"devDependencies": {
"@endo/init": "^1.0.4",
"@endo/ses-ava": "^1.1.2",
"@types/n-readlines": "^1.0.3",
"@types/proper-lockfile": "^4.1.2",
"ava": "^5.3.0",
Expand Down
7 changes: 7 additions & 0 deletions packages/access-token/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this file need to be repeated in every package?

Shouldn't @endo/ses-ava take care of this? E.g. in a test you can simply import,

import test from '@endo/ses-ava';

This is how Ava works. I don't see why ses-ava needs to work so differently.


import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
2 changes: 1 addition & 1 deletion packages/access-token/test/test-state.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';
import { tmpDir } from './tmp.js';
import {
initJSONStore,
Expand Down
2 changes: 1 addition & 1 deletion packages/access-token/test/test-token.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';
import { tmpDir } from './tmp.js';

import { getAccessToken } from '../src/access-token.js';
Expand Down
2 changes: 2 additions & 0 deletions packages/agoric-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"lint:eslint": "eslint ."
},
"devDependencies": {
"@endo/init": "^1.0.4",
"@endo/ses-ava": "^1.1.2",
"@agoric/cosmic-swingset": "^0.41.3",
"@agoric/deploy-script-support": "^0.10.3",
"ava": "^5.3.0",
Expand Down
7 changes: 7 additions & 0 deletions packages/agoric-cli/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
4 changes: 2 additions & 2 deletions packages/agoric-cli/test/test-inter-cli.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// @ts-check
/* global Buffer */
import '@endo/init';
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';
import { createCommand, CommanderError } from 'commander';

import { Far } from '@endo/far';
Expand Down
4 changes: 2 additions & 2 deletions packages/agoric-cli/test/test-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import '@agoric/casting/node-fetch-shim.js';
import '@endo/init/pre.js';
import 'esm';
import '@endo/init/debug.js';
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';
import fs from 'fs';
import anylogger from 'anylogger';

Expand Down
4 changes: 1 addition & 3 deletions packages/agoric-cli/test/test-publish-bundle.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
// @ts-check
/* eslint-env node */

import '@endo/init/debug.js';

import * as http from 'http';
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

import { makeJsonHttpClient } from '../src/json-http-client-node.js';
import {
Expand Down
3 changes: 1 addition & 2 deletions packages/cache/test/test-storage.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Must be first to set up globals
import '@agoric/zoe/tools/prepare-test-env.js';
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';

import test from 'ava';
import { makeChainStorageRoot } from '@agoric/internal/src/lib-chainStorage.js';

import { Far, makeMarshal } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/cosmic-swingset/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"tmp": "^0.2.1"
},
"devDependencies": {
"@endo/ses-ava": "^1.1.2",
"ava": "^5.3.0",
"c8": "^7.13.0"
},
Expand Down
7 changes: 7 additions & 0 deletions packages/cosmic-swingset/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
2 changes: 1 addition & 1 deletion packages/cosmic-swingset/test/test-clean-core-eval.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';
import {
defangEvaluableCode,
compartmentEvaluate,
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmic-swingset/test/test-export-storage.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @ts-check
import test from 'ava';
import { test } from './prepare-test-env-ava.js';
import { exportStorage } from '../src/export-storage.js';

const makeBatchChainStorage = published => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* global setTimeout */
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

// Use ambient authority only in test.before()
import { spawn as ambientSpawn } from 'child_process';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable ava/assertion-arguments -- the standard diff is unreadable */
// eslint-disable-next-line import/no-extraneous-dependencies
import test from 'ava';
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';
import { buildVatController, buildKernelBundles } from '@agoric/swingset-vat';
import bundleSource from '@endo/bundle-source';
import zcfBundle from '@agoric/zoe/bundles/bundle-contractFacet.js';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';

import { AmountMath } from '@agoric/ertp';
import { Far } from '@endo/marshal';
Expand Down
4 changes: 4 additions & 0 deletions packages/internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@
},
"devDependencies": {
"@endo/init": "^1.0.4",
"@endo/ses-ava": "^1.1.2",
"ava": "^5.3.0",
"tsd": "^0.30.4"
},
"ava": {
"files": [
"test/**/test-*.js"
],
"require": [
"@endo/init/debug.js"
]
Expand Down
7 changes: 7 additions & 0 deletions packages/internal/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
3 changes: 2 additions & 1 deletion packages/internal/test/test-callback.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @ts-check
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

import { Far } from '@endo/far';
import { makeHeapZone } from '@agoric/base-zone/heap.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/internal/test/test-netstring.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* global Buffer */
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

import {
encode,
Expand Down
2 changes: 1 addition & 1 deletion packages/internal/test/test-priority-senders.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @ts-check
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

import { makeFakeStorageKit } from '../src/storage-test-utils.js';
import { HIGH_PRIORITY_SENDERS } from '../src/chain-storage-paths.js';
Expand Down
4 changes: 3 additions & 1 deletion packages/internal/test/test-storage-test-utils.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// @ts-check
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

import { Far } from '@endo/far';
import { makeMarshal } from '@endo/marshal';

Expand Down
2 changes: 1 addition & 1 deletion packages/internal/test/test-upgrade-api.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @ts-check
import test from 'ava';
import { test } from './prepare-test-env-ava.js';
import {
makeUpgradeDisconnection,
isUpgradeDisconnection,
Expand Down
3 changes: 2 additions & 1 deletion packages/internal/test/test-utils.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// @ts-check
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

// eslint-disable-next-line import/order
import { Far } from '@endo/far';
import {
makeMeasureSeconds,
Expand Down
2 changes: 2 additions & 0 deletions packages/kmarshal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"@agoric/assert": "^0.6.0"
},
"devDependencies": {
"@endo/init": "^1.0.4",
"@endo/ses-ava": "^1.1.2",
"ava": "^5.3.0"
},
"publishConfig": {
Expand Down
7 changes: 7 additions & 0 deletions packages/kmarshal/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
2 changes: 1 addition & 1 deletion packages/kmarshal/test/test-basic.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

import { kser, kunser, krefOf, kslot } from '../src/kmarshal.js';

Expand Down
5 changes: 4 additions & 1 deletion packages/notifier/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { wrapTest } from '@endo/ses-ava';
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
4 changes: 2 additions & 2 deletions packages/notifier/test/test-publish-kit.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* eslint-disable @typescript-eslint/prefer-ts-expect-error -- https://github.com/Agoric/agoric-sdk/issues/4620 */
/* eslint-disable no-void */

import '@agoric/swingset-liveslots/tools/prepare-test-env.js';
import test from 'ava';
import { test } from '@agoric/swingset-liveslots/tools/prepare-test-env-ava.js';

import { E } from '@endo/far';
import {
buildKernelBundles,
Expand Down Expand Up @@ -80,7 +80,7 @@
}
} else {
const { tail: _tail, ...props } = firstCell;
cells.slice(1).forEach((cell, i) => {

Check warning on line 83 in packages/notifier/test/test-publish-kit.js

View workflow job for this annotation

GitHub Actions / lint-rest

Prefer for...of instead of Array.forEach
t.like(cell, props, `${label} cell ${i + 1} must match cell 0`);
});
}
Expand Down
4 changes: 3 additions & 1 deletion packages/store/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { wrapTest } from '@endo/ses-ava';
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
3 changes: 2 additions & 1 deletion packages/store/test/test-AtomicProvider.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable no-use-before-define */
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

import test from 'ava';
import { Far } from '@endo/marshal';
import { setTimeout } from 'timers';

Expand Down
4 changes: 2 additions & 2 deletions packages/store/test/test-store.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable no-use-before-define */
import { test } from './prepare-test-env-ava.js';

import test from 'ava';

// eslint-disable-next-line import/order
import { Far, passStyleOf } from '@endo/marshal';
import { makeLegacyMap } from '../src/legacy/legacyMap.js';
import { makeLegacyWeakMap } from '../src/legacy/legacyWeakMap.js';
Expand Down
1 change: 1 addition & 0 deletions packages/swing-store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
},
"devDependencies": {
"@endo/init": "^1.0.4",
"@endo/ses-ava": "^1.1.2",
"@types/better-sqlite3": "^7.5.0",
"ava": "^5.3.0",
"c8": "^7.13.0",
Expand Down
7 changes: 7 additions & 0 deletions packages/swing-store/test/prepare-test-env-ava.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import '@endo/init/debug.js';

import rawTest from 'ava';
import { wrapTest } from '@endo/ses-ava';

/** @type {typeof rawTest} */
export const test = wrapTest(rawTest);
4 changes: 3 additions & 1 deletion packages/swing-store/test/test-bundles.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// @ts-check
import test from 'ava';
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

import tmp from 'tmp';
import { Buffer } from 'buffer';
import { createSHA256 } from '../src/hasher.js';
Expand Down
4 changes: 3 additions & 1 deletion packages/swing-store/test/test-deletion.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// @ts-check
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

// eslint-disable-next-line import/order
import { Buffer } from 'node:buffer';
import { initSwingStore } from '../src/swingStore.js';

Expand Down
2 changes: 1 addition & 1 deletion packages/swing-store/test/test-export.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

import { buffer } from '../src/util.js';
import { initSwingStore, makeSwingStoreExporter } from '../src/index.js';
Expand Down
3 changes: 2 additions & 1 deletion packages/swing-store/test/test-exportImport.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// @ts-check
// eslint-disable-next-line import/order
import { test } from './prepare-test-env-ava.js';

import { Buffer } from 'node:buffer';

import test from 'ava';
import tmp from 'tmp';
import bundleSource from '@endo/bundle-source';

Expand Down
2 changes: 1 addition & 1 deletion packages/swing-store/test/test-hasher.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import test from 'ava';
import { test } from './prepare-test-env-ava.js';

// eslint-disable-next-line import/order
import { createSHA256 } from '../src/hasher.js';
Expand Down
Loading
Loading