Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ForemanApi #175
add ForemanApi #175
Changes from all commits
c8817e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually catch this? We use these methods (like
cast()
) unconditionally so I'd drop the try/except.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never be thrown on Python 3, but the vendoring in FAM breaks if typing stuff is not try'ed, I'll fix that soon, but didn't yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#182 is where this will be tackled
Check warning on line 11 in apypie/foreman.py
apypie/foreman.py#L10-L11
Check warning on line 134 in apypie/foreman.py
apypie/foreman.py#L134
Check warning on line 151 in apypie/foreman.py
apypie/foreman.py#L151
Check warning on line 156 in apypie/foreman.py
apypie/foreman.py#L156
Check warning on line 170 in apypie/foreman.py
apypie/foreman.py#L170
Check warning on line 185 in apypie/foreman.py
apypie/foreman.py#L185
Check warning on line 200 in apypie/foreman.py
apypie/foreman.py#L200
Check warning on line 205 in apypie/foreman.py
apypie/foreman.py#L205