Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate show notification button option #5302

Merged

Conversation

migcarde
Copy link
Contributor

@migcarde migcarde commented May 9, 2024

Feature Preview

close #4847

Grabacion.2024-05-09.205742.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 9, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Identical pattern 688 warning contribute (via Fink 🐦)
Message without source 84 warning contribute (via Fink 🐦)
Missing translation 16497 warning contribute (via Fink 🐦)

@LucasXu0 LucasXu0 requested a review from Xazin May 10, 2024 02:10
migcarde and others added 3 commits May 10, 2024 19:45
…widgets/settings_notifications_view.dart

Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
…ions/widgets/notification_button.dart

Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
…otifications/notification_settings_cubit.dart

Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
@Xazin
Copy link
Collaborator

Xazin commented May 13, 2024

Seems there are some issues due to merge.

You might have to rename the usage of FlowySettingListTile to SettingListTile.

@migcarde
Copy link
Contributor Author

Seems there are some issues due to merge.

You might have to rename the usage of FlowySettingListTile to SettingListTile.

Resolved naming with this Widget.

@Xazin Xazin added the v0.5.9 label May 16, 2024
@LucasXu0 LucasXu0 force-pushed the feature/option-to-not-show-notifications-icon branch from 930f44c to f23d675 Compare May 30, 2024 02:18
@LucasXu0 LucasXu0 force-pushed the feature/option-to-not-show-notifications-icon branch from f23d675 to 6e925fe Compare May 30, 2024 02:21
@LucasXu0 LucasXu0 added the improvements improvements on an existing feature label May 30, 2024
@LucasXu0 LucasXu0 merged commit 526de2e into AppFlowy-IO:main May 30, 2024
13 of 16 checks passed
zoli added a commit to zoli/AppFlowy that referenced this pull request Jun 2, 2024
* main: (25 commits)
  fix: sidebar issues (AppFlowy-IO#5444)
  fix: notification test (AppFlowy-IO#5440)
  fix: some list icons don't align with the paragraph (AppFlowy-IO#5439)
  feat: integrate show notification button option (AppFlowy-IO#5302)
  feat: add border to selected unsplash image (AppFlowy-IO#5428)
  feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418)
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5421)
  chore: update Spanish translations (AppFlowy-IO#5205)
  feat: video block support (AppFlowy-IO#5199)
  feat: add reset app scale hotkey (AppFlowy-IO#5386)
  fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431)
  feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425)
  fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404)
  chore: improve hover and text colors in dark mode (AppFlowy-IO#5416)
  fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414)
  feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343)
  fix: default text direction not synced (AppFlowy-IO#5405)
  chore: update German translations (AppFlowy-IO#5382)
  feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401)
  feat: support open row page (AppFlowy-IO#5400)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements improvements on an existing feature v0.5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Option to not show notifications icon, when there isnt any notification
4 participants