Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sidebar issues #5444

Merged
merged 14 commits into from
May 31, 2024
Merged

fix: sidebar issues #5444

merged 14 commits into from
May 31, 2024

Conversation

LucasXu0
Copy link
Collaborator

Feature Preview

  • The view name of the recent list is rendered very slowly, it takes a long time to wait, and it is empty after switching tabs
  • Cannot click on a Favorite View in More menu to go to that View
  • The button for expanding and collapsing the mobile homepage are a bit small, and it is easy to accidentally open the page
  • The pinned docs should also show up in the search list
  • remove the widget button.
  • click a doc in the favorite search list → doesn’t direct me to the page
  • Copy “Collapse all subpages
  • Remove text is not fully displayed
  • The emoji panel is not replaced
  • Copy “Close sidebar”
  • Grid and Calendar doesn’t have titles in Recents tab, takes long time to show
  • Can’t see menu for database views, can’t favourite them without it
  • click on “More” → should be active in the search bar without requiring me to click

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Identical pattern 12 warning contribute (via Fink 🐦)

LucasXu0 and others added 2 commits May 30, 2024 22:38
@LucasXu0
fix: keep tab views alive
e695c41
@LucasXu0 @Xazin
chore: update frontend/appflowy_flutter/lib/mobile/presentation/page_…
4d00d81 
…item/mobile_view_item.dart

Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
@LucasXu0 LucasXu0 added bug Something isn't working v0.5.9 labels May 31, 2024
@LucasXu0 LucasXu0 merged commit 2c0cdfa into AppFlowy-IO:main May 31, 2024
16 checks passed
zoli added a commit to zoli/AppFlowy that referenced this pull request Jun 2, 2024
@zoli
style: Merge branch 'main' into feat/time-field-type-2
fae5607 
* main: (25 commits)
  fix: sidebar issues (AppFlowy-IO#5444)
  fix: notification test (AppFlowy-IO#5440)
  fix: some list icons don't align with the paragraph (AppFlowy-IO#5439)
  feat: integrate show notification button option (AppFlowy-IO#5302)
  feat: add border to selected unsplash image (AppFlowy-IO#5428)
  feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418)
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5421)
  chore: update Spanish translations (AppFlowy-IO#5205)
  feat: video block support (AppFlowy-IO#5199)
  feat: add reset app scale hotkey (AppFlowy-IO#5386)
  fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431)
  feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425)
  fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404)
  chore: improve hover and text colors in dark mode (AppFlowy-IO#5416)
  fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414)
  feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343)
  fix: default text direction not synced (AppFlowy-IO#5405)
  chore: update German translations (AppFlowy-IO#5382)
  feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401)
  feat: support open row page (AppFlowy-IO#5400)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazin Xazin Xazin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v0.5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasXu0 @Xazin