Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept multi-key combination for customizing shortcuts & removes duplicates #5414

Merged

Conversation

MayurSMahajan
Copy link
Collaborator

@MayurSMahajan MayurSMahajan commented May 26, 2024

Solves:

#5413
Partially solves: #5355

Feature Preview

pr.preview.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 added bug Something isn't working v0.5.9 labels May 27, 2024
@LucasXu0 LucasXu0 merged commit 8b6575d into AppFlowy-IO:main May 27, 2024
13 checks passed
@MayurSMahajan MayurSMahajan deleted the fix_duplicate_shortcut_entries_5355 branch May 27, 2024 04:40
zoli added a commit to zoli/AppFlowy that referenced this pull request Jun 2, 2024
* main: (25 commits)
  fix: sidebar issues (AppFlowy-IO#5444)
  fix: notification test (AppFlowy-IO#5440)
  fix: some list icons don't align with the paragraph (AppFlowy-IO#5439)
  feat: integrate show notification button option (AppFlowy-IO#5302)
  feat: add border to selected unsplash image (AppFlowy-IO#5428)
  feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418)
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5421)
  chore: update Spanish translations (AppFlowy-IO#5205)
  feat: video block support (AppFlowy-IO#5199)
  feat: add reset app scale hotkey (AppFlowy-IO#5386)
  fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431)
  feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425)
  fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404)
  chore: improve hover and text colors in dark mode (AppFlowy-IO#5416)
  fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414)
  feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343)
  fix: default text direction not synced (AppFlowy-IO#5405)
  chore: update German translations (AppFlowy-IO#5382)
  feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401)
  feat: support open row page (AppFlowy-IO#5400)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants