Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debt: Abort deprecation #46

Closed
Ash258 opened this issue Jun 27, 2020 · 0 comments
Closed

debt: Abort deprecation #46

Ash258 opened this issue Jun 27, 2020 · 0 comments
Assignees
@Ash258
Labels
debt Code quality issues enhancement New feature or request meta released Changes already in main branch
Milestone
0.55

Comments

@Ash258
Copy link
Owner

Ash258 commented Jun 27, 2020 •
edited
Loading

ScoopInstaller#3628, ScoopInstaller#3936, ScoopInstaller#4135, ScoopInstaller#4230

Future:

  • Investigate $PSScmdlet throw usage
  • Improve code in general
    • Code duplication should be possible to remove in case of handling the throws
@Ash258 Ash258 added enhancement New feature or request debt Code quality issues labels Jun 27, 2020
@Ash258 Ash258 added this to the 0.55 milestone Jun 27, 2020
@Ash258 Ash258 mentioned this issue Jun 27, 2020
Closed
@Ash258 Ash258 self-assigned this Jun 28, 2020
@Ash258 Ash258 mentioned this issue Jul 2, 2020
Merged
This was referenced Jul 26, 2020
Merged
Closed
Merged
Ash258 added a commit that referenced this issue Jul 27, 2020
@Ash258
refactor(install): Easy abort deprecation
b4cf348 
#46
#21

Before: ![A](https://i.imgur.com/gfubC4I.png)

After: ![B](https://i.imgur.com/COCTHq3.png)

![AA](https://i.imgur.com/pjbxBR9.png)
![BB](https://i.imgur.com/OxWDmHu.png)
This was referenced Jul 27, 2020
Merged
Closed
Ash258 added a commit that referenced this issue Jul 30, 2020
@Ash258
refactor: Straightforward abort deprecation
c8f5b3b 
#46, #53

I did not expect that full deprecation will be that easy, so the original PR grow a bit and got really messy.
This is fraction of the previous PR with the easiest changes.

- Helper function
- Strict and safe `abort` replacement without additional side checks
@Ash258 Ash258 mentioned this issue Jul 30, 2020
Merged
Ash258 added a commit that referenced this issue Jul 30, 2020
@Ash258
refactor(decompress): Abort => Set-TerminatingError
dee46c7 
#46, #53
@Ash258 Ash258 mentioned this issue Jul 30, 2020
Merged
@Ash258 Ash258 added the meta label Aug 7, 2020
@Ash258 Ash258 changed the title debt: Abort depracation debt: Abort deprecation Aug 16, 2020
@Ash258 Ash258 added the in-NEW Changes are already available in NEW branch. Configure SCOOP_BRANCH to NEW to beta-test changes label Aug 19, 2020
Ash258 added a commit that referenced this issue Aug 20, 2020
@Ash258
fix(checkver): dl_with_cache did not produce exception
8d555b1 
#46
@Ash258 Ash258 added in-main Already merged to main branch and removed in-NEW Changes are already available in NEW branch. Configure SCOOP_BRANCH to NEW to beta-test changes labels Sep 5, 2020
@Ash258 Ash258 added in-NEW Changes are already available in NEW branch. Configure SCOOP_BRANCH to NEW to beta-test changes and removed in-main Already merged to main branch labels Oct 31, 2020
@Ash258 Ash258 closed this as completed in df733c2 Dec 7, 2020
@Ash258 Ash258 added in-main Already merged to main branch released Changes already in main branch and removed in-NEW Changes are already available in NEW branch. Configure SCOOP_BRANCH to NEW to beta-test changes in-main Already merged to main branch labels Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ash258 Ash258

Labels
debt Code quality issues enhancement New feature or request meta released Changes already in main branch
Projects
None yet
Milestone
0.55
Development

No branches or pull requests
1 participant
@Ash258