Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Straightforward abort deprecation #55

Merged
merged 2 commits into from
Jul 30, 2020
Merged

refactor: Straightforward abort deprecation #55

merged 2 commits into from
Jul 30, 2020

Conversation

Ash258
Copy link
Owner

@Ash258 Ash258 commented Jul 30, 2020

#46, #53

I did not expect that full deprecation will be that easy in general, so the original PR grows a bit and got really messy.
This is fraction of the previous PR with the easiest changes.

  • Helper function
  • Strict and safe abort replacement without additional side checks

@Ash258
refactor: Straightforward abort deprecation
c8f5b3b 
#46, #53

I did not expect that full deprecation will be that easy, so the original PR grow a bit and got really messy.
This is fraction of the previous PR with the easiest changes.

- Helper function
- Strict and safe `abort` replacement without additional side checks
@Ash258
fix
6608b00
@Ash258 Ash258 merged commit 446a5d7 into NEW Jul 30, 2020
@Ash258 Ash258 deleted the cleanerAbortWave3 branch July 30, 2020 19:20
@Ash258 Ash258 added this to the 0.55 milestone Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55
Development

Successfully merging this pull request may close these issues.
1 participant
@Ash258