forked from ScoopInstaller/Scoop
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Complete abort deprecation 🎉 #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#46 #21 Before: ![A](https://i.imgur.com/gfubC4I.png) After: ![B](https://i.imgur.com/COCTHq3.png) ![AA](https://i.imgur.com/pjbxBR9.png) ![BB](https://i.imgur.com/OxWDmHu.png)
Missing only the one related to downloads
Almost ready 🎉 only one last problem with download progress hiding for some reason. Should disappear as soon as it is refactored, but it will be in near future. Needs to be proper tested on various environments |
Ash258
changed the title
refactor(install): Easy abort deprecation
refactor(install): Complete abort deprecation 🎉
Jul 27, 2020
Ash258
changed the title
refactor(install): Complete abort deprecation 🎉
refactor: Complete abort deprecation 🎉
Jul 27, 2020
Test and most likely fix dependencies installation failures. |
Ash258
added a commit
that referenced
this pull request
Jul 30, 2020
Last 2 things 🎉🎉🎉
|
Only download adtoption remaining
Propertly test checkver! |
Abort free 🎉🎉 Lets test it this weekend and it can arrive in NEW |
Looks pretty good |
Ash258
commented
Aug 8, 2020
Ash258
commented
Aug 8, 2020
|
Ash258
commented
Aug 16, 2020
Lets do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScoopInstaller#3628, ScoopInstaller#3936, ScoopInstaller#4135, ScoopInstaller#4230, ScoopInstaller#4529
#46, #21, #10
There is still much code duplication, but not on the bottom level. The top level duplication could be eliminated in future. There is no reason to hold up this PR due to small code repetition.
Before:
After: