Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplication not handling specific posts #498

Closed
adekbadek opened this issue May 27, 2020 · 1 comment · Fixed by #500
Closed

Deduplication not handling specific posts #498

adekbadek opened this issue May 27, 2020 · 1 comment · Fixed by #500
Assignees
@adekbadek
Labels
[Block] Homepage Posts bug Something isn't working released

Comments

@adekbadek
Copy link
Member

Describe the bug
When a Homepage Posts block has a specific post set, this post will not be ignored in dedupliaction:

image

This appears only in the frontend (PHP view), not in the editor.

To Reproduce
Steps to reproduce the behavior:

  1. Insert two Homepage Posts blocks, each showing one post
  2. Set the second one to display specific posts. Choose the post displayed by the first block
  3. Observe that in the editor the blocks are displaying different posts, but in the frontend view they are displaying the same post

Expected behavior
This layout should display posts without duplication.
@adekbadek adekbadek added bug Something isn't working [Block] Homepage Posts labels May 27, 2020
@adekbadek adekbadek self-assigned this May 27, 2020
adekbadek added a commit that referenced this issue May 28, 2020
@adekbadek
fix(homepage-posts): exclude specific posts from other blocks from query
f96f034 
Closes #498
@adekbadek adekbadek mentioned this issue May 28, 2020
Merged
6 tasks
adekbadek added a commit that referenced this issue Jun 5, 2020
@adekbadek
fix(homepage-posts): exclude specific posts from other blocks from qu…
31181a5 
…ery (#500)

Closes #498
matticbot pushed a commit that referenced this issue Jun 9, 2020
@semantic-release-bot
chore(release): 1.7.1 [skip ci]
09eb596 
## [1.7.1](v1.7.0...v1.7.1) (2020-06-09)

### Bug Fixes

* always display query controls; disallow choosing 0 posts ([#497](#497)) ([b956111](b956111))
* correct order of arguments in implodes ([0f45074](0f45074))
* don't use main wp_query when rendering homepage posts ([9c804f6](9c804f6))
* reset postdata after restoring wp_query ([d9d01a6](d9d01a6))
* **homepage-posts:** exclude specific posts from other blocks from query ([#500](#500)) ([31181a5](31181a5)), closes [#498](#498)
* make bottom margin styles less specific for easier overrides ([#483](#483)) ([93c3aff](93c3aff))
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adekbadek adekbadek

Labels
[Block] Homepage Posts bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: exclude specific posts from other blocks from query Automattic/newspack-blocks
2 participants
@adekbadek @matticbot