Always display query controls #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if "Number of items" was set to 0 or empty, the query controls were not rendered
|
Noting this is probably identical to this Carousel issue/resolution: #479 |
claudiulodro
approved these changes
May 27, 2020
claudiulodro
added
[Status] Approved
Needs Changes or Feedback
and removed
[Status] Needs Review
labels
|
Good idea, I've added disallowing 0 posts in 4bf44e9 |
matticbot
pushed a commit
that referenced
this pull request
Jun 9, 2020
## [1.7.1](v1.7.0...v1.7.1) (2020-06-09) ### Bug Fixes * always display query controls; disallow choosing 0 posts ([#497](#497)) ([b956111](b956111)) * correct order of arguments in implodes ([0f45074](0f45074)) * don't use main wp_query when rendering homepage posts ([9c804f6](9c804f6)) * reset postdata after restoring wp_query ([d9d01a6](d9d01a6)) * **homepage-posts:** exclude specific posts from other blocks from query ([#500](#500)) ([31181a5](31181a5)), closes [#498](#498) * make bottom margin styles less specific for easier overrides ([#483](#483)) ([93c3aff](93c3aff))
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Resolves an unreported bug which causes part of "Display Settings" section to disappear.
How to test the changes in this Pull Request:
Other information: