Fix: exclude specific posts from other blocks from query

[adekbadek]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Ideally, creation of $all_specific_posts_ids array should happen once per page request (currently it happens once per HP block), but I don't know how to do that – all suggestions welcome!

Closes #498

How to test the changes in this Pull Request:

1. On master, reproduce Deduplication not handling specific posts #498
2. Switch to this branch, observe that Deduplication not handling specific posts #498 is not reproducible

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[claudiulodro]

For the globals question, you could do something like:

global $all_specific_posts_ids; // Or maybe even a static variable (https://www.tutorialspoint.com/php/php_static_variables.htm).

if ( ! is_array( $all_specific_post_ids ) ) {
	// Get all blocks and gather specificPosts ids of all Homepage Articles blocks.
	$blocks                 = parse_blocks( get_the_content() );
	$block_name             = apply_filters( 'newspack_blocks_block_name', 'newspack-blocks/homepage-articles' );
	$all_specific_posts_ids = array_reduce(
		$blocks,
		function ( $acc, $block ) use ( $block_name ) {
			if (
				$block_name === $block['blockName'] &&
				isset( $block['attrs']['specificMode'] ) &&
				isset( $block['attrs']['specificPosts'] ) &&
				count( $block['attrs']['specificPosts'] )
			) {
				return array_merge(
					$block['attrs']['specificPosts'],
					$acc
				);
			}
			return $acc;
		},
		[]
	);
}

[adekbadek]

Thanks Claudiu, that works! In: dd93454

[claudiulodro]

Looks good and works well 👍

Definitely doesn't need to be revised here, but here's a fun protip for future reference:

isset( $block['attrs']['specificMode'] ) && isset( $block['attrs']['specificPosts'] )

can be simplified as

isset( $block['attrs']['specificMode'], $block['attrs']['specificPosts'] )

You can pass any number of things into isset and it'll return true only if they are all set. :)

[matticbot]

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀