Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set max width for nested full and wide blocks #827

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix: set max width for nested full and wide blocks #827

merged 1 commit into from
Mar 18, 2020

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Mar 12, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR makes sure nested full and wide-align blocks can't escape their containing blocks.

Closes #774.

How to test the changes in this Pull Request:

  1. Copy-paste this test content into the editor: https://cloudup.com/cfcmNomYh1N -- it's a wide and full-align homepage posts block nested in a group, column, and cover block.
  2. View on the front end; note that the blocks are coming out of their containers, or getting cut off in the case of the cover block.
  3. Apply the PR and run npm run build.
  4. Confirm that the blocks are now being contained by their parent blocks.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. labels Mar 12, 2020
claudiulodro
claudiulodro approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue. Looks good.

@claudiulodro claudiulodro added [Status] Approved The pull request has been reviewed and is ready to merge and removed Smaller PR This PR is smaller and quick to test. [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 17, 2020
@laurelfulford
Copy link
Contributor Author

Thanks @claudiulodro! 🚀

@laurelfulford laurelfulford merged commit 22e2655 into master Mar 18, 2020
@laurelfulford laurelfulford deleted the fixes/774-wide-full-nested-blocks branch March 18, 2020 00:57
matticbot pushed a commit that referenced this pull request Mar 24, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
6ce93ce 
# [1.3.0](v1.2.0...v1.3.0) (2020-03-24)

### Bug Fixes

* change way featured images are added to fix missing titles ([#837](#837)) ([7fb8ff2](7fb8ff2))
* correct position of comment icon indicating current author ([#824](#824)) ([6778719](6778719))
* prevent id selector format error ([#833](#833)) ([2fdb043](2fdb043))
* remove style overrides from h2 in cover blocks ([#834](#834)) ([15eb042](15eb042))
* remove top margin on accent-header in column ([#829](#829)) ([f72a529](f72a529))
* set max width for nested full and wide blocks ([#827](#827)) ([22e2655](22e2655))
* set size for above copyright widget titles ([#828](#828)) ([aa4231f](aa4231f))

### Features

* filters for super cool ad inserter placements ([#839](#839)) ([e3ac56b](e3ac56b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage Posts Block In Column Overflows Container If Alignment Set
3 participants
@laurelfulford @matticbot @claudiulodro