Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for the Aside post format support #1810

Merged
merged 2 commits into from
May 30, 2022
Merged

Remove support for the Aside post format support #1810

merged 2 commits into from
May 30, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

With Automattic/newspack-blocks#1139, this PR removes support for the Aside Post Format from the theme and Homepage Posts block.

Closes #1807, Automattic/newspack-blocks#611, Automattic/newspack-blocks#610, Automattic/newspack-blocks#660

How to test the changes in this Pull Request:

  1. Add a couple posts with the Post Format 'Aside' assigned under 'Status & visibility'

image

  1. Set up a Homepage Posts block that will show posts with both the 'Standard' and 'Aside' formats.
  2. For the single view of the Aside posts, note that the post author is hidden.
  3. For the block view of the Aside posts, note that they look pretty different: they use a smaller font (regardless of type scale setting); they show the full body of the post; they have the author information hidden; and the post title doesn't link off to the full post:

A single post missing the byline at the top:
image

Homepage Posts block -- post #3 below is an Aside:
image

  1. Apply both this PR to the theme and feat: remove support for the aside post format newspack-blocks#1139 to the Newspack Blocks repo; run npm run build for each.
  2. Confirm that the posts marked 'Aside' are now being handled the same as regular posts: in the single post view, they should display the post author. In the Homepage Posts block, they should be the same size and show the same elements as standard posts.
  3. Try editing one of your posts and confirm that you no longer have an option to set a Post Format.
  4. Just out of an abundance of caution, confirm that single posts still have the CSS class single-format-aside on the body (indicating that they have still stored their 'Aside' format). The Homepage posts block will no longer display aside-related classes because the code adding the CSS class there has been removed with these changes.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label May 19, 2022
@laurelfulford laurelfulford requested a review from a team as a code owner May 19, 2022 21:43
@laurelfulford laurelfulford mentioned this pull request May 19, 2022
Merged
6 tasks
dkoo
dkoo approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 30, 2022
@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

@laurelfulford laurelfulford merged commit 7a9b213 into master May 30, 2022
@laurelfulford laurelfulford deleted the feat/1807-remove-asides branch May 30, 2022 21:08
matticbot pushed a commit that referenced this pull request Jun 2, 2022
@semantic-release-bot
chore(release): 1.59.0-alpha.1 [skip ci]
c17920c 
# [1.59.0-alpha.1](v1.58.3...v1.59.0-alpha.1) (2022-06-02)

### Bug Fixes

* make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7))
* remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84))
* remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9))

### Features

* add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb))
* add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709))
* remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 13, 2022
@semantic-release-bot
chore(release): 1.59.0 [skip ci]
c9cf78b 
# [1.59.0](v1.58.3...v1.59.0) (2022-06-13)

### Bug Fixes

* make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7))
* remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84))
* remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9))

### Features

* add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb))
* add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709))
* remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Aside post format support?
3 participants
@laurelfulford @matticbot @dkoo