Override hover effect from video block #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
the
[Status] Needs Review
adekbadek
approved these changes
May 31, 2022
github-actions
bot
added
[Status] Approved
|
Thanks! 🙌 |
matticbot
pushed a commit
that referenced
this pull request
Jun 2, 2022
# [1.59.0-alpha.1](v1.58.3...v1.59.0-alpha.1) (2022-06-02) ### Bug Fixes * make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7)) * remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84)) * remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9)) ### Features * add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb)) * add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709)) * remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
|
🎉 This PR is included in version 1.59.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jun 13, 2022
# [1.59.0](v1.58.3...v1.59.0) (2022-06-13) ### Bug Fixes * make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7)) * remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84)) * remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9)) ### Features * add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb)) * add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709)) * remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
|
🎉 This PR is included in version 1.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes an issue where a video block with certain settings will turn black on hover when AMP is enabled. This is because a
buttonelement is added to the video, covering the whole thing, and it's picking up the theme's black background on hover.Closes #1814.
How to test the changes in this Pull Request:
npm run build.Other information: