Move: use $from for object in Move::internally

[mattwiebe]

See #1513 especially this comment

According to the Draft Data Portability spec, section 4.1:

The user sends a Move activity from the old actor to all followers.

{
  "@context": "https://www.w3.org/ns/activitystreams",
  "type": "Move",
  "actor": "https://old.example/users/username",
  "object": "https://old.example/users/username",
  "target": "https://new.example/users/username"
}

Proposed changes:

• Set object to the $from param rather than the $to param in Move::internally

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

The testing is performed in the tests. You can manually call Move::internally yourself to verify if you wish.

Changelog entry

• Automatically create a changelog entry from the details below.

Use the `$from` account for the object in Move activity for internal Moves

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

Use the $from account for the object in Move activity for internal Moves

[mattwiebe]

I guess we should probably change this in Move::externally as well? Has it been working properly there?

[pfefferle]

Just re-checked the mastodon docs and you are right, object references the source id, not the target! Good find!

[pfefferle]

And we should definitely also change it for Move::externally!