Skip to content

Tests: Reduce chance of time offsets #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Tests: Reduce chance of time offsets #1527

merged 1 commit into from
Mar 31, 2025

Conversation

@obenland
Copy link
Member

@obenland obenland commented Mar 31, 2025 •
edited
Loading

I noticed a couple of failed tests recently that showed a time difference in the updated test:
https://github.com/Automattic/wordpress-activitypub/actions/runs/14176817608/job/39713607394?pr=1521

There was 1 failure:

1) Activitypub\Tests\Scheduler\Test_Actor::test_actor_profile_update_sets_updated_attribute
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'2025-03-31 16:47:02'
+'2025-03-31 16:47:01'

/tests/includes/scheduler/class-test-actor.php:322

This should give us a bit more wiggle room.

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Mar 31, 2025
@obenland obenland requested a review from a team March 31, 2025 16:51
@obenland obenland self-assigned this Mar 31, 2025
@obenland obenland merged commit d74236a into trunk Mar 31, 2025
15 checks passed
@obenland obenland deleted the update/updated-test branch March 31, 2025 17:10
@obenland obenland mentioned this pull request Apr 8, 2025
Merged
1 task
jsit added a commit to jsit/wordpress-activitypub that referenced this pull request Nov 1, 2025
@jsit
Merge tag '5.6.1' into fix/nicename
0812126 
* tag '5.6.1': (47 commits)
  Release 5.6.1 (Automattic#1542)
  Fix: Use specified time formatting for Outbox Activities (Automattic#1537)
  Fix: Default value for empty `movedTo` field (Automattic#1539)
  Fix: Post Interactions settings (Automattic#1540)
  Release 5.6.0 (Automattic#1534)
  lover significance (Automattic#1533)
  Scheduler: Don't federate Deletes of unfederated posts. (Automattic#1528)
  Move: use `$from` for object in `Move::externally` (Automattic#1531)
  Fix: Properly traverse the object hierarchy to get the ID (Automattic#1518)
  Mentions: Standardize around only displaying username (Automattic#1510)
  Tests: Reduce chance of time offsets (Automattic#1527)
  Import: Don't federate new attachments (Automattic#1526)
  Importer: Format import count number. (Automattic#1525)
  Move: Add a Mastodon importer (Automattic#1502)
  Move: use `$from` for object in `Move::internally` (Automattic#1516)
  Fix: Do not send self-replies (Automattic#1517)
  Fix: Delete Undone comments instead of trashing them (Automattic#1520)
  Dispatcher: Adhere to passed batch size. (Automattic#1514)
  Add interaction settings (Automattic#1395)
  Fix: Set proper default, to show Welcome screen by default (Automattic#1512)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels

Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@obenland @pfefferle