Fix: Delete Undone comments instead of trashing them #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenland
approved these changes
Mar 28, 2025
jsit
added a commit
to jsit/wordpress-activitypub
that referenced
this pull request
Nov 1, 2025
* tag '5.6.1': (47 commits) Release 5.6.1 (Automattic#1542) Fix: Use specified time formatting for Outbox Activities (Automattic#1537) Fix: Default value for empty `movedTo` field (Automattic#1539) Fix: Post Interactions settings (Automattic#1540) Release 5.6.0 (Automattic#1534) lover significance (Automattic#1533) Scheduler: Don't federate Deletes of unfederated posts. (Automattic#1528) Move: use `$from` for object in `Move::externally` (Automattic#1531) Fix: Properly traverse the object hierarchy to get the ID (Automattic#1518) Mentions: Standardize around only displaying username (Automattic#1510) Tests: Reduce chance of time offsets (Automattic#1527) Import: Don't federate new attachments (Automattic#1526) Importer: Format import count number. (Automattic#1525) Move: Add a Mastodon importer (Automattic#1502) Move: use `$from` for object in `Move::internally` (Automattic#1516) Fix: Do not send self-replies (Automattic#1517) Fix: Delete Undone comments instead of trashing them (Automattic#1520) Dispatcher: Adhere to passed batch size. (Automattic#1514) Add interaction settings (Automattic#1395) Fix: Set proper default, to show Welcome screen by default (Automattic#1512) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1421 (comment)
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Permanently delete reactions that were
Undoinstead of trashing them.