-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update wordpress monorepo (take 2) #41994
fix(deps): update wordpress monorepo (take 2) #41994
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~16433 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2607 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
0a46d7d
to
9e3b644
Compare
Rebased. |
This seems to have been introduced here in WordPress/gutenberg#19344: WordPress/gutenberg@ef73ed0#diff-ccdf667da5123277e79748286c32fda7R328-R333 if ( __unstableBoundaryParent ) {
boundaryElement = containerRef.current.closest(
'.popover-slot'
).parentNode;
} There's a bug, |
I've opened WordPress/gutenberg#22264 for the the Popover issue. |
9e3b644
to
9797d90
Compare
Nice, with WordPress/gutenberg#22264 now merged this should be about ready for another chance at deployment? Looking at the conflict in Master:
Here:
Rebased in favor of the latter. Is there anything else this needs to wait on at this point? |
9797d90
to
612ce59
Compare
Rebased to solve conflicts in |
We need a new release of I check https://unpkg.com/browse/@wordpress/components/src/popover/index.js to see whether it includes that change we need (latest is |
612ce59
to
8a02e79
Compare
Somehow I've apparently managed to mangle this. Let's proceed with Renovate's #42031 |
Second attempt at #41207 after it was reverted in #41974
Reverted due to:
Apparently Coming from here:
https://github.com/WordPress/gutenberg/blob/c9ce32fb147b864d7f1d15df8ede97699ded4e91/packages/components/src/popover/index.js#L331-L335