Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update wordpress monorepo #42031

Merged
merged 5 commits into from
May 18, 2020
Merged

fix(deps): update wordpress monorepo #42031

merged 5 commits into from
May 18, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 11, 2020

This PR contains the following updates:

Package Type Update Change
@wordpress/a11y dependencies minor 2.8.0 -> 2.9.0
@wordpress/api-fetch dependencies minor 3.12.0 -> 3.15.0
@wordpress/babel-plugin-makepot dependencies minor 3.4.0 -> 3.5.0
@wordpress/base-styles dependencies minor 1.5.0 -> 1.8.0
@wordpress/block-directory dependencies minor 1.6.0 -> 1.9.0
@wordpress/block-editor dependencies minor 3.8.0 -> 3.11.0
@wordpress/block-library dependencies minor 2.15.0 -> 2.18.0
@wordpress/blocks dependencies minor 6.13.0 -> 6.16.0
@wordpress/components dependencies minor 9.3.0 -> 9.6.0
@wordpress/compose dependencies minor 3.12.0 -> 3.15.0
@wordpress/core-data dependencies minor 2.13.0 -> 2.16.0
@wordpress/data dependencies minor 4.15.0 -> 4.18.0
@wordpress/data-controls dependencies minor 1.9.0 -> 1.12.0
@wordpress/dependency-extraction-webpack-plugin dependencies minor 2.4.0 -> 2.6.0
@wordpress/dom dependencies minor 2.8.0 -> 2.9.0
@wordpress/dom-ready dependencies minor 2.8.0 -> 2.9.0
@wordpress/e2e-test-utils dependencies minor 4.4.0 -> 4.7.0
@wordpress/edit-post dependencies minor 3.14.0 -> 3.17.0
@wordpress/editor dependencies minor 9.13.0 -> 9.16.0
@wordpress/element dependencies minor 2.12.0 -> 2.14.0
@wordpress/format-library dependencies minor 1.15.0 -> 1.18.0
@wordpress/i18n dependencies minor 3.10.0 -> 3.12.0
@wordpress/icons dependencies major 1.2.0 -> 2.0.0
@wordpress/is-shallow-equal dependencies major 1.8.0 -> 2.0.0
@wordpress/jest-preset-default dependencies major 5.5.0 -> 6.0.0
@wordpress/keyboard-shortcuts dependencies minor 1.2.0 -> 1.5.0
@wordpress/keycodes dependencies minor 2.10.0 -> 2.12.0
@wordpress/media-utils dependencies minor 1.8.0 -> 1.11.0
@wordpress/notices dependencies minor 2.1.0 -> 2.4.0
@wordpress/npm-package-json-lint-config dependencies major 2.2.0 -> 3.0.0
@wordpress/nux dependencies minor 3.13.0 -> 3.16.0
@wordpress/plugins dependencies minor 2.13.0 -> 2.16.0
@wordpress/primitives dependencies minor 1.2.0 -> 1.5.0
@wordpress/priority-queue dependencies minor 1.5.1 -> 1.6.0
@wordpress/redux-routine dependencies minor 3.7.0 -> 3.9.0
@wordpress/rich-text dependencies minor 3.13.0 -> 3.16.0
@wordpress/scripts dependencies major 7.2.0 -> 9.1.0
@wordpress/server-side-render dependencies minor 1.9.0 -> 1.12.0
@wordpress/shortcode dependencies minor 2.6.0 -> 2.7.0
@wordpress/url dependencies minor 2.12.0 -> 2.15.0
@wordpress/viewport dependencies minor 2.14.0 -> 2.17.0

Release Notes

WordPress/gutenberg

v2.9.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

Closes #41994

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 11, 2020 06:34
@matticbot
Copy link
Contributor

@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 4 times, most recently from a07116e to 24410a8 Compare May 14, 2020 13:08
@renovate renovate bot requested a review from a team as a code owner May 14, 2020 16:09
@sirreal
Copy link
Member

sirreal commented May 14, 2020

Cherry picked fixes (966819d) from #41994 / #41207

This should include the fix (WordPress/gutenberg#22264) that caused the first attempt to be reverted.

@simison simison requested review from scosgro and sgomes and removed request for scosgro May 14, 2020 16:10
@sirreal
Copy link
Member

sirreal commented May 14, 2020

This is new for me, the build is failing:

node build/bundle.js
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: …/node_modules/@babel/runtime/helpers/esm/extends.js
require() of ES modules is not supported.
require() of …/node_modules/@babel/runtime/helpers/esm/extends.js from …/build/bundle.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename extends.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from …/node_modules/@babel/runtime/helpers/esm/package.json.

    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1172:13)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.@babel/runtime/helpers/esm/extends (…/build/webpack:/external "@babel/runtime/helpers/esm/extends":1:1)
    at __webpack_require__ (…/build/webpack:/webpack/bootstrap:19:1)
    at Module../client/node_modules/react-redux/es/components/connectAdvanced.js (…/build/webpack:/client/node_modules/react-redux/es/components/connectAdvanced.js:1:1)
    at __webpack_require__ (…/build/webpack:/webpack/bootstrap:19:1)
    at Module../client/node_modules/react-redux/es/index.js (…/build/webpack:/client/node_modules/react-redux/es/index.js:1:1)
```

@sgomes
Copy link
Contributor

sgomes commented May 14, 2020

This PR is not just updating @wordpress/, it seems to be updating everything. Including a lot of development tools, like Babel.

@renovate
Copy link
Contributor Author

renovate bot commented May 14, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@scinos
Copy link
Contributor

scinos commented May 14, 2020

Looks like Renovate updated @wordpress/* and deduplicated all deps in the repo. Fixing it will require some yarn.lock surgery probably.

Edit: surgery done. I checked out yarn.lock from master, run yarn install so it updates it with the new versions of @wordpress/ already present in package.json, and did a pass with yarn-deduplicate only for @wordpress/ packages.

@scinos scinos mentioned this pull request May 14, 2020
@matticbot
Copy link
Contributor

matticbot commented May 14, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~141 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
manifest      -1570 B  (-0.9%)     -141 B  (-0.4%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~18265 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding       +87681 B  (+4.9%)   +17601 B  (+3.6%)
entry-main                 -1060 B  (-0.1%)     -142 B  (-0.0%)
entry-domains-landing       +123 B  (+0.0%)     +498 B  (+0.3%)
entry-login                  -16 B  (-0.0%)     +308 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4557 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
post-editor             +9748 B  (+0.5%)    +2553 B  (+0.5%)
gutenberg-editor        +6633 B  (+0.8%)    +2231 B  (+1.0%)
checkout                +6367 B  (+0.5%)    +1715 B  (+0.5%)
settings                 -354 B  (-0.1%)     -656 B  (-0.6%)
posts-custom             +166 B  (+0.1%)     +457 B  (+0.5%)
posts                    +166 B  (+0.1%)     +457 B  (+0.5%)
reader                   -132 B  (-0.0%)     -205 B  (-0.2%)
settings-writing         -121 B  (-0.0%)     +660 B  (+0.6%)
people                   -120 B  (-0.0%)    -1036 B  (-1.1%)
import                   -120 B  (-0.1%)     -847 B  (-1.5%)
zoninator                 -78 B  (-0.0%)     -587 B  (-0.8%)
devdocs                   +32 B  (+0.0%)      +34 B  (+0.1%)
google-my-business        +22 B  (+0.0%)       -2 B  (-0.0%)
plans                     -18 B  (-0.0%)      -79 B  (-0.1%)
email                     -18 B  (-0.0%)      -42 B  (-0.1%)
domains                   -18 B  (-0.0%)      -96 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~886 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-design-blocks                              -403 B  (-0.0%)     +686 B  (+0.1%)
async-load-components-web-preview-component           -300 B  (-0.1%)     -527 B  (-0.5%)
async-load-post-editor-media-modal                    -245 B  (-0.1%)     -292 B  (-0.4%)
async-load-design-playground                          -228 B  (-0.0%)     +571 B  (+0.1%)
async-load-design                                     -170 B  (-0.0%)     +935 B  (+0.2%)
async-load-post-editor-editor-author                  -120 B  (-0.7%)     -455 B  (-8.0%)
async-load-blocks-support-article-dialog-dialog       -108 B  (-0.1%)      -29 B  (-0.1%)
async-load-blocks-support-article-dialog               -54 B  (-5.0%)      -11 B  (-2.4%)
async-load-lib-preferences-helper                      +11 B  (+0.1%)       +8 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sgomes
Copy link
Contributor

sgomes commented May 15, 2020

That's quite the bump in size, unfortunately 😞 I think we should probably look at getting #42212 merged to avoid some of the hit with this update. It won't be necessary once some changes in Gutenberg make it to a release, but that's not the case yet, so we definitely should merge the stop-gap measure.

@sirreal sirreal force-pushed the renovate/wordpress-monorepo branch from cabca74 to 3a3a3ed Compare May 15, 2020 10:47
@sirreal
Copy link
Member

sirreal commented May 15, 2020

Rebased to fix conflicts

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onboarding "block" now get this fun toolbar:

Screen Shot 2020-05-15 at 12 45 38

We'll need to remove that.

@sirreal
Copy link
Member

sirreal commented May 15, 2020

@scinos yarn gives a dirty lock now 😬

yarn.lock diff
diff --git a/yarn.lock b/yarn.lock
index 94c297e720..022c84688d 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2781,11 +2781,6 @@
   dependencies:
     "@types/node" ">= 8"
 
-"@popperjs/core@^2.0.5":
-  version "2.0.6"
-  resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.0.6.tgz#5a39ac118811ca844155b0ad5190b8c24f35e533"
-  integrity sha512-zj7Gw8QC4jmR92eKUvtrZUEpl2ypRbq+qlE4pwf9n2hnUO9BOAcWUs4/Ht+gNIbFt98xtqhLvccdCfD469MzpQ==
-
 "@popperjs/core@^2.4.0":
   version "2.4.0"
   resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.4.0.tgz#0e1bdf8d021e7ea58affade33d9d607e11365915"
@@ -4345,7 +4340,7 @@
     text-table "^0.2.0"
     webpack-log "^1.1.2"
 
-"@wordpress/a11y@2.9.0", "@wordpress/a11y@^2.8.0", "@wordpress/a11y@^2.9.0":
+"@wordpress/a11y@2.9.0", "@wordpress/a11y@^2.9.0":
   version "2.9.0"
   resolved "https://registry.yarnpkg.com/@wordpress/a11y/-/a11y-2.9.0.tgz#5346497a9c5dfd47d8f8fe16c026e63a8f18954b"
   integrity sha512-1YBqy+yrAnCnQAayvQ6kx4O3vHq4EAyFh8UdNwbK0ZE4f+2Kzj/fD5QoICaTPl3vMzHb8ISeFyGFTxzqqBZh1g==
@@ -4364,7 +4359,7 @@
     "@wordpress/i18n" "^3.12.0"
     "@wordpress/url" "^2.15.0"
 
-"@wordpress/autop@^2.6.0", "@wordpress/autop@^2.7.0":
+"@wordpress/autop@^2.7.0":
   version "2.7.0"
   resolved "https://registry.yarnpkg.com/@wordpress/autop/-/autop-2.7.0.tgz#8cfedffcd3b6f41a6afd59ca4abbab67ea890ae9"
   integrity sha512-XLNyxlsdXPQMTHl3NnR1nbsggcf12euBwpp6d6qdVLT3+s2FtU2dg9dMVJg/OHKd3/QgA6W+k7yjcyME2aOAFQ==
@@ -4406,14 +4401,14 @@
   resolved "https://registry.yarnpkg.com/@wordpress/base-styles/-/base-styles-1.8.0.tgz#4735e7c8039c5290225441e472554352cb050d1b"
   integrity sha512-NXcR72DgB61dgcjEmRbbssRlvm5eTuCSOtMvvK7nzkN4J72sLfxXHEONeqzePt92D/60sX+AifmO8DmKN0zzPQ==
 
-"@wordpress/blob@^2.7.0", "@wordpress/blob@^2.8.0":
+"@wordpress/blob@^2.8.0":
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/@wordpress/blob/-/blob-2.8.0.tgz#5d35d7017d7ea340714de9b54f53ee2656f680f0"
   integrity sha512-5obAEfhdMaDftitAqMXkc8kWyDim1qS8FvVk7m+fZHnkJXFmxdZHJvCAerjjwI//GMVUvZEbpakdWGoW27TIWg==
   dependencies:
     "@babel/runtime" "^7.9.2"
 
-"@wordpress/block-directory@1.9.0", "@wordpress/block-directory@^1.6.0", "@wordpress/block-directory@^1.9.0":
+"@wordpress/block-directory@1.9.0", "@wordpress/block-directory@^1.9.0":
   version "1.9.0"
   resolved "https://registry.yarnpkg.com/@wordpress/block-directory/-/block-directory-1.9.0.tgz#e0106c2d5f5cad3128a31e0a1491ef44afa1d85a"
   integrity sha512-iE336G0U/9xeqvD0G45zPwWeSY8hrBL8zToJHNUdy16aij6FP5y08BSUBWOk2N+vJOnZ9CFJndV0jj3MPXpwkQ==
@@ -4512,7 +4507,7 @@
     moment "^2.22.1"
     tinycolor2 "^1.4.1"
 
-"@wordpress/block-serialization-default-parser@^3.5.0", "@wordpress/block-serialization-default-parser@^3.6.0":
+"@wordpress/block-serialization-default-parser@^3.6.0":
   version "3.6.0"
   resolved "https://registry.yarnpkg.com/@wordpress/block-serialization-default-parser/-/block-serialization-default-parser-3.6.0.tgz#4a9453a004a225a95d1f5c148d64087e5188badd"
   integrity sha512-4l1zrxaLd36qHSkTSx+2C3jM/fTD2NZG7mGGYPzL0/yevd1ZNkkc++7bxAGQuM7m8yPw+MKkiq9ETzNLoTHnbQ==
@@ -4590,7 +4585,7 @@
     tinycolor2 "^1.4.1"
     uuid "^7.0.2"
 
-"@wordpress/compose@*", "@wordpress/compose@1.x.x - 3.x.x", "@wordpress/compose@3.15.0", "@wordpress/compose@^3.12.0", "@wordpress/compose@^3.14.0", "@wordpress/compose@^3.15.0", "@wordpress/compose@^3.7.0", "@wordpress/compose@^3.7.2", "@wordpress/compose@^3.9.0":
+"@wordpress/compose@*", "@wordpress/compose@1.x.x - 3.x.x", "@wordpress/compose@3.15.0", "@wordpress/compose@^3.12.0", "@wordpress/compose@^3.15.0", "@wordpress/compose@^3.7.0", "@wordpress/compose@^3.7.2", "@wordpress/compose@^3.9.0":
   version "3.15.0"
   resolved "https://registry.yarnpkg.com/@wordpress/compose/-/compose-3.15.0.tgz#db6faacddc18c23baf6deec0ff4445c804f3afa6"
   integrity sha512-v174JYkPLECIfS5ebaKPengCG5FTyi9Ie6r6Mn2qJYsYXegvEdqCSreLsA3JViPvqC3Shx8MHnXBraz+kqYqQQ==
@@ -4629,7 +4624,7 @@
     "@wordpress/api-fetch" "^3.15.0"
     "@wordpress/data" "^4.18.0"
 
-"@wordpress/data@*", "@wordpress/data@4.18.0", "@wordpress/data@^4.11.0", "@wordpress/data@^4.15.0", "@wordpress/data@^4.17.0", "@wordpress/data@^4.18.0":
+"@wordpress/data@*", "@wordpress/data@4.18.0", "@wordpress/data@^4.11.0", "@wordpress/data@^4.15.0", "@wordpress/data@^4.18.0":
   version "4.18.0"
   resolved "https://registry.yarnpkg.com/@wordpress/data/-/data-4.18.0.tgz#e8497eb2e0ad3af5d2d7e79cdbecb0207e3ec364"
   integrity sha512-1Gj5BA/hjHC5dCdd6uwz5e6CltKTJIJSybuF3Nk6s9BqpgdvZ1srg330THuveibTRusV5ubQc1v9jfj8f47fPg==
@@ -4649,7 +4644,7 @@
     turbo-combine-reducers "^1.0.2"
     use-memo-one "^1.1.1"
 
-"@wordpress/date@*", "@wordpress/date@^3.7.0", "@wordpress/date@^3.8.0", "@wordpress/date@^3.9.0":
+"@wordpress/date@*", "@wordpress/date@^3.7.0", "@wordpress/date@^3.9.0":
   version "3.9.0"
   resolved "https://registry.yarnpkg.com/@wordpress/date/-/date-3.9.0.tgz#d2034952512363d38d4191c3786695905f4b67b1"
   integrity sha512-V4+k6Ipkm/JX1TzRcwo96v0Lk1m1NGAHwO9JsnUCCXlG1Qxgl+MxRkWpgmUwgdCDjVvevS/4bU+LvndDWQIzVA==
@@ -4667,7 +4662,7 @@
     webpack "^4.8.3"
     webpack-sources "^1.3.0"
 
-"@wordpress/deprecated@^2.7.0", "@wordpress/deprecated@^2.8.0":
+"@wordpress/deprecated@^2.8.0":
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/@wordpress/deprecated/-/deprecated-2.8.0.tgz#d6018cafc244f13877ac3760755466aa8a5ea3a4"
   integrity sha512-MX8ONW8Mf0w38Zllg3d412JcHuIaxmNoaVw03nCi9S31Dj/V3PHEAF8GDeSP0Sfn5DxSs5K4s9LfpE4C2iLgAw==
@@ -4675,7 +4670,7 @@
     "@babel/runtime" "^7.9.2"
     "@wordpress/hooks" "^2.8.0"
 
-"@wordpress/dom-ready@*", "@wordpress/dom-ready@2.9.0", "@wordpress/dom-ready@^2.8.0", "@wordpress/dom-ready@^2.9.0":
+"@wordpress/dom-ready@*", "@wordpress/dom-ready@2.9.0", "@wordpress/dom-ready@^2.9.0":
   version "2.9.0"
   resolved "https://registry.yarnpkg.com/@wordpress/dom-ready/-/dom-ready-2.9.0.tgz#964337de20b031bd54c60c040cc728097a525384"
   integrity sha512-2egz1f4LaLeeSPTsWUgvgerNUbV9A++x/YWBGiF8t/bC7KX1n4mqexQRihfuofvpBxlkalIJEXxka3pzrD1XHA==
@@ -4779,7 +4774,7 @@
     refx "^3.0.0"
     rememo "^3.0.0"
 
-"@wordpress/element@*", "@wordpress/element@2.14.0", "@wordpress/element@^2.12.0", "@wordpress/element@^2.13.1", "@wordpress/element@^2.14.0":
+"@wordpress/element@*", "@wordpress/element@2.14.0", "@wordpress/element@^2.12.0", "@wordpress/element@^2.14.0":
   version "2.14.0"
   resolved "https://registry.yarnpkg.com/@wordpress/element/-/element-2.14.0.tgz#54e9543269c8f898c4e375f09f119cfb414ce18e"
   integrity sha512-msSkGecq2Z8lBoj95D0vxj64lbGx7c7Q8VxsNLA3G813HVybeY5gYeWFokWKfok+tszCwjJI4ZgR4DxRsYNTig==
@@ -4790,7 +4785,7 @@
     react "^16.9.0"
     react-dom "^16.9.0"
 
-"@wordpress/escape-html@^1.7.0", "@wordpress/escape-html@^1.8.0":
+"@wordpress/escape-html@^1.8.0":
   version "1.8.0"
   resolved "https://registry.yarnpkg.com/@wordpress/escape-html/-/escape-html-1.8.0.tgz#07234fc8914c1edb408e194dd19c981f4dcb1117"
   integrity sha512-z7z+57nm9Dv3Hau0u3+17dJCbpWnh853VBF6JPID7rKnLPw2AOoRJtNHf4gLeBJTrG6M4cC8EG8Flarsuoxb2w==
@@ -4834,14 +4829,14 @@
     "@wordpress/url" "^2.15.0"
     lodash "^4.17.15"
 
-"@wordpress/hooks@*", "@wordpress/hooks@^2.6.0", "@wordpress/hooks@^2.7.0", "@wordpress/hooks@^2.8.0":
+"@wordpress/hooks@*", "@wordpress/hooks@^2.6.0", "@wordpress/hooks@^2.8.0":
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/@wordpress/hooks/-/hooks-2.8.0.tgz#30a7c3af68837d9a659c52a008b8f1ee1853994b"
   integrity sha512-5FbiVz6T2Frw45NmPDF9GbAFU8iQy64YSZaM+61tUngB+Uzdv0A4pA8C8WIDPlw16QJXseZ4uLce4U9HlJQ3dw==
   dependencies:
     "@babel/runtime" "^7.9.2"
 
-"@wordpress/html-entities@*", "@wordpress/html-entities@^2.5.0", "@wordpress/html-entities@^2.6.0", "@wordpress/html-entities@^2.7.0":
+"@wordpress/html-entities@*", "@wordpress/html-entities@^2.5.0", "@wordpress/html-entities@^2.7.0":
   version "2.7.0"
   resolved "https://registry.yarnpkg.com/@wordpress/html-entities/-/html-entities-2.7.0.tgz#e64d73ded93e9d86261c732ea0174724209321e3"
   integrity sha512-OmHZFHDl1Ai0LmRlqehRAt0broGigW1QCnRS1K82nurCFi9kz8x13C7GWv7wshA9TC4Qp/PLP9SEl/nzcJyIYg==
@@ -4869,15 +4864,6 @@
     "@wordpress/element" "^2.14.0"
     "@wordpress/primitives" "^1.5.0"
 
-"@wordpress/icons@^1.2.0":
-  version "1.4.0"
-  resolved "https://registry.yarnpkg.com/@wordpress/icons/-/icons-1.4.0.tgz#805732a5527eb2178bd97b53decac67451b2b1b3"
-  integrity sha512-YNW1ocZddZ6c40QHiR/Q3yIPYzh4Fdcq/J4sJIkegwqEXltVknYa90RNaDG9xr+qMvXN5/wotYaLA+AP6pUfHA==
-  dependencies:
-    "@babel/runtime" "^7.9.2"
-    "@wordpress/element" "^2.13.1"
-    "@wordpress/primitives" "^1.4.0"
-
 "@wordpress/interface@^0.3.0":
   version "0.3.0"
   resolved "https://registry.yarnpkg.com/@wordpress/interface/-/interface-0.3.0.tgz#7e1d873666827b7d2ab151ef792eaa2b4914cff9"
@@ -4900,13 +4886,6 @@
   dependencies:
     "@babel/runtime" "^7.9.2"
 
-"@wordpress/is-shallow-equal@^1.8.0":
-  version "1.8.0"
-  resolved "https://registry.yarnpkg.com/@wordpress/is-shallow-equal/-/is-shallow-equal-1.8.0.tgz#905f31599df92201e4d7601a42a45d430eb666f2"
-  integrity sha512-OV3qJqP9LhjuOzt85TsyBwv+//CvC8Byf/81D3NmjPKlstLaD/bBCC5nBhH6dKAv4bShYtQ2Hmut+V4dZnOM1A==
-  dependencies:
-    "@babel/runtime" "^7.8.3"
-
 "@wordpress/jest-console@^3.6.0":
   version "3.6.0"
   resolved "https://registry.yarnpkg.com/@wordpress/jest-console/-/jest-console-3.6.0.tgz#434d802b0b3d11f976f348d02124150189682769"
@@ -4928,7 +4907,7 @@
     enzyme-adapter-react-16 "^1.15.2"
     enzyme-to-json "^3.4.4"
 
-"@wordpress/keyboard-shortcuts@1.5.0", "@wordpress/keyboard-shortcuts@^1.2.0", "@wordpress/keyboard-shortcuts@^1.5.0":
+"@wordpress/keyboard-shortcuts@1.5.0", "@wordpress/keyboard-shortcuts@^1.5.0":
   version "1.5.0"
   resolved "https://registry.yarnpkg.com/@wordpress/keyboard-shortcuts/-/keyboard-shortcuts-1.5.0.tgz#ca90457faeb8fcee7cb540fedee692f3936b0dd9"
   integrity sha512-lhMIkdXa+Xg4Bl9T7EJRXt32E1ROOwOMUv/TZkCWyhIVejDNkJQVULbvkgVvYpyYeH7ZBQHKAw9pLrTH3A/PHw==
@@ -4950,7 +4929,7 @@
     "@wordpress/i18n" "^3.12.0"
     lodash "^4.17.15"
 
-"@wordpress/media-utils@1.11.0", "@wordpress/media-utils@^1.11.0", "@wordpress/media-utils@^1.8.0":
+"@wordpress/media-utils@1.11.0", "@wordpress/media-utils@^1.11.0":
   version "1.11.0"
   resolved "https://registry.yarnpkg.com/@wordpress/media-utils/-/media-utils-1.11.0.tgz#5d15c09da147948be9b0a1f85bbf214d54ab5b39"
   integrity sha512-DYmPgwv8ukhyOpLQPEQk34z8b6C88r+3aslg9olrjI/XBv53mDomLlFMP2l988hoofdgc/fNuIseRN+ogyzHrw==
@@ -5010,7 +4989,7 @@
   resolved "https://registry.yarnpkg.com/@wordpress/prettier-config/-/prettier-config-0.2.0.tgz#ac32ad59d3e7137369be7046fb804b2f8ba752bc"
   integrity sha512-v5H1dIDG9s2wASC8eah3hYRFuviPFNnflcAvHP7D7dOA6YPfPTCJDHeJ8CVKT+QBkNKkdueyYiR6YkxEVBj7iw==
 
-"@wordpress/primitives@1.5.0", "@wordpress/primitives@^1.2.0", "@wordpress/primitives@^1.4.0", "@wordpress/primitives@^1.5.0":
+"@wordpress/primitives@1.5.0", "@wordpress/primitives@^1.5.0":
   version "1.5.0"
   resolved "https://registry.yarnpkg.com/@wordpress/primitives/-/primitives-1.5.0.tgz#e4ef2b886ab516ca9a4a54468c8243a24aecc5b9"
   integrity sha512-SHP95z2AwRHN5egYzUdyvefdvescYTpDNHhp2klTPUNLIme3yNCdL43rihYb+cUEZCgVKEod8Y9EIE7xB9g5YQ==
@@ -5019,14 +4998,14 @@
     "@wordpress/element" "^2.14.0"
     classnames "^2.2.5"
 
-"@wordpress/priority-queue@1.6.0", "@wordpress/priority-queue@^1.5.1", "@wordpress/priority-queue@^1.6.0":
+"@wordpress/priority-queue@1.6.0", "@wordpress/priority-queue@^1.6.0":
   version "1.6.0"
   resolved "https://registry.yarnpkg.com/@wordpress/priority-queue/-/priority-queue-1.6.0.tgz#cdc5b38055273183a570ce3d8b47a5162fe34e6d"
   integrity sha512-G2fa+W48U9YRByY+870iWnUKeX7YH13bpqtLaF9HhaykYrLeo41oHsIdiydgeCG49k5A4+mXuNnAWZvEcxgsbA==
   dependencies:
     "@babel/runtime" "^7.9.2"
 
-"@wordpress/redux-routine@3.9.0", "@wordpress/redux-routine@^3.7.0", "@wordpress/redux-routine@^3.8.0", "@wordpress/redux-routine@^3.9.0":
+"@wordpress/redux-routine@3.9.0", "@wordpress/redux-routine@^3.7.0", "@wordpress/redux-routine@^3.9.0":
   version "3.9.0"
   resolved "https://registry.yarnpkg.com/@wordpress/redux-routine/-/redux-routine-3.9.0.tgz#34c569965a6d3126b731492fff0cd7b3972f0e0f"
   integrity sha512-5CWZK6+g69apZt/hIJE3aL13CPpPnpMmPwzwSfonwis70g9f2Y3SKl/F7BquOAR/MAb5bzjWPPn/ZYzJkNLCRA==
@@ -5124,7 +5103,7 @@
     lodash "^4.17.15"
     memize "^1.1.0"
 
-"@wordpress/token-list@^1.10.0", "@wordpress/token-list@^1.9.0":
+"@wordpress/token-list@^1.10.0":
   version "1.10.0"
   resolved "https://registry.yarnpkg.com/@wordpress/token-list/-/token-list-1.10.0.tgz#b4da4d2837aadf8aa66728c37bd4cb06f6ec5d03"
   integrity sha512-vw0+DU5XDqMEf0xGMhlTk9CKoKu3G7uQZWxYU7UylzuV8QG+NBQ3AhnaEEQxcoLBZcUf4O1aqjs5mD32DmBTNQ==
@@ -5152,12 +5131,12 @@
     "@wordpress/data" "^4.18.0"
     lodash "^4.17.15"
 
-"@wordpress/warning@^1.0.0", "@wordpress/warning@^1.1.0":
+"@wordpress/warning@^1.1.0":
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/@wordpress/warning/-/warning-1.1.0.tgz#b46840da4aad9bf496f682cd65b81880c494cee1"
   integrity sha512-n1GDCX2yxxhFF9PeXWq1bInvdwYkYqbeBLHPIChGrS+B57FY4vWebVfKQbOoxZ8CZD1RBIj/KOv/sihuAdHDhg==
 
-"@wordpress/wordcount@^2.7.0", "@wordpress/wordcount@^2.8.0":
+"@wordpress/wordcount@^2.8.0":
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/@wordpress/wordcount/-/wordcount-2.8.0.tgz#6b02aae25a836747f4e9b4fcb0fdcc6f12c4da83"
   integrity sha512-veM3WRmz6mijEjn0kwn2pt3CASIKUxezUCzDe60i9I8spaYAL1hQiykrXx5U3x/hehQaOw2enoqPPdtHIm1XHQ==
@@ -9669,7 +9648,7 @@ diff-sequences@^25.2.6:
   resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-25.2.6.tgz#5f467c00edd35352b7bca46d7927d60e687a76dd"
   integrity sha512-Hq8o7+6GaZeoFjtpgvRBUknSXNeJiCx7V9Fr94ZMljNiCr9n9L8H8aJqgWOQiDDGdyn29fRNcDdRVJ5fdyihfg==
 
-diff@3.5.0, diff@^3.5.0:
+diff@3.5.0:
   version "3.5.0"
   resolved "https://registry.yarnpkg.com/diff/-/diff-3.5.0.tgz#800c0dd1e0a8bfbc95835c202ad220fe317e5a12"
   integrity sha512-A46qtFgd+g7pDZinpnwiRJtxbC1hpgf0uzP3iG89scHk0AUC7A1TGxf5OiiOUv/JMZR8GOt8hL900hV0bOy5xA==
@@ -16691,11 +16670,6 @@ mem@^4.0.0:
     mimic-fn "^2.0.0"
     p-is-promise "^2.0.0"
 
-memize@^1.0.5:
-  version "1.0.5"
-  resolved "https://registry.yarnpkg.com/memize/-/memize-1.0.5.tgz#51d89e8407643dbc8cab98c6d56b889f9a3954e3"
-  integrity sha512-Dm8Jhb5kiC4+ynYsVR4QDXKt+o2dfqGuY4hE2x+XlXZkdndlT80bJxfcMv5QGp/FCy6MhG7f5ElpmKPFKOSEpg==
-
 memize@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/memize/-/memize-1.1.0.tgz#4a5a684ac6992a13b1299043f3e49b1af6a0b0d3"
@@ -21052,11 +21026,6 @@ reakit-system@^0.7.2:
   resolved "https://registry.yarnpkg.com/reakit-system/-/reakit-system-0.7.2.tgz#34e5b50f7668ef0a533fbe963a095b6374d48a5b"
   integrity sha512-IY0NwVguy2Awp0DFRzsCBtSnn5gpHtfM3pvfi6Qcwv7Wkms6ZUWxsqFpwNJTMBfXqEBo9dDuIkpCBZivtezYzA==
 
-reakit-system@^0.9.0:
-  version "0.9.0"
-  resolved "https://registry.yarnpkg.com/reakit-system/-/reakit-system-0.9.0.tgz#678fecdd688fabbd3395e74d2447750241857fad"
-  integrity sha512-uxhjpxpI3XHAj3OhkDeyyulG3hNgEJ6KtEZbwRXiCv9DOKIe0zwN8qTAXRIKXtP4pu5PyETBh3XEZoxiv4FAww==
-
 reakit-utils@^0.12.0:
   version "0.12.0"
   resolved "https://registry.yarnpkg.com/reakit-utils/-/reakit-utils-0.12.0.tgz#4335553b1bfd0c421e552bf608b5560f47c4ab1f"
@@ -21067,11 +21036,6 @@ reakit-utils@^0.7.3:
   resolved "https://registry.yarnpkg.com/reakit-utils/-/reakit-utils-0.7.3.tgz#91acb6360b30a802e5dae9bb6c9f7a9e9535ea6a"
   integrity sha512-sQsgKYcn+OthBkvKz+TeHlYZq2SF5ZP9RutHg7O67GI+sdYqf0BVy6VeTe28TG4Vui6hoMheiMnZqhidOtN7EA==
 
-reakit-utils@^0.9.0:
-  version "0.9.0"
-  resolved "https://registry.yarnpkg.com/reakit-utils/-/reakit-utils-0.9.0.tgz#e17a877702af422dc13d6fae95a7a4f4bc7788db"
-  integrity sha512-qVsGLmsFZv1+A5B/k1xEhFYD8U9fkl8ssvE3D5zIM33V0oIFvVClDTm8Iv96dpB1cod1kolLDKva6FkNxXP+bw==
-
 reakit-warning@^0.3.0:
   version "0.3.0"
   resolved "https://registry.yarnpkg.com/reakit-warning/-/reakit-warning-0.3.0.tgz#24d860fd3911bfe034584173366ab0c5e193fc20"
@@ -21089,16 +21053,6 @@ reakit@1.0.0-beta.14:
     reakit-system "^0.7.2"
     reakit-utils "^0.7.3"
 
-reakit@^1.0.0-beta.12:
-  version "1.0.0-beta.16"
-  resolved "https://registry.yarnpkg.com/reakit/-/reakit-1.0.0-beta.16.tgz#dccfcd84e1dd5bf9ce5888ec7fdda1d93b3ba131"
-  integrity sha512-zytLIb7Ai2b6Yi0/C8lSPSvl/9HI7M8ntO1ty7aoJ9XCKxhFi4Oq1rwF6ja/242cBH7uqspRfhagBhgJniOr8A==
-  dependencies:
-    "@popperjs/core" "^2.0.5"
-    body-scroll-lock "^2.6.4"
-    reakit-system "^0.9.0"
-    reakit-utils "^0.9.0"
-
 reakit@^1.0.0-rc.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/reakit/-/reakit-1.0.2.tgz#ff879f63a47b4d61051f8e991b187f14c8fc391e"
@@ -22449,7 +22403,7 @@ shellwords@^0.1.1:
   resolved "https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b"
   integrity sha512-vFwSUfQvqybiICwZY5+DAWIPLKsWO31Q91JSKl3UYv+K5c2QRPzn0qzec6QPu1Qc9eHYItiP3NdJqNVqetYAww==
 
-showdown@^1.8.6, showdown@^1.9.1:
+showdown@^1.9.1:
   version "1.9.1"
   resolved "https://registry.yarnpkg.com/showdown/-/showdown-1.9.1.tgz#134e148e75cd4623e09c21b0511977d79b5ad0ef"
   integrity sha512-9cGuS382HcvExtf5AHk7Cb4pAeQQ+h0eTr33V1mu+crYWV4KvWAw6el92bDrqGEk5d46Ai/fhbEUwqJ/mTCNEA==
@@ -23663,7 +23617,7 @@ table@^5.0.0, table@^5.2.3:
     slice-ansi "^2.1.0"
     string-width "^3.0.0"
 
-tannin@^1.1.0, tannin@^1.1.1:
+tannin@^1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/tannin/-/tannin-1.1.1.tgz#30daccac26b43200fa0a65a36391274ecfc67d6c"
   integrity sha512-e6qNtx1XZnvC3psLnvboUekSY4phq77YDnDDhE/nqghpTVz2MbrsrN0M1dysof/WfkcSvnRVZyR8NYu5KcFtQw==

@sirreal
Copy link
Member

sirreal commented May 15, 2020

yarn --frozen-lockfile does not give a dirty lock file 🙃

@scinos
Copy link
Contributor

scinos commented May 15, 2020

My bad, I forgot to run yarn after yarn-deduplicate

yarn gives a dirty lock now
yarn --frozen-lockfile does not give a dirty lock file

Really interesting. Technically the current file is "correct", as in it is enough to solve the entire dependency tree and satisfies every package.json. But it is dirty because it contains extra packages that nobody depends on. This means that we should remove --frozen-lockfile from all our CI scripts or we won't be able to detect yarn.lock being dirty.

Anyway, fixed it in my latest commit

@sirreal
Copy link
Member

sirreal commented May 15, 2020

The __experimentalUIParts were removed from BlockList in WordPress/gutenberg#20979. That's why the toolbar has reappeared.

<BlockList
__experimentalUIParts={ {
hasPopover: false,
hasSelectedUI: false,
} }

I'll push a change to remove the redundant props and hide via CSS.

Experimental UI parts api was dropped in
WordPress/gutenberg#20979

Remove usage and hide via CSS
@sirreal sirreal dismissed their stale review May 15, 2020 15:22

Addressed

Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built this locally and smoke tested around Gutenboarding and Calypso.
Everything works well as far as I can tell.

You may choose to get some more bodies testing, but from my end this looks good to go.

@sirreal sirreal requested review from a team May 15, 2020 17:17
@sirreal sirreal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2020
@roo2
Copy link
Contributor

roo2 commented May 18, 2020

also tested in gutenboarding and the editor, I will merge this.

@roo2 roo2 merged commit 7258ca3 into master May 18, 2020
@roo2 roo2 deleted the renovate/wordpress-monorepo branch May 18, 2020 05:23
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants