-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update wordpress monorepo #42031
Conversation
a07116e
to
24410a8
Compare
Cherry picked fixes (966819d) from #41994 / #41207 This should include the fix (WordPress/gutenberg#22264) that caused the first attempt to be reverted. |
This is new for me, the build is failing:
|
This PR is not just updating |
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
Looks like Renovate updated Edit: surgery done. I checked out |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~141 bytes removed 📉 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~18265 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4557 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~886 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
That's quite the bump in size, unfortunately 😞 I think we should probably look at getting #42212 merged to avoid some of the hit with this update. It won't be necessary once some changes in Gutenberg make it to a release, but that's not the case yet, so we definitely should merge the stop-gap measure. |
cabca74
to
3a3a3ed
Compare
Rebased to fix conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scinos
|
|
My bad, I forgot to run
Really interesting. Technically the current file is "correct", as in it is enough to solve the entire dependency tree and satisfies every Anyway, fixed it in my latest commit |
3a3a3ed
to
9fe1410
Compare
The wp-calypso/client/landing/gutenboarding/gutenboard.tsx Lines 98 to 102 in eb89576
I'll push a change to remove the redundant props and hide via CSS. |
Experimental UI parts api was dropped in WordPress/gutenberg#20979 Remove usage and hide via CSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built this locally and smoke tested around Gutenboarding and Calypso.
Everything works well as far as I can tell.
You may choose to get some more bodies testing, but from my end this looks good to go.
also tested in gutenboarding and the editor, I will merge this. |
This PR contains the following updates:
2.8.0
->2.9.0
3.12.0
->3.15.0
3.4.0
->3.5.0
1.5.0
->1.8.0
1.6.0
->1.9.0
3.8.0
->3.11.0
2.15.0
->2.18.0
6.13.0
->6.16.0
9.3.0
->9.6.0
3.12.0
->3.15.0
2.13.0
->2.16.0
4.15.0
->4.18.0
1.9.0
->1.12.0
2.4.0
->2.6.0
2.8.0
->2.9.0
2.8.0
->2.9.0
4.4.0
->4.7.0
3.14.0
->3.17.0
9.13.0
->9.16.0
2.12.0
->2.14.0
1.15.0
->1.18.0
3.10.0
->3.12.0
1.2.0
->2.0.0
1.8.0
->2.0.0
5.5.0
->6.0.0
1.2.0
->1.5.0
2.10.0
->2.12.0
1.8.0
->1.11.0
2.1.0
->2.4.0
2.2.0
->3.0.0
3.13.0
->3.16.0
2.13.0
->2.16.0
1.2.0
->1.5.0
1.5.1
->1.6.0
3.7.0
->3.9.0
3.13.0
->3.16.0
7.2.0
->9.1.0
1.9.0
->1.12.0
2.6.0
->2.7.0
2.12.0
->2.15.0
2.14.0
->2.17.0
Release Notes
WordPress/gutenberg
v2.9.0
Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Closes #41994
This PR has been generated by WhiteSource Renovate. View repository job log here.