SYS-3560 - Minor refactor before benchmarking #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the data structures and the voting mechanism for accepting events ranges from ethereum. Ranges that are too big will be broken down into smaller partitions, voted upon individually, and accepted as one. Follow up commit will do the validate unsigned and processing of the partitions. Jira tickets: - SYS-3635 - SYS-3930
Updates the validate unsigned function to support submit_discovered_events extrinsic. Jira tickets: - SYS-3635 - SYS-3930
This PR introduces support for processing votes upon achieving consensus. It extends extrinsics and data structures accordingly. Once the final vote is cast, the voting round for the Ethereum range partition is finalized, and the partition is processed. Additionally, this PR extends the subscription mechanism of the eth-bridge pallet. By default, pallets ignore processed events, requiring the implementation of a handler to process them. Benchmarking for certain actions will be addressed in a separate PR. Jira Tasks: - SYS-3930 - SYS-3635
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Thanos Doukoudakis <56822898+thadouk@users.noreply.github.com>
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Thanos Doukoudakis <56822898+thadouk@users.noreply.github.com>
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
Extends the runtime API for initial range consensus mechanism Jira task - SYS-3930
Adds basic unit tests that check the submit_ethereum_events interface Jira task: - SYS-3930 - SYS-3635
- General cleanup - Rename of storage items - Removal of mocks - Wire up with runtime, implementing different events filters for each runtime.
…397) This commit includes the integration of the initial range voting functionality with the client. It ports changes to integrate the runtime API for testing runtime behavior. Additionally, it refactors the runtime API to improve proof creation by relocating helper functions to primitive crates. Fixes genesis config for test runtime. Jira tasks: - SYS-3930 - SYS-3635
This commit addresses issues with extrinsic submission in the runtime: - Registers the extension to the instance submitting the extrinsic. - Updates signature validation. - Simplifies interface and error handling via the runtime API, following the report_equivocation style.
…o eth-bridge (#390) Co-authored-by: Thanos <56822898+thadouk@users.noreply.github.com> Co-authored-by: nahuseyoum <nahu.seyoum@aventus.io>
…-Network-Services/avn-parachain into nahu-sys3560-ethBridge-refactor
nahuseyoum
changed the title
ivan-cholakov
approved these changes
May 29, 2024
MBrozhko34
approved these changes
May 29, 2024
fluorostani
reviewed
May 30, 2024
| .map(|(range, votes)| (range, votes.len())) | ||
| .collect(); | ||
| sorted_votes.sort_by(|(range_a, _votes_a), (range_b, _votes_b)| range_a.cmp(range_b)); | ||
| submitted_blocks.sort(); |
fluorostani
approved these changes
May 30, 2024
thadouk
added a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Thanos <56822898+thadouk@users.noreply.github.com> Co-authored-by: Michael <62653655+MBrozhko34@users.noreply.github.com>
thadouk
added a commit
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Thanos <56822898+thadouk@users.noreply.github.com> Co-authored-by: Michael <62653655+MBrozhko34@users.noreply.github.com>
thadouk
added a commit
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Thanos <56822898+thadouk@users.noreply.github.com> Co-authored-by: Michael <62653655+MBrozhko34@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor refactor prior to running benchmarks: