fix: Convert folding recursive verifier ops to batch mul

[ledwards2225]

Updates folding recursive verifier to use batch_mul for optimal goblin ec op efficiency. This reduces a single recursive verification from 1144 ECC ops to 264. (Note: 264 = 6*44 where 6 is the number of ecc op gate rows needed for two scalar muls (one for each instance) plus an "equals" op and 44 is the number of witnesses plus precomputed polys, not including shifts)

Closes AztecProtocol/barretenberg#849

New benchmark result:

-----------------------------------------------------------------
Benchmark                       Time             CPU   Iterations
-----------------------------------------------------------------
IvcBench/Full/6             54156 ms        51691 ms            1

Old benchmark result:

-----------------------------------------------------------------
Benchmark                       Time             CPU   Iterations
-----------------------------------------------------------------
IvcBench/Full/6             66891 ms        63569 ms            1

[ludamad]

merging master to test a fix

[AztecBot]

Benchmark results

Metrics with a significant change:

• batch_insert_into_append_only_tree_32_depth_ms (512): 240 (-20%)
• note_history_trial_decrypting_time_in_ms (5): 164 (+89%)
• note_trial_decrypting_time_in_ms (32): 121 (+175%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit bf4fc6c7 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,868	871,372	3,466,060
l1_rollup_execution_gas	316,059	989,820	3,686,438
l2_block_processing_time_in_ms	1,161 (-5%)	4,371 (-1%)	17,311 (-1%)
note_successful_decrypting_time_in_ms	319	993 (-3%)	3,767 (-2%)
note_trial_decrypting_time_in_ms	31.3 (+16%)	⚠️ 121 (+175%)	155 (+1%)
l2_block_building_time_in_ms	17,847	70,239 (-1%)	282,358
l2_block_rollup_simulation_time_in_ms	13,127	51,583	207,961
l2_block_public_tx_process_time_in_ms	4,692	18,574 (-1%)	74,136

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,785 (-1%)	26,614 (-3%)
note_history_successful_decrypting_time_in_ms	2,622 (+6%)	4,839 (+3%)
note_history_trial_decrypting_time_in_ms	⚠️ 164 (+89%)	231 (+38%)
node_database_size_in_bytes	17,281,104	33,022,032
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	307	44,528	25,825
private-kernel-ordering	194	44,145	16,225
base-rollup	1,405	128,654	933
root-rollup	82.6	4,192	729
private-kernel-inner	437	71,331	25,825
public-kernel-private-input	241	32,287	25,825
public-kernel-non-first-iteration	237	32,329	25,825
merge-rollup	7.91	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.1 (-2%)	12.8 (-7%)	17.0 (-4%)	22.7 (-12%)	64.0 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.620 (-1%)	0.543 (-6%)	0.524 (-4%)	0.477 (-11%)	0.441 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.6 (-2%)	47.7	⚠️ 240 (-20%)	463 (-1%)	900 (-2%)	3,558
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.461 (-2%)	0.489	0.438 (-19%)	0.432 (-1%)	0.428 (-1%)	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (-1%)	56.9	352 (+1%)	693	1,379	5,438 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.495 (-1%)	0.498	0.476	0.475	0.478 (+1%)	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.580	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	40,167

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	553 (-3%)	1,308

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.521 (-6%)	577