refactor: proper portal setup for fees + test

[LHerskind]

Fixes #7692.

Gets rid of assets directly in the rollup contract. The rollup contract will instead make a call to the portal to get it to pay some funds to the sequencer, currently named distributeFees.

Calling initialize on the fee juice portal require that it have been funded to ensure that the deployment of the l2 fee assets does not lead to an undercollateralized case.

[LHerskind]

• refactor: proper portal setup for fees + test #7944 👈
• refactor: simplify registry #7939
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[Maddiaa0]

we gotta do something other than payTheMan immediately or itll stick lmao

[AztecBot]

Benchmark results

Metrics with a significant change:

• app_circuit_witness_generation_time_in_ms (SchnorrAccount:verify_private_authwit): 27.5 (-30%)
• avm_simulation_time_ms (Token:mint_public): 71.9 (+63%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 40.4 (-43%)
• avm_simulation_time_ms (Token:transfer_public): 27.8 (+35%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,781	1,561	704 (-4%)	759 (-6%)	773 (-3%)
proof_construction_time_sha256_30_ms	11,850 (-1%)	3,177 (-1%)	1,411 (-3%)	1,451 (-1%)	1,464 (-7%)
proof_construction_time_sha256_100_ms	45,461 (-1%)	12,200 (+1%)	5,427 (-4%)	5,395 (-4%)	5,366 (-4%)
proof_construction_time_poseidon_hash_ms	79.0	34.0 (-3%)	35.0	58.0 (-5%)	87.0 (-3%)
proof_construction_time_poseidon_hash_30_ms	1,539	422	203 (-2%)	232	270 (-4%)
proof_construction_time_poseidon_hash_100_ms	5,668	1,516 (-1%)	680 (-2%)	723 (-4%)	752 (-2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,732	92,486	177,512
l1_rollup_execution_gas	1,383,226	2,130,948	3,958,013
l2_block_processing_time_in_ms	255 (-2%)	447 (+1%)	791 (-1%)
l2_block_building_time_in_ms	9,296 (+1%)	18,120	35,878
l2_block_rollup_simulation_time_in_ms	9,295 (+1%)	18,120	35,878
l2_block_public_tx_process_time_in_ms	7,814	16,577	34,313

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,928 (+2%)	3,831
node_database_size_in_bytes	12,660,816	16,760,912
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	91.3 (-4%)	417 (+3%)	21,673	44,858	N/A
private-kernel-inner	164 (+1%)	724 (-4%)	72,309	45,005	N/A
private-kernel-reset-tiny	500	912 (+1%)	65,974	44,844	N/A
private-kernel-tail	207	172 (+2%)	50,728	52,256	N/A
base-parity	5.56 (-1%)	N/A	160	96.0	N/A
root-parity	33.2 (-1%)	N/A	69,084	96.0	N/A
base-rollup	2,848	N/A	187,817	664	N/A
root-rollup	38.7 (-2%)	N/A	54,525	716	N/A
public-kernel-setup	98.0 (-1%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	103	N/A	103,599	71,222	N/A
public-kernel-tail	577	N/A	409,190	16,414	N/A
private-kernel-reset-small	504 (+2%)	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,024 (-3%)	664	492,960	1,697	N/A
public-kernel-teardown	92.7	N/A	104,005	71,222	N/A
merge-rollup	19.0	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	64,784

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341
ContractInstanceDeployer:deploy	1,408	11,731	18.2
MultiCallEntrypoint:entrypoint	1,920	11,731	421
FeeJuice:deploy	1,376	11,731	395 (+1%)
SchnorrAccount:constructor	1,312	11,731	105
SchnorrAccount:entrypoint	2,304	11,731	431
Token:privately_mint_private_note	1,280	11,731	143
FPC:fee_entrypoint_public	1,344	11,731	27.2 (+3%)
Token:transfer	1,312	11,731	272 (-1%)
Benchmarking:create_note	1,344	11,731	103 (+3%)
SchnorrAccount:verify_private_authwit	1,280	11,731	⚠️ 27.5 (-30%)
Token:unshield	1,376	11,731	556 (-2%)
FPC:fee_entrypoint_private	1,376	11,731	790 (+3%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	52.9 (-2%)	8,139
FeeJuice:set_portal	10.6 (-5%)	2,362
Token:constructor	80.4 (-4%)	31,107
FPC:constructor	54.3 (+1%)	22,380
FeeJuice:mint_public	37.9 (-2%)	6,150
Token:mint_public	⚠️ 71.9 (+63%)	11,720
Token:assert_minter_and_mint	⚠️ 40.4 (-43%)	8,028
AuthRegistry:set_authorized	45.0 (+20%)	4,537
FPC:prepare_fee	242	8,812
Token:transfer_public	⚠️ 27.8 (+35%)	47,358
FPC:pay_refund	60.1 (-13%)	12,082
Benchmarking:increment_balance	968	7,450
Token:_increase_public_balance	39.6	8,960
FPC:pay_refund_with_shielded_rebate	65.6 (-3%)	12,631

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.156 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18 (-1%)	3.89	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-1%)	0.110	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.7 (+1%)	17.5 (-3%)	31.1 (-2%)	59.2	110 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.112 (+1%)	0.101 (-3%)	0.101 (-1%)	0.102	0.0997
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4 (-1%)	25.7	43.5 (-1%)	82.9	159 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110	0.103	0.102 (-1%)	0.103 (+1%)	0.102 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.4	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[Maddiaa0]

nice

[Maddiaa0]

lgtm, nits