feat: various token note improvements

[benesjan]

Fixes #7772
+ removes incorrect slot checks

The non-zero slot check in TokenNote was incorrect because with partial notes it's totally legitimate to compute the note hiding point without the slot and then adding it later.

[benesjan]

• feat: various token note improvements #8062 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[benesjan]

Tackling this issue by using from_field_unsafe is fine because from_field_unsafe tries does the decomposing in an unconstrained context and hence does not add to gate counts much.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 72.4 (+61%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 40.0 (-42%)
• avm_simulation_time_ms (Token:_increase_public_balance): 74.4 (+88%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,785	1,562	712 (-1%)	741 (-4%)	785 (-1%)
proof_construction_time_sha256_30_ms	11,920	3,189 (-1%)	1,427 (-1%)	1,450 (-2%)	1,471 (-1%)
proof_construction_time_sha256_100_ms	45,856	12,092 (-1%)	5,502	5,466 (-1%)	5,439
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0 (-3%)	35.0 (+3%)	58.0	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,541	425	205	224 (-5%)	266 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,668 (-1%)	1,522	680	736 (+1%)	758

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,672	92,474	177,308
l1_rollup_execution_gas	1,383,166	2,130,936	3,957,809
l2_block_processing_time_in_ms	258 (-2%)	451	809
l2_block_building_time_in_ms	9,240	18,160	36,036
l2_block_rollup_simulation_time_in_ms	9,240	18,160	36,036
l2_block_public_tx_process_time_in_ms	7,807	16,613	34,457

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,922 (-2%)	3,823 (-1%)
node_database_size_in_bytes	12,640,336	16,748,624
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	95.2 (+5%)	400	21,673	44,858	N/A
private-kernel-inner	163 (-2%)	714	72,309	45,005	N/A
private-kernel-reset-tiny	499	941 (+4%)	65,974	44,844	N/A
private-kernel-tail	208	168 (+1%)	50,728	52,256	N/A
base-parity	5.58 (-1%)	N/A	160	96.0	N/A
root-parity	33.3	N/A	69,084	96.0	N/A
base-rollup	2,850	N/A	187,817	664	N/A
root-rollup	38.9	N/A	54,525	716	N/A
public-kernel-setup	97.6 (-1%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	103 (-1%)	N/A	103,599	71,222	N/A
public-kernel-tail	577	N/A	409,190	16,414	N/A
private-kernel-reset-small	494	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,063 (+4%)	664 (+1%)	492,960	1,697	N/A
public-kernel-teardown	92.2 (-1%)	N/A	104,005	71,222	N/A
merge-rollup	19.1	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	65,368 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.2
MultiCallEntrypoint:entrypoint	1,920	11,731	422 (-1%)
FeeJuice:deploy	1,376	11,731	389 (-1%)
SchnorrAccount:constructor	1,312	11,731	105
SchnorrAccount:entrypoint	2,304	11,731	431
Token:privately_mint_private_note	1,280	11,731	142 (+2%)
FPC:fee_entrypoint_public	1,344	11,731	27.3 (+1%)
Token:transfer	1,312	11,731	278 (+3%)
Benchmarking:create_note	1,344	11,731	101 (+1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4 (-1%)
Token:unshield	1,376	11,731	550 (-2%)
FPC:fee_entrypoint_private	1,376	11,731	756 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	54.3 (-6%)	8,139
FeeJuice:set_portal	10.8	2,362
Token:constructor	89.7 (+11%)	31,107
FPC:constructor	54.6 (+3%)	22,380
FeeJuice:mint_public	38.6 (+1%)	6,150
Token:mint_public	⚠️ 72.4 (+61%)	11,720
Token:assert_minter_and_mint	⚠️ 40.0 (-42%)	8,028
AuthRegistry:set_authorized	36.0 (-13%)	4,537
FPC:prepare_fee	241 (-3%)	8,812
Token:transfer_public	22.2 (-22%)	47,358
FPC:pay_refund	56.0 (-5%)	12,082
Benchmarking:increment_balance	967 (-1%)	7,450
Token:_increase_public_balance	⚠️ 74.4 (+88%)	8,960
FPC:pay_refund_with_shielded_rebate	68.8 (+4%)	12,631

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.25 (+2%)	3.95	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.118 (+3%)	0.112	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.6	18.0 (-2%)	31.1 (-2%)	60.2 (-2%)	115 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.112	0.105 (-2%)	0.101 (-2%)	0.104 (-1%)	0.102 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (-2%)	25.8 (-1%)	43.8 (-1%)	83.7 (-1%)	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (-2%)	0.104 (-1%)	0.103 (-4%)	0.103 (-1%)	0.102
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |