fix: flaky e2e_prover_node test

[alexghr]

Fix for the flakiness in e2e_prover_node caused by halting the default prover node while it was building a proof.

Later edit: alternatively we could refactor the test to start proving from the first unproven block instead of from the block the first tx landed in.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,763	1,565	708 (-1%)	758	771 (-2%)
proof_construction_time_sha256_30_ms	11,467 (-1%)	3,080 (-2%)	1,379 (-2%)	1,428 (-2%)	1,454 (-1%)
proof_construction_time_sha256_100_ms	44,147	11,797 (-2%)	5,408 (-3%)	5,387 (-6%)	5,704 (-4%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (+2%)	87.0
proof_construction_time_poseidon_hash_30_ms	1,528	420 (-1%)	202	229	267 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,647	1,510 (-1%)	673	736	743 (-2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,636	92,464	177,656
l1_rollup_execution_gas	1,373,664	2,107,388	3,892,636
l2_block_processing_time_in_ms	256 (+4%)	436	822 (+3%)
l2_block_building_time_in_ms	8,903 (-1%)	17,432 (-1%)	34,706
l2_block_rollup_simulation_time_in_ms	8,903 (-1%)	17,432 (-1%)	34,705
l2_block_public_tx_process_time_in_ms	7,528	15,921 (-1%)	33,173

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,855 (-2%)	3,772
node_database_size_in_bytes	12,632,144	16,769,104
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	88.9 (+1%)	401 (-1%)	21,755	44,860	N/A
private-kernel-inner	167	713 (+1%)	72,566	45,007	N/A
private-kernel-reset-tiny	460	882 (+2%)	65,675	44,846	N/A
private-kernel-tail	195	159 (+2%)	50,686	52,257	N/A
base-parity	5.63	N/A	160	96.0	N/A
root-parity	35.4	N/A	73,948	96.0	N/A
base-rollup	2,750	N/A	189,136	664	N/A
root-rollup	40.2	N/A	58,173	716	N/A
public-kernel-setup	84.1 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	94.6 (-1%)	N/A	104,911	71,222	N/A
public-kernel-tail	554	N/A	410,534	16,414	N/A
private-kernel-reset-small	463 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	1,399 (+3%)	657 (+2%)	460,796	1,825	N/A
public-kernel-teardown	82.6	N/A	105,349	71,222	N/A
merge-rollup	19.9	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	79,570

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.3
MultiCallEntrypoint:entrypoint	1,920	11,731	404
FeeJuice:deploy	1,376	11,731	390 (-2%)
SchnorrAccount:constructor	1,312	11,731	75.4
SchnorrAccount:entrypoint	2,304	11,731	415 (+1%)
Token:privately_mint_private_note	1,280	11,731	106 (-1%)
FPC:fee_entrypoint_public	1,344	11,731	29.3 (+4%)
Token:transfer	1,312	11,731	238 (+2%)
Benchmarking:create_note	1,344	11,731	89.2 (+3%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.8 (+1%)
Token:unshield	1,376	11,731	526
FPC:fee_entrypoint_private	1,376	11,731	701

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	56.2 (-1%)	7,739
FeeJuice:set_portal	11.9 (-3%)	2,354
Token:constructor	82.9	26,051
FPC:constructor	53.2	18,001
FeeJuice:mint_public	39.3 (-1%)	5,877
Token:mint_public	44.9 (-3%)	10,917
Token:assert_minter_and_mint	66.3	7,512
AuthRegistry:set_authorized	46.7 (+1%)	4,391
FPC:prepare_fee	230 (-2%)	7,043
Token:transfer_public	20.0 (+5%)	39,426
FPC:pay_refund	57.4 (+3%)	10,234
Benchmarking:increment_balance	928 (-1%)	6,563
Token:_increase_public_balance	40.6 (-12%)	8,433
FPC:pay_refund_with_shielded_rebate	61.0 (-9%)	10,783

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.165 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (-2%)	3.89 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-2%)	0.110 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.7 (+1%)	17.6 (+1%)	31.3 (+2%)	58.2 (-1%)	113 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.112 (+1%)	0.102 (+1%)	0.102 (+2%)	0.101	0.102 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (-2%)	25.6 (+1%)	43.5 (+1%)	81.4 (-1%)	163 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111 (-2%)	0.103 (+1%)	0.105 (+1%)	0.101	0.104 (+3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.4	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[spalladino]

Thanks for looking into this Alex!

[PhilWindle]

Nice one!