chore: Rename files relating to what were "instances" #8383

codygunton · 2024-09-05T07:50:29Z

Follow-up to #8362 where I rename files according to the new class names therein. Instances had been with sumcheck, but they don't really belong there, so I move them to ultra_honk. I also rename the recursive versions of things and the instance inspector in place.

codygunton · 2024-09-05T07:52:28Z

barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.hpp

@@ -178,15 +177,6 @@ template <typename Flavor> class SumcheckProver {
        , round(multivariate_n)
        , partially_evaluated_polynomials(multivariate_n){};

-    /**


This proxy function is the only reason why the instances classes had to be in the sumcheck module. They properly belong with the decider prover and verifier, so I just removed this function and called prove in a few places by passing in the required data.

AztecBot · 2024-09-05T08:28:05Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,469 (+86%)
avm_simulation_time_ms (FeeJuice:_increase_public_balance): 47.8 (-71%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 360 (+488%)
avm_simulation_time_ms (Token:transfer_public): 26.8 (+105%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,779	1,554	698	772 (+3%)	774
proof_construction_time_sha256_30_ms	11,523	3,073	1,364 (-1%)	1,414	1,461 (-1%)
proof_construction_time_sha256_100_ms	45,429	11,786	5,406 (-1%)	6,026 (+2%)	5,346 (-1%)
proof_construction_time_poseidon_hash_ms	79.0	34.0	34.0	58.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,534	418	200	219 (-4%)	270 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,662	1,503	669	709 (-2%)	748

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,836	177,976
l1_rollup_execution_gas	843,061	1,576,573	3,361,769
l2_block_processing_time_in_ms	243 (-5%)	448	809 (+1%)
l2_block_building_time_in_ms	11,576	22,870	45,066 (-1%)
l2_block_rollup_simulation_time_in_ms	11,576	22,870	45,066 (-1%)
l2_block_public_tx_process_time_in_ms	9,879	21,154	43,336 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,386 (-2%)	4,427 (+1%)
node_database_size_in_bytes	14,242,032	18,211,056
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	75.2 (+6%)	375 (-1%)	21,099	44,933	N/A
private-kernel-inner	141 (+2%)	670 (-3%)	71,847	45,067	N/A
private-kernel-reset-tiny	290 (-2%)	665	64,687	44,922	N/A
private-kernel-tail	150 (-1%)	126 (-2%)	50,553	56,996	N/A
base-parity	5.51 (-1%)	N/A	160	96.0	N/A
root-parity	35.6 (+1%)	N/A	73,948	96.0	N/A
base-rollup	2,615	N/A	189,124	664	N/A
block-root-rollup	41.3	N/A	58,205	2,448	N/A
public-kernel-setup	84.4 (+2%)	N/A	114,173	79,414	N/A
public-kernel-app-logic	96.3	N/A	113,991	79,414	N/A
public-kernel-tail	854	N/A	497,078	16,414	N/A
private-kernel-reset-small	272 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,469 (+86%)	585 (-1%)	448,133	1,825	N/A
public-kernel-teardown	82.2 (-1%)	N/A	114,437	79,414	N/A
merge-rollup	20.1 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,767 (+2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	339 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	417
FeeJuice:deploy	1,376	11,731	394 (+1%)
SchnorrAccount:constructor	1,312	11,731	59.4 (-1%)
SchnorrAccount:entrypoint	2,336	11,731	367
FeeJuice:claim	1,344	11,731	38.4 (+11%)
Token:privately_mint_private_note	1,280	11,731	65.1 (-2%)
FPC:fee_entrypoint_public	1,344	11,731	24.2 (-10%)
Token:transfer	1,312	11,731	207
Benchmarking:create_note	1,344	11,731	73.4 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.3
Token:unshield	1,376	11,731	485 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	640

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 47.8 (-71%)	2,261
FeeJuice:set_portal	13.1 (+26%)	2,588
Token:constructor	72.5 (-2%)	12,938
FPC:constructor	48.2 (+9%)	7,744
FeeJuice:check_balance	36.6	1,980
Token:mint_public	315 (-1%)	4,419
Token:assert_minter_and_mint	⚠️ 360 (+488%)	2,899
AuthRegistry:set_authorized	45.5 (+27%)	923
FPC:prepare_fee	72.6 (+14%)	3,925
Token:transfer_public	⚠️ 26.8 (+105%)	8,887
FPC:pay_refund	42.2 (+7%)	4,851
Benchmarking:increment_balance	1,248	3,124
Token:_increase_public_balance	46.7 (+20%)	2,238
FPC:pay_refund_with_shielded_rebate	51.4 (+5%)	4,851

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.170 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.25 (+5%)	3.94 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.116 (+4%)	0.110 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (-2%)	18.9 (+7%)	31.0 (-3%)	63.5 (+5%)	114 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107 (-2%)	0.110 (+6%)	0.101 (-3%)	0.109 (+5%)	0.101 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.7 (+2%)	26.2 (+1%)	44.2	84.7	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.112 (+1%)	0.106 (+2%)	0.106 (+3%)	0.104	0.102
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.1	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,168	668,252

Transaction size based on fee payment method

| Metric | |
| - | |

The main objective of this PR is to do some renaming to stop using the term "instance" as we currently do in the Honk flavors that can be used to construct proofs from stdlib circuits (Mega, UItra, relative). This is bad terminology for several reasons: - the term "instace-witness pair" is widely in use in ZK, and our existing use of "instance" directly clashes with this. - `ProverInstance` is really just a key for Decider proving; similarly for `VerifierInstance` - `ProvingKey` as it currently exists is de facto deprecated in the contexts where we use "instance"'s since we have have rewritten those provers and verifiers using Oink prover and verifier. - "Prover instance" sounds a lot like an instance of the Prover class--can be confusing in conversation. - I take it as a sign that "instance" is a bad term that we variously use that term and the term "accumulator" for the same thing, depending on the context, whether or not any accumulation is or could even happen. I simply rename things to Decider[Proving/Verification]Key and variants of this depending on context. A sign that this is a good choice is the fact that we now have the absurd-looking `proving_key->proving_key`, which will become non-absurb when the inner proving key type is actually deprecated. At that point the DeciderProvingKey class could move into the flavor, time permitting. I also have a small change to remove the `State` struct I recently added to Protogalaxy Prover. This is where the work started before I undertook the big renaming job, and it's small and localized enough that it feels unnecessary to split it out. Note: renaming of files is done in a follow-on #8383

The main objective of this PR is to do some renaming to stop using the term "instance" as we currently do in the Honk flavors that can be used to construct proofs from stdlib circuits (Mega, UItra, relative). This is bad terminology for several reasons: - the term "instace-witness pair" is widely in use in ZK, and our existing use of "instance" directly clashes with this. - `ProverInstance` is really just a key for Decider proving; similarly for `VerifierInstance` - `ProvingKey` as it currently exists is de facto deprecated in the contexts where we use "instance"'s since we have have rewritten those provers and verifiers using Oink prover and verifier. - "Prover instance" sounds a lot like an instance of the Prover class--can be confusing in conversation. - I take it as a sign that "instance" is a bad term that we variously use that term and the term "accumulator" for the same thing, depending on the context, whether or not any accumulation is or could even happen. I simply rename things to Decider[Proving/Verification]Key and variants of this depending on context. A sign that this is a good choice is the fact that we now have the absurd-looking `proving_key->proving_key`, which will become non-absurb when the inner proving key type is actually deprecated. At that point the DeciderProvingKey class could move into the flavor, time permitting. I also have a small change to remove the `State` struct I recently added to Protogalaxy Prover. This is where the work started before I undertook the big renaming job, and it's small and localized enough that it feels unnecessary to split it out. Note: renaming of files is done in a follow-on AztecProtocol/aztec-packages#8383

* master: (49 commits) fix(avm): full proving kernel fix (#8468) fix: guesstimate gas for propose (#8445) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat(avm)!: make JUMP(I) 16-bit (#8443) feat(avm)!: variants for SET opcode (#8441) feat(avm)!: variants for MOV opcode (#8440) installer terraform has cloudfront for https support. remove http support once new aztec-up released. fix(docs): Some docs updates (#8412) feat: archiver fork block num (#8425) feat(avm-transpiler): optionally count opcode types (#8439) chore(ci): rerun ci when ready for review + don't allow draft merge (#8456) feat(avm): DSL integration of AVM recursive verifier (#8405) chore: Rename files relating to what were "instances" (#8383) fix: fmt (#8454) fix: add re-exports back (#8453) fix(bb): mac release (#8450) chore(docs): update box readme, remove duplicated features, added box install to the docs (#8254) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.54.0</summary> ## [0.54.0](aztec-package-v0.53.0...aztec-package-v0.54.0) (2024-09-10) ### Features * Archiver fork block num ([#8425](#8425)) ([a9f2364](a9f2364)) ### Miscellaneous * Merge devnet to master ([#8472](#8472)) ([26706e9](26706e9)) </details> <details><summary>barretenberg.js: 0.54.0</summary> ## [0.54.0](barretenberg.js-v0.53.0...barretenberg.js-v0.54.0) (2024-09-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.54.0</summary> ## [0.54.0](aztec-packages-v0.53.0...aztec-packages-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](#8443)) * **avm:** variants for SET opcode ([#8441](#8441)) * **avm:** variants for MOV opcode ([#8440](#8440)) ### Features * (bb) 128-bit challenges ([#8406](#8406)) ([d5b2397](d5b2397)) * `Module::add_item` (noir-lang/noir#5947) ([8ac81b1](8ac81b1)) * Add `Expr::as_let` (noir-lang/noir#5964) ([8ac81b1](8ac81b1)) * Add `FunctionDefinition::module` and `StructDefinition::module` (noir-lang/noir#5956) ([8ac81b1](8ac81b1)) * Add `FunctionDefinition` methods `is_unconstrained` and `set_unconstrained` (noir-lang/noir#5962) ([8ac81b1](8ac81b1)) * Add `StructDefinition::add_generic` (noir-lang/noir#5961) ([8ac81b1](8ac81b1)) * Add `StructDefinition::name` (noir-lang/noir#5960) ([8ac81b1](8ac81b1)) * Add a `panic` method to the stdlib (noir-lang/noir#5966) ([8ac81b1](8ac81b1)) * Archiver fork block num ([#8425](#8425)) ([a9f2364](a9f2364)) * Arithmetic Generics (noir-lang/noir#5950) ([8ac81b1](8ac81b1)) * **avm-transpiler:** Optionally count opcode types ([#8439](#8439)) ([21c06b5](21c06b5)) * **avm/public:** User space PublicContext::get_args_hash ([#8292](#8292)) ([56ce16a](56ce16a)) * **avm:** DSL integration of AVM recursive verifier ([#8405](#8405)) ([467120e](467120e)), closes [#8285](#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](#8443)) ([5bb38b1](5bb38b1)) * **avm:** Variants for binary operations ([#8473](#8473)) ([8de1f2a](8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](#8440)) ([5b27fbc](5b27fbc)) * **avm:** Variants for SET opcode ([#8441](#8441)) ([dc43306](dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](#7990)) ([372f23c](372f23c)) * Let `nargo` and LSP work well in the stdlib (noir-lang/noir#5969) ([8ac81b1](8ac81b1)) * LSP autocompletion for attributes (noir-lang/noir#5963) ([8ac81b1](8ac81b1)) * LSP now suggests self fields and methods (noir-lang/noir#5955) ([8ac81b1](8ac81b1)) * Show doc comments in LSP (noir-lang/noir#5968) ([8ac81b1](8ac81b1)) ### Bug Fixes * Add re-exports back ([#8453](#8453)) ([b6cab90](b6cab90)) * **avm:** Full proving kernel fix ([#8468](#8468)) ([684d962](684d962)) * **bb:** Mac release ([#8450](#8450)) ([1b3f914](1b3f914)) * **docs:** Some docs updates ([#8412](#8412)) ([ad73f30](ad73f30)) * Error when `quote` is used in runtime code (noir-lang/noir#5978) ([8ac81b1](8ac81b1)) * Error when comptime functions are used in runtime code (noir-lang/noir#5976) ([8ac81b1](8ac81b1)) * Fmt ([#8454](#8454)) ([34b4a8a](34b4a8a)) * Guesstimate gas for propose ([#8445](#8445)) ([bff0338](bff0338)) * Let `derive(Eq)` work for empty structs (noir-lang/noir#5965) ([8ac81b1](8ac81b1)) * LSP document symbol didn't work for primitive impls (noir-lang/noir#5970) ([8ac81b1](8ac81b1)) * **mem2reg:** Handle aliases better when setting a known value for a load (noir-lang/noir#5959) ([8ac81b1](8ac81b1)) * **mem2reg:** Handle aliases in function last store cleanup and additional alias unit test (noir-lang/noir#5967) ([8ac81b1](8ac81b1)) * Public data reads and writes verification ([#8296](#8296)) ([ae86347](ae86347)) * Restrict keccak256_injective test input to 8 bits (noir-lang/noir#5977) ([8ac81b1](8ac81b1)) * Suggest trait attributes in LSP (noir-lang/noir#5972) ([8ac81b1](8ac81b1)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](#8475)) ([ac88f30](ac88f30)) * **ci:** Rerun ci when ready for review + don't allow draft merge ([#8456](#8456)) ([ede16d3](ede16d3)) * **docs:** Update box readme, remove duplicated features, added box install to the docs ([#8254](#8254)) ([b747ac1](b747ac1)) * Document BoundedVec (noir-lang/noir#5974) ([8ac81b1](8ac81b1)) * Document HashMap (noir-lang/noir#5984) ([8ac81b1](8ac81b1)) * Merge devnet to master ([#8472](#8472)) ([26706e9](26706e9)) * Remove 3 unused functions warnings in the stdlib (noir-lang/noir#5973) ([8ac81b1](8ac81b1)) * Remove warnings from protocol circuits ([#8420](#8420)) ([c4dbcab](c4dbcab)) * Rename files relating to what were "instances" ([#8383](#8383)) ([a934e85](a934e85)) * Replace relative paths to noir-protocol-circuits ([1c43bae](1c43bae)) </details> <details><summary>barretenberg: 0.54.0</summary> ## [0.54.0](barretenberg-v0.53.0...barretenberg-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](#8443)) * **avm:** variants for SET opcode ([#8441](#8441)) * **avm:** variants for MOV opcode ([#8440](#8440)) ### Features * (bb) 128-bit challenges ([#8406](#8406)) ([d5b2397](d5b2397)) * **avm:** DSL integration of AVM recursive verifier ([#8405](#8405)) ([467120e](467120e)), closes [#8285](#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](#8443)) ([5bb38b1](5bb38b1)) * **avm:** Variants for binary operations ([#8473](#8473)) ([8de1f2a](8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](#8440)) ([5b27fbc](5b27fbc)) * **avm:** Variants for SET opcode ([#8441](#8441)) ([dc43306](dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](#7990)) ([372f23c](372f23c)) ### Bug Fixes * **avm:** Full proving kernel fix ([#8468](#8468)) ([684d962](684d962)) * **bb:** Mac release ([#8450](#8450)) ([1b3f914](1b3f914)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](#8475)) ([ac88f30](ac88f30)) * Rename files relating to what were "instances" ([#8383](#8383)) ([a934e85](a934e85)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@aztec-package-v0.53.0...aztec-package-v0.54.0) (2024-09-10) ### Features * Archiver fork block num ([#8425](AztecProtocol/aztec-packages#8425)) ([a9f2364](AztecProtocol/aztec-packages@a9f2364)) ### Miscellaneous * Merge devnet to master ([#8472](AztecProtocol/aztec-packages#8472)) ([26706e9](AztecProtocol/aztec-packages@26706e9)) </details> <details><summary>barretenberg.js: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@barretenberg.js-v0.53.0...barretenberg.js-v0.54.0) (2024-09-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@aztec-packages-v0.53.0...aztec-packages-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) * **avm:** variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) * **avm:** variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ### Features * (bb) 128-bit challenges ([#8406](AztecProtocol/aztec-packages#8406)) ([d5b2397](AztecProtocol/aztec-packages@d5b2397)) * `Module::add_item` (noir-lang/noir#5947) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `Expr::as_let` (noir-lang/noir#5964) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `FunctionDefinition::module` and `StructDefinition::module` (noir-lang/noir#5956) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `FunctionDefinition` methods `is_unconstrained` and `set_unconstrained` (noir-lang/noir#5962) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `StructDefinition::add_generic` (noir-lang/noir#5961) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `StructDefinition::name` (noir-lang/noir#5960) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add a `panic` method to the stdlib (noir-lang/noir#5966) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Archiver fork block num ([#8425](AztecProtocol/aztec-packages#8425)) ([a9f2364](AztecProtocol/aztec-packages@a9f2364)) * Arithmetic Generics (noir-lang/noir#5950) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **avm-transpiler:** Optionally count opcode types ([#8439](AztecProtocol/aztec-packages#8439)) ([21c06b5](AztecProtocol/aztec-packages@21c06b5)) * **avm/public:** User space PublicContext::get_args_hash ([#8292](AztecProtocol/aztec-packages#8292)) ([56ce16a](AztecProtocol/aztec-packages@56ce16a)) * **avm:** DSL integration of AVM recursive verifier ([#8405](AztecProtocol/aztec-packages#8405)) ([467120e](AztecProtocol/aztec-packages@467120e)), closes [#8285](AztecProtocol/aztec-packages#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) ([5bb38b1](AztecProtocol/aztec-packages@5bb38b1)) * **avm:** Variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) ([8de1f2a](AztecProtocol/aztec-packages@8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ([5b27fbc](AztecProtocol/aztec-packages@5b27fbc)) * **avm:** Variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) ([dc43306](AztecProtocol/aztec-packages@dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](AztecProtocol/aztec-packages#7990)) ([372f23c](AztecProtocol/aztec-packages@372f23c)) * Let `nargo` and LSP work well in the stdlib (noir-lang/noir#5969) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP autocompletion for attributes (noir-lang/noir#5963) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP now suggests self fields and methods (noir-lang/noir#5955) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Show doc comments in LSP (noir-lang/noir#5968) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) ### Bug Fixes * Add re-exports back ([#8453](AztecProtocol/aztec-packages#8453)) ([b6cab90](AztecProtocol/aztec-packages@b6cab90)) * **avm:** Full proving kernel fix ([#8468](AztecProtocol/aztec-packages#8468)) ([684d962](AztecProtocol/aztec-packages@684d962)) * **bb:** Mac release ([#8450](AztecProtocol/aztec-packages#8450)) ([1b3f914](AztecProtocol/aztec-packages@1b3f914)) * **docs:** Some docs updates ([#8412](AztecProtocol/aztec-packages#8412)) ([ad73f30](AztecProtocol/aztec-packages@ad73f30)) * Error when `quote` is used in runtime code (noir-lang/noir#5978) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Error when comptime functions are used in runtime code (noir-lang/noir#5976) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Fmt ([#8454](AztecProtocol/aztec-packages#8454)) ([34b4a8a](AztecProtocol/aztec-packages@34b4a8a)) * Guesstimate gas for propose ([#8445](AztecProtocol/aztec-packages#8445)) ([bff0338](AztecProtocol/aztec-packages@bff0338)) * Let `derive(Eq)` work for empty structs (noir-lang/noir#5965) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP document symbol didn't work for primitive impls (noir-lang/noir#5970) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **mem2reg:** Handle aliases better when setting a known value for a load (noir-lang/noir#5959) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **mem2reg:** Handle aliases in function last store cleanup and additional alias unit test (noir-lang/noir#5967) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Public data reads and writes verification ([#8296](AztecProtocol/aztec-packages#8296)) ([ae86347](AztecProtocol/aztec-packages@ae86347)) * Restrict keccak256_injective test input to 8 bits (noir-lang/noir#5977) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Suggest trait attributes in LSP (noir-lang/noir#5972) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](AztecProtocol/aztec-packages#8475)) ([ac88f30](AztecProtocol/aztec-packages@ac88f30)) * **ci:** Rerun ci when ready for review + don't allow draft merge ([#8456](AztecProtocol/aztec-packages#8456)) ([ede16d3](AztecProtocol/aztec-packages@ede16d3)) * **docs:** Update box readme, remove duplicated features, added box install to the docs ([#8254](AztecProtocol/aztec-packages#8254)) ([b747ac1](AztecProtocol/aztec-packages@b747ac1)) * Document BoundedVec (noir-lang/noir#5974) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Document HashMap (noir-lang/noir#5984) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Merge devnet to master ([#8472](AztecProtocol/aztec-packages#8472)) ([26706e9](AztecProtocol/aztec-packages@26706e9)) * Remove 3 unused functions warnings in the stdlib (noir-lang/noir#5973) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Remove warnings from protocol circuits ([#8420](AztecProtocol/aztec-packages#8420)) ([c4dbcab](AztecProtocol/aztec-packages@c4dbcab)) * Rename files relating to what were "instances" ([#8383](AztecProtocol/aztec-packages#8383)) ([a934e85](AztecProtocol/aztec-packages@a934e85)) * Replace relative paths to noir-protocol-circuits ([1c43bae](AztecProtocol/aztec-packages@1c43bae)) </details> <details><summary>barretenberg: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@barretenberg-v0.53.0...barretenberg-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) * **avm:** variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) * **avm:** variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ### Features * (bb) 128-bit challenges ([#8406](AztecProtocol/aztec-packages#8406)) ([d5b2397](AztecProtocol/aztec-packages@d5b2397)) * **avm:** DSL integration of AVM recursive verifier ([#8405](AztecProtocol/aztec-packages#8405)) ([467120e](AztecProtocol/aztec-packages@467120e)), closes [#8285](AztecProtocol/aztec-packages#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) ([5bb38b1](AztecProtocol/aztec-packages@5bb38b1)) * **avm:** Variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) ([8de1f2a](AztecProtocol/aztec-packages@8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ([5b27fbc](AztecProtocol/aztec-packages@5b27fbc)) * **avm:** Variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) ([dc43306](AztecProtocol/aztec-packages@dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](AztecProtocol/aztec-packages#7990)) ([372f23c](AztecProtocol/aztec-packages@372f23c)) ### Bug Fixes * **avm:** Full proving kernel fix ([#8468](AztecProtocol/aztec-packages#8468)) ([684d962](AztecProtocol/aztec-packages@684d962)) * **bb:** Mac release ([#8450](AztecProtocol/aztec-packages#8450)) ([1b3f914](AztecProtocol/aztec-packages@1b3f914)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](AztecProtocol/aztec-packages#8475)) ([ac88f30](AztecProtocol/aztec-packages@ac88f30)) * Rename files relating to what were "instances" ([#8383](AztecProtocol/aztec-packages#8383)) ([a934e85](AztecProtocol/aztec-packages@a934e85)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

codygunton self-assigned this Sep 5, 2024

codygunton requested review from jeanmon, IlyasRidhuan and fcarreiro as code owners September 5, 2024 07:50

codygunton mentioned this pull request Sep 5, 2024

refactor: Renaming Instance's #8362

Merged

codygunton changed the base branch from master to cg/pg-state-5 September 5, 2024 07:51

codygunton commented Sep 5, 2024

View reviewed changes

fcarreiro removed request for fcarreiro, IlyasRidhuan and jeanmon September 5, 2024 08:01

Base automatically changed from cg/pg-state-5 to master September 5, 2024 14:08

codygunton force-pushed the cg/move-and-rename-insts branch 3 times, most recently from 6432883 to 440dc23 Compare September 5, 2024 19:04

codygunton force-pushed the cg/move-and-rename-insts branch from 440dc23 to 408f09f Compare September 6, 2024 04:15

codygunton added 4 commits September 8, 2024 19:55

Sumcheck doesn't depend on instance classes

fe52b9b

Move and instance files

6690a41

Rename instance inspector header

40200c5

Rename instance inspector src

b74c466

codygunton force-pushed the cg/move-and-rename-insts branch from 408f09f to b74c466 Compare September 8, 2024 19:55

Fixes post-rebase

6ff7fa5

ludamad approved these changes Sep 9, 2024

View reviewed changes

codygunton merged commit a934e85 into master Sep 9, 2024
99 checks passed

codygunton deleted the cg/move-and-rename-insts branch September 9, 2024 15:40

maramihali mentioned this pull request Sep 11, 2024

Move instance out of sumcheck directory AztecProtocol/barretenberg#886

Closed

TomAFrench mentioned this pull request Sep 12, 2024

Nightly release failed #8511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Rename files relating to what were "instances" #8383

chore: Rename files relating to what were "instances" #8383

codygunton commented Sep 5, 2024 •

edited

Loading

codygunton Sep 5, 2024 •

edited

Loading

AztecBot commented Sep 5, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

chore: Rename files relating to what were "instances" #8383

chore: Rename files relating to what were "instances" #8383

Conversation

codygunton commented Sep 5, 2024 • edited Loading

codygunton Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

AztecBot commented Sep 5, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

codygunton commented Sep 5, 2024 •

edited

Loading

codygunton Sep 5, 2024 •

edited

Loading

AztecBot commented Sep 5, 2024 •

edited

Loading