Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove warnings from protocol circuits #8420

Merged
merged 2 commits into from
Sep 9, 2024
Merged

refactor: remove warnings from protocol circuits #8420

merged 2 commits into from
Sep 9, 2024

Conversation

LeilaWang
Copy link
Collaborator

Remove warnings in all files in noir-protocol-circuits except for blob, which Miranda is working on.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Changes to circuit sizes

Generated at commit: 75987647eb363ec944eb277a0e846f9835b8ee24, compared to commit: 316fc4951a22ec060f92c691efda05b1ed55d77a

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 0 ➖ 0.00% +1,330 ❌ +2.04%
private_kernel_init 0 ➖ 0.00% +672 ❌ +1.78%
private_kernel_reset_tiny 0 ➖ 0.00% +455 ❌ +0.59%
private_kernel_reset_small 0 ➖ 0.00% +455 ❌ +0.44%
private_kernel_tail_to_public 0 ➖ 0.00% +248 ❌ +0.43%
private_kernel_reset_medium 0 ➖ 0.00% +455 ❌ +0.29%
private_kernel_reset_big 0 ➖ 0.00% +455 ❌ +0.17%
private_kernel_tail 0 ➖ 0.00% +17 ❌ +0.14%
private_kernel_reset_full_inner 0 ➖ 0.00% +455 ❌ +0.10%
private_kernel_reset 0 ➖ 0.00% +455 ❌ +0.10%
public_kernel_tail 0 ➖ 0.00% +480 ❌ +0.02%
public_kernel_teardown +206 ❌ +0.08% +244 ❌ +0.01%
public_kernel_app_logic +206 ❌ +0.08% +243 ❌ +0.01%
public_kernel_setup +206 ❌ +0.08% +242 ❌ +0.01%
rollup_base 0 ➖ 0.00% +3 ❌ +0.00%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 48,931 (0) 0.00% 66,676 (+1,330) +2.04%
private_kernel_init 27,819 (0) 0.00% 38,460 (+672) +1.78%
private_kernel_reset_tiny 35,560 (0) 0.00% 77,790 (+455) +0.59%
private_kernel_reset_small 39,387 (0) 0.00% 104,196 (+455) +0.44%
private_kernel_tail_to_public 37,506 (0) 0.00% 57,796 (+248) +0.43%
private_kernel_reset_medium 47,044 (0) 0.00% 157,187 (+455) +0.29%
private_kernel_reset_big 62,353 (0) 0.00% 263,372 (+455) +0.17%
private_kernel_tail 4,910 (0) 0.00% 12,253 (+17) +0.14%
private_kernel_reset_full_inner 85,690 (0) 0.00% 445,025 (+455) +0.10%
private_kernel_reset 92,596 (0) 0.00% 474,705 (+455) +0.10%
public_kernel_tail 259,775 (0) 0.00% 2,705,294 (+480) +0.02%
public_kernel_teardown 247,218 (+206) +0.08% 1,962,740 (+244) +0.01%
public_kernel_app_logic 246,587 (+206) +0.08% 1,961,955 (+243) +0.01%
public_kernel_setup 247,047 (+206) +0.08% 1,965,157 (+242) +0.01%
rollup_base 347,688 (0) 0.00% 3,607,503 (+3) +0.00%

Base automatically changed from lw/public_data to master September 9, 2024 13:02
@LeilaWang LeilaWang marked this pull request as ready for review September 9, 2024 13:13
MirandaWood
MirandaWood approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@MirandaWood MirandaWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 incredible work going through all of these!

@LeilaWang LeilaWang merged commit c4dbcab into master Sep 9, 2024
35 checks passed
@LeilaWang LeilaWang deleted the lw/remove_warnings branch September 9, 2024 14:16
PhilWindle pushed a commit that referenced this pull request Sep 10, 2024
@AztecBot
chore(master): Release 0.54.0 (#8449)
64e7cf3 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.54.0</summary>

##
[0.54.0](aztec-package-v0.53.0...aztec-package-v0.54.0)
(2024-09-10)


### Features

* Archiver fork block num
([#8425](#8425))
([a9f2364](a9f2364))


### Miscellaneous

* Merge devnet to master
([#8472](#8472))
([26706e9](26706e9))
</details>

<details><summary>barretenberg.js: 0.54.0</summary>

##
[0.54.0](barretenberg.js-v0.53.0...barretenberg.js-v0.54.0)
(2024-09-10)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.54.0</summary>

##
[0.54.0](aztec-packages-v0.53.0...aztec-packages-v0.54.0)
(2024-09-10)


### ⚠ BREAKING CHANGES

* **avm:** variants for binary operations
([#8473](#8473))
* **avm:** make JUMP(I) 16-bit
([#8443](#8443))
* **avm:** variants for SET opcode
([#8441](#8441))
* **avm:** variants for MOV opcode
([#8440](#8440))

### Features

* (bb) 128-bit challenges
([#8406](#8406))
([d5b2397](d5b2397))
* `Module::add_item` (noir-lang/noir#5947)
([8ac81b1](8ac81b1))
* Add `Expr::as_let` (noir-lang/noir#5964)
([8ac81b1](8ac81b1))
* Add `FunctionDefinition::module` and `StructDefinition::module`
(noir-lang/noir#5956)
([8ac81b1](8ac81b1))
* Add `FunctionDefinition` methods `is_unconstrained` and
`set_unconstrained` (noir-lang/noir#5962)
([8ac81b1](8ac81b1))
* Add `StructDefinition::add_generic`
(noir-lang/noir#5961)
([8ac81b1](8ac81b1))
* Add `StructDefinition::name`
(noir-lang/noir#5960)
([8ac81b1](8ac81b1))
* Add a `panic` method to the stdlib
(noir-lang/noir#5966)
([8ac81b1](8ac81b1))
* Archiver fork block num
([#8425](#8425))
([a9f2364](a9f2364))
* Arithmetic Generics (noir-lang/noir#5950)
([8ac81b1](8ac81b1))
* **avm-transpiler:** Optionally count opcode types
([#8439](#8439))
([21c06b5](21c06b5))
* **avm/public:** User space PublicContext::get_args_hash
([#8292](#8292))
([56ce16a](56ce16a))
* **avm:** DSL integration of AVM recursive verifier
([#8405](#8405))
([467120e](467120e)),
closes
[#8285](#8285)
* **avm:** Make JUMP(I) 16-bit
([#8443](#8443))
([5bb38b1](5bb38b1))
* **avm:** Variants for binary operations
([#8473](#8473))
([8de1f2a](8de1f2a))
* **avm:** Variants for MOV opcode
([#8440](#8440))
([5b27fbc](5b27fbc))
* **avm:** Variants for SET opcode
([#8441](#8441))
([dc43306](dc43306))
* **bb:** Towards reduced polynomial memory usage
([#7990](#7990))
([372f23c](372f23c))
* Let `nargo` and LSP work well in the stdlib
(noir-lang/noir#5969)
([8ac81b1](8ac81b1))
* LSP autocompletion for attributes
(noir-lang/noir#5963)
([8ac81b1](8ac81b1))
* LSP now suggests self fields and methods
(noir-lang/noir#5955)
([8ac81b1](8ac81b1))
* Show doc comments in LSP (noir-lang/noir#5968)
([8ac81b1](8ac81b1))


### Bug Fixes

* Add re-exports back
([#8453](#8453))
([b6cab90](b6cab90))
* **avm:** Full proving kernel fix
([#8468](#8468))
([684d962](684d962))
* **bb:** Mac release
([#8450](#8450))
([1b3f914](1b3f914))
* **docs:** Some docs updates
([#8412](#8412))
([ad73f30](ad73f30))
* Error when `quote` is used in runtime code
(noir-lang/noir#5978)
([8ac81b1](8ac81b1))
* Error when comptime functions are used in runtime code
(noir-lang/noir#5976)
([8ac81b1](8ac81b1))
* Fmt
([#8454](#8454))
([34b4a8a](34b4a8a))
* Guesstimate gas for propose
([#8445](#8445))
([bff0338](bff0338))
* Let `derive(Eq)` work for empty structs
(noir-lang/noir#5965)
([8ac81b1](8ac81b1))
* LSP document symbol didn't work for primitive impls
(noir-lang/noir#5970)
([8ac81b1](8ac81b1))
* **mem2reg:** Handle aliases better when setting a known value for a
load (noir-lang/noir#5959)
([8ac81b1](8ac81b1))
* **mem2reg:** Handle aliases in function last store cleanup and
additional alias unit test (noir-lang/noir#5967)
([8ac81b1](8ac81b1))
* Public data reads and writes verification
([#8296](#8296))
([ae86347](ae86347))
* Restrict keccak256_injective test input to 8 bits
(noir-lang/noir#5977)
([8ac81b1](8ac81b1))
* Suggest trait attributes in LSP
(noir-lang/noir#5972)
([8ac81b1](8ac81b1))


### Miscellaneous

* **bb:** Remove poly downsizing, other fast-follow from structured
polys
([#8475](#8475))
([ac88f30](ac88f30))
* **ci:** Rerun ci when ready for review + don't allow draft merge
([#8456](#8456))
([ede16d3](ede16d3))
* **docs:** Update box readme, remove duplicated features, added box
install to the docs
([#8254](#8254))
([b747ac1](b747ac1))
* Document BoundedVec (noir-lang/noir#5974)
([8ac81b1](8ac81b1))
* Document HashMap (noir-lang/noir#5984)
([8ac81b1](8ac81b1))
* Merge devnet to master
([#8472](#8472))
([26706e9](26706e9))
* Remove 3 unused functions warnings in the stdlib
(noir-lang/noir#5973)
([8ac81b1](8ac81b1))
* Remove warnings from protocol circuits
([#8420](#8420))
([c4dbcab](c4dbcab))
* Rename files relating to what were "instances"
([#8383](#8383))
([a934e85](a934e85))
* Replace relative paths to noir-protocol-circuits
([1c43bae](1c43bae))
</details>

<details><summary>barretenberg: 0.54.0</summary>

##
[0.54.0](barretenberg-v0.53.0...barretenberg-v0.54.0)
(2024-09-10)


### ⚠ BREAKING CHANGES

* **avm:** variants for binary operations
([#8473](#8473))
* **avm:** make JUMP(I) 16-bit
([#8443](#8443))
* **avm:** variants for SET opcode
([#8441](#8441))
* **avm:** variants for MOV opcode
([#8440](#8440))

### Features

* (bb) 128-bit challenges
([#8406](#8406))
([d5b2397](d5b2397))
* **avm:** DSL integration of AVM recursive verifier
([#8405](#8405))
([467120e](467120e)),
closes
[#8285](#8285)
* **avm:** Make JUMP(I) 16-bit
([#8443](#8443))
([5bb38b1](5bb38b1))
* **avm:** Variants for binary operations
([#8473](#8473))
([8de1f2a](8de1f2a))
* **avm:** Variants for MOV opcode
([#8440](#8440))
([5b27fbc](5b27fbc))
* **avm:** Variants for SET opcode
([#8441](#8441))
([dc43306](dc43306))
* **bb:** Towards reduced polynomial memory usage
([#7990](#7990))
([372f23c](372f23c))


### Bug Fixes

* **avm:** Full proving kernel fix
([#8468](#8468))
([684d962](684d962))
* **bb:** Mac release
([#8450](#8450))
([1b3f914](1b3f914))


### Miscellaneous

* **bb:** Remove poly downsizing, other fast-follow from structured
polys
([#8475](#8475))
([ac88f30](ac88f30))
* Rename files relating to what were "instances"
([#8383](#8383))
([a934e85](a934e85))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Sep 11, 2024
@AztecBot
chore(master): Release 0.54.0 (#8449)
5e23c86 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.54.0</summary>

##
[0.54.0](AztecProtocol/aztec-packages@aztec-package-v0.53.0...aztec-package-v0.54.0)
(2024-09-10)


### Features

* Archiver fork block num
([#8425](AztecProtocol/aztec-packages#8425))
([a9f2364](AztecProtocol/aztec-packages@a9f2364))


### Miscellaneous

* Merge devnet to master
([#8472](AztecProtocol/aztec-packages#8472))
([26706e9](AztecProtocol/aztec-packages@26706e9))
</details>

<details><summary>barretenberg.js: 0.54.0</summary>

##
[0.54.0](AztecProtocol/aztec-packages@barretenberg.js-v0.53.0...barretenberg.js-v0.54.0)
(2024-09-10)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.54.0</summary>

##
[0.54.0](AztecProtocol/aztec-packages@aztec-packages-v0.53.0...aztec-packages-v0.54.0)
(2024-09-10)


### ⚠ BREAKING CHANGES

* **avm:** variants for binary operations
([#8473](AztecProtocol/aztec-packages#8473))
* **avm:** make JUMP(I) 16-bit
([#8443](AztecProtocol/aztec-packages#8443))
* **avm:** variants for SET opcode
([#8441](AztecProtocol/aztec-packages#8441))
* **avm:** variants for MOV opcode
([#8440](AztecProtocol/aztec-packages#8440))

### Features

* (bb) 128-bit challenges
([#8406](AztecProtocol/aztec-packages#8406))
([d5b2397](AztecProtocol/aztec-packages@d5b2397))
* `Module::add_item` (noir-lang/noir#5947)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add `Expr::as_let` (noir-lang/noir#5964)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add `FunctionDefinition::module` and `StructDefinition::module`
(noir-lang/noir#5956)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add `FunctionDefinition` methods `is_unconstrained` and
`set_unconstrained` (noir-lang/noir#5962)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add `StructDefinition::add_generic`
(noir-lang/noir#5961)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add `StructDefinition::name`
(noir-lang/noir#5960)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Add a `panic` method to the stdlib
(noir-lang/noir#5966)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Archiver fork block num
([#8425](AztecProtocol/aztec-packages#8425))
([a9f2364](AztecProtocol/aztec-packages@a9f2364))
* Arithmetic Generics (noir-lang/noir#5950)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* **avm-transpiler:** Optionally count opcode types
([#8439](AztecProtocol/aztec-packages#8439))
([21c06b5](AztecProtocol/aztec-packages@21c06b5))
* **avm/public:** User space PublicContext::get_args_hash
([#8292](AztecProtocol/aztec-packages#8292))
([56ce16a](AztecProtocol/aztec-packages@56ce16a))
* **avm:** DSL integration of AVM recursive verifier
([#8405](AztecProtocol/aztec-packages#8405))
([467120e](AztecProtocol/aztec-packages@467120e)),
closes
[#8285](AztecProtocol/aztec-packages#8285)
* **avm:** Make JUMP(I) 16-bit
([#8443](AztecProtocol/aztec-packages#8443))
([5bb38b1](AztecProtocol/aztec-packages@5bb38b1))
* **avm:** Variants for binary operations
([#8473](AztecProtocol/aztec-packages#8473))
([8de1f2a](AztecProtocol/aztec-packages@8de1f2a))
* **avm:** Variants for MOV opcode
([#8440](AztecProtocol/aztec-packages#8440))
([5b27fbc](AztecProtocol/aztec-packages@5b27fbc))
* **avm:** Variants for SET opcode
([#8441](AztecProtocol/aztec-packages#8441))
([dc43306](AztecProtocol/aztec-packages@dc43306))
* **bb:** Towards reduced polynomial memory usage
([#7990](AztecProtocol/aztec-packages#7990))
([372f23c](AztecProtocol/aztec-packages@372f23c))
* Let `nargo` and LSP work well in the stdlib
(noir-lang/noir#5969)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* LSP autocompletion for attributes
(noir-lang/noir#5963)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* LSP now suggests self fields and methods
(noir-lang/noir#5955)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Show doc comments in LSP (noir-lang/noir#5968)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))


### Bug Fixes

* Add re-exports back
([#8453](AztecProtocol/aztec-packages#8453))
([b6cab90](AztecProtocol/aztec-packages@b6cab90))
* **avm:** Full proving kernel fix
([#8468](AztecProtocol/aztec-packages#8468))
([684d962](AztecProtocol/aztec-packages@684d962))
* **bb:** Mac release
([#8450](AztecProtocol/aztec-packages#8450))
([1b3f914](AztecProtocol/aztec-packages@1b3f914))
* **docs:** Some docs updates
([#8412](AztecProtocol/aztec-packages#8412))
([ad73f30](AztecProtocol/aztec-packages@ad73f30))
* Error when `quote` is used in runtime code
(noir-lang/noir#5978)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Error when comptime functions are used in runtime code
(noir-lang/noir#5976)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Fmt
([#8454](AztecProtocol/aztec-packages#8454))
([34b4a8a](AztecProtocol/aztec-packages@34b4a8a))
* Guesstimate gas for propose
([#8445](AztecProtocol/aztec-packages#8445))
([bff0338](AztecProtocol/aztec-packages@bff0338))
* Let `derive(Eq)` work for empty structs
(noir-lang/noir#5965)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* LSP document symbol didn't work for primitive impls
(noir-lang/noir#5970)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* **mem2reg:** Handle aliases better when setting a known value for a
load (noir-lang/noir#5959)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* **mem2reg:** Handle aliases in function last store cleanup and
additional alias unit test (noir-lang/noir#5967)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Public data reads and writes verification
([#8296](AztecProtocol/aztec-packages#8296))
([ae86347](AztecProtocol/aztec-packages@ae86347))
* Restrict keccak256_injective test input to 8 bits
(noir-lang/noir#5977)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Suggest trait attributes in LSP
(noir-lang/noir#5972)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))


### Miscellaneous

* **bb:** Remove poly downsizing, other fast-follow from structured
polys
([#8475](AztecProtocol/aztec-packages#8475))
([ac88f30](AztecProtocol/aztec-packages@ac88f30))
* **ci:** Rerun ci when ready for review + don't allow draft merge
([#8456](AztecProtocol/aztec-packages#8456))
([ede16d3](AztecProtocol/aztec-packages@ede16d3))
* **docs:** Update box readme, remove duplicated features, added box
install to the docs
([#8254](AztecProtocol/aztec-packages#8254))
([b747ac1](AztecProtocol/aztec-packages@b747ac1))
* Document BoundedVec (noir-lang/noir#5974)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Document HashMap (noir-lang/noir#5984)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Merge devnet to master
([#8472](AztecProtocol/aztec-packages#8472))
([26706e9](AztecProtocol/aztec-packages@26706e9))
* Remove 3 unused functions warnings in the stdlib
(noir-lang/noir#5973)
([8ac81b1](AztecProtocol/aztec-packages@8ac81b1))
* Remove warnings from protocol circuits
([#8420](AztecProtocol/aztec-packages#8420))
([c4dbcab](AztecProtocol/aztec-packages@c4dbcab))
* Rename files relating to what were "instances"
([#8383](AztecProtocol/aztec-packages#8383))
([a934e85](AztecProtocol/aztec-packages@a934e85))
* Replace relative paths to noir-protocol-circuits
([1c43bae](AztecProtocol/aztec-packages@1c43bae))
</details>

<details><summary>barretenberg: 0.54.0</summary>

##
[0.54.0](AztecProtocol/aztec-packages@barretenberg-v0.53.0...barretenberg-v0.54.0)
(2024-09-10)


### ⚠ BREAKING CHANGES

* **avm:** variants for binary operations
([#8473](AztecProtocol/aztec-packages#8473))
* **avm:** make JUMP(I) 16-bit
([#8443](AztecProtocol/aztec-packages#8443))
* **avm:** variants for SET opcode
([#8441](AztecProtocol/aztec-packages#8441))
* **avm:** variants for MOV opcode
([#8440](AztecProtocol/aztec-packages#8440))

### Features

* (bb) 128-bit challenges
([#8406](AztecProtocol/aztec-packages#8406))
([d5b2397](AztecProtocol/aztec-packages@d5b2397))
* **avm:** DSL integration of AVM recursive verifier
([#8405](AztecProtocol/aztec-packages#8405))
([467120e](AztecProtocol/aztec-packages@467120e)),
closes
[#8285](AztecProtocol/aztec-packages#8285)
* **avm:** Make JUMP(I) 16-bit
([#8443](AztecProtocol/aztec-packages#8443))
([5bb38b1](AztecProtocol/aztec-packages@5bb38b1))
* **avm:** Variants for binary operations
([#8473](AztecProtocol/aztec-packages#8473))
([8de1f2a](AztecProtocol/aztec-packages@8de1f2a))
* **avm:** Variants for MOV opcode
([#8440](AztecProtocol/aztec-packages#8440))
([5b27fbc](AztecProtocol/aztec-packages@5b27fbc))
* **avm:** Variants for SET opcode
([#8441](AztecProtocol/aztec-packages#8441))
([dc43306](AztecProtocol/aztec-packages@dc43306))
* **bb:** Towards reduced polynomial memory usage
([#7990](AztecProtocol/aztec-packages#7990))
([372f23c](AztecProtocol/aztec-packages@372f23c))


### Bug Fixes

* **avm:** Full proving kernel fix
([#8468](AztecProtocol/aztec-packages#8468))
([684d962](AztecProtocol/aztec-packages@684d962))
* **bb:** Mac release
([#8450](AztecProtocol/aztec-packages#8450))
([1b3f914](AztecProtocol/aztec-packages@1b3f914))


### Miscellaneous

* **bb:** Remove poly downsizing, other fast-follow from structured
polys
([#8475](AztecProtocol/aztec-packages#8475))
([ac88f30](AztecProtocol/aztec-packages@ac88f30))
* Rename files relating to what were "instances"
([#8383](AztecProtocol/aztec-packages#8383))
([a934e85](AztecProtocol/aztec-packages@a934e85))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirandaWood MirandaWood MirandaWood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeilaWang @MirandaWood