Skip to content

Commit

Permalink
Update CODEOWNERS paths: fix invalid paths (#1535)
Browse files Browse the repository at this point in the history
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
  • Loading branch information
Konrad Jamrozik authored Feb 10, 2023
1 parent 40aedc0 commit d95956e
Showing 1 changed file with 15 additions and 8 deletions.
23 changes: 15 additions & 8 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

* @jongio @ellismg
/cli/ @ellismg @wbreza @vhvb1989 @hemarina @jongio @weikanglim
/cli/installer @ellismg @danieljurek
/ext/ @karolz-ms @ellismg @jongio
/** @jongio @ellismg

/cli/ @ellismg @wbreza @vhvb1989 @hemarina @jongio @weikanglim
/cli/installer/ @ellismg @danieljurek

/ext/ @karolz-ms @ellismg @jongio

/generators/repo/ @wbreza @ellismg @danieljurek
/.github/ @danieljurek @ellismg
/eng/ @danieljurek @ellismg
/schemas/ @jongio @karolz-ms @ellismg @wbreza
/templates/ @jongio @wbreza

/.github/ @danieljurek @ellismg

/eng/ @danieljurek @ellismg

/schemas/ @jongio @karolz-ms @ellismg @wbreza

/templates/ @jongio @wbreza

0 comments on commit d95956e

Please sign in to comment.