Update NotificationConfiguration package from 20230119.1 to 20230127.4
#5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
weshaggard
approved these changes
Jan 27, 2023
konrad-jamrozik
commented
Jan 28, 2023
konrad-jamrozik
changed the title
NotificationConfiguration package from 20230119.1 to 20230126.1NotificationConfiguration package from 20230119.1 to 20230127.4
|
/check-enforcer override |
konrad-jamrozik
deleted the
users/kojamroz/update_notif_conf20230126.1
branch
This was referenced Jan 30, 2023
Merged
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534
konrad-jamrozik
added a commit
to Azure/azure-sdk-for-c
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-cpp
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-ios
that referenced
this pull request
Feb 10, 2023
- Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-android
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-dev
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
ellismg
pushed a commit
to Azure/azure-dev
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
added a commit
to Azure/azure-sdk-for-c
that referenced
this pull request
Feb 13, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-ios
that referenced
this pull request
Feb 13, 2023
- Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-android
that referenced
this pull request
Feb 13, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Feb 13, 2023
* Update `CODEOWNERS` paths: fix invalid paths As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534 * Update .github/CODEOWNERS Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
NotificationConfigurationpackage, to deploy these changes:Contactsclass + related refactorings toNotificationConfiguratorclass. #5214azure-sdk-for-netrepo #5241Azure.Sdk.Tools.NotificationConfiguration.Tests+ improveNotificationConfiguration.Program.Main#5247Testing done
See
Test Planhere:Contactsclass + related refactorings toNotificationConfiguratorclass. #5214 (comment)Reference
notification-configurationtool docautomation - build-failure-notification-subscriptionspipeline