Update keys.json #10495

jlichwa · 2020-08-17T23:46:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-17T23:46:42Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-17T23:46:56Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-17T23:48:18Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:19Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:20Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:21Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:22Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:22Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-17T23:48:23Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 5e9e6c9 with merge commit 07f6986. SDK Automation 13.0.17.20200909.5

[AutoRest] FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/keyvault/v7.1/keyvault of tag package-7.1 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest] Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/keyvault/data-plane/readme.md FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/keyvault/v7.1/keyvault of tag package-7.1 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
   at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-08-17T23:48:26Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

heaths · 2020-08-17T23:52:50Z

specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.1/keys.json

@@ -1013,7 +1013,7 @@
              },
              {
                "value": "oct",
-                "description": "Octet sequence (used to represent symmetric keys)"
+                "description": "Not supported in this version. Octet sequence (used to represent symmetric keys)"


Should this be backported to the previews and 7.0 (stable and preview) as well?

azuresdkci · 2020-08-18T00:30:20Z

Can one of the admins verify this patch?

azure-pipelines · 2020-08-18T01:07:31Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-18T01:08:55Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

jlichwa · 2020-08-18T01:26:53Z

#sign-off

* Update keys.json * Update keyvault.json

…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...

Update keys.json

9ee5797

jlichwa requested review from heaths and RandalliLama as code owners August 17, 2020 23:46

openapi-assignment-bot bot assigned lmazuel Aug 17, 2020

heaths approved these changes Aug 17, 2020

View reviewed changes

Update keyvault.json

5e9e6c9

lmazuel approved these changes Sep 15, 2020

View reviewed changes

lmazuel merged commit 07f6986 into Azure:master Sep 15, 2020

nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020

Update keys.json (Azure#10495)

df104a0

* Update keys.json * Update keyvault.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update keys.json #10495

Update keys.json #10495

jlichwa commented Aug 17, 2020

openapi-pipeline-app bot commented Aug 17, 2020 •

edited

Loading

azure-pipelines bot commented Aug 17, 2020

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

heaths Aug 17, 2020

azuresdkci commented Aug 18, 2020

azure-pipelines bot commented Aug 18, 2020

openapi-sdkautomation bot commented Aug 18, 2020 •

edited

Loading

jlichwa commented Aug 18, 2020

Update keys.json #10495

Update keys.json #10495

Conversation

jlichwa commented Aug 17, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 17, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 17, 2020

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 17, 2020 • edited Loading

azure-resource-manager-schemas - Release

heaths Aug 17, 2020

Choose a reason for hiding this comment

azuresdkci commented Aug 18, 2020

azure-pipelines bot commented Aug 18, 2020

openapi-sdkautomation bot commented Aug 18, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

jlichwa commented Aug 18, 2020

openapi-pipeline-app bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 18, 2020 •

edited

Loading