Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding request body for listcredential for Microsoft.Kubernetes #10766

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Adding request body for listcredential for Microsoft.Kubernetes #10766

merged 4 commits into from
Sep 15, 2020

Conversation

akashkeshari
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 11, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 11, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 11, 2020

azure-sdk-for-net - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 82939ab with merge commit 32af5f5. SDK Automation 13.0.17.20200909.5
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    Failed to find any changed packages. Please check the changed file list.
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/ConnectedClusterOperations.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/ConnectedClusterOperationsExtensions.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/ConnectedKubernetesClient.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/IConnectedClusterOperations.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/IConnectedKubernetesClient.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/IOperations.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/AuthenticationCertificateDetails.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/AuthenticationDetails.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/AuthenticationDetailsValue.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/AuthenticationMethod.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/AzureEntityResource.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ConnectedCluster.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ConnectedClusterAADProfile.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ConnectedClusterIdentity.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ConnectedClusterPatch.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/CredentialResult.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/CredentialResults.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ErrorDetails.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ErrorResponse.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ErrorResponseException.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/Operation.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/OperationDisplay.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/Page.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ProvisioningState.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ProxyResource.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/Resource.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/ResourceIdentityType.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Models/TrackedResource.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/Operations.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/OperationsExtensions.cs
    /z/work/azure-sdk-for-net/sdk/Kubernetes/Management.Kubernetes/Generated/SdkInfo_ConnectedKubernetesClient.cs

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 11, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 82939ab with merge commit 32af5f5. SDK Automation 13.0.17.20200909.5
  • ⚠️azure-mgmt-hybridkubernetes [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridkubernetes
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridkubernetes
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 05:07:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0480:3E24:1514F0:40251C:5F604C27","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 14.091% size of original (original: 9623 chars, delta: 1356 chars)
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation ConnectedClusterOperations.list_cluster_user_credentials has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 11, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 82939ab with merge commit 32af5f5. Schema Automation 13.0.17.20200909.5
  • ⚠️hybridkubernetes [View full logs]  [Release Schema Changes]
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 05:07:32 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0780:7BE6:14C7CB3:2B38786:5F604C14","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 339cb32 with merge commit b022e57cbe6612bb901b3894ca7047f3dbbc36d5. SDK Automation 13.0.17.20200909.5
    • ⚠️azure-mgmt-hybridkubernetes [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridkubernetes
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridkubernetes
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 11:43:48 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C2:4A1F:1C85A1:4C6356:5F5B62F4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 14.029% size of original (original: 9616 chars, delta: 1349 chars)
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation ConnectedClusterOperations.list_cluster_user_credentials has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    azure-sdk-for-js - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 82939ab with merge commit 32af5f5. SDK Automation 13.0.17.20200909.5
    • ️✔️preview/hybridkubernetes/mgmt/2020-01-01-preview [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 05:09:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0480:3836:241B48C:3B8BDDF:5F604C9F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 82939ab with merge commit 32af5f5. SDK Automation 13.0.17.20200909.5
    • ️✔️hybridkubernetes/resource-manager/v2020_01_01_preview [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 05:10:27 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0680:561C:5BB0CF:6F5313:5F604CC3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    "description": "The mode of client authentication.",
    "enum": [
    "Token",
    "Certificate"
    Copy link
    Member

    @raunakpandya raunakpandya Sep 11, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Certificate [](start = 13, length = 11)

    ClientCertificate #Closed

    Copy link
    Contributor Author

    @akashkeshari akashkeshari Sep 11, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated #Closed

    "api-version": "2020-01-01-preview"
    "api-version": "2020-01-01-preview",
    "ClientAuthenticationDetails": {
    "authenticationMethod": "Certificate",
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Certificate [](start = 31, length = 11)

    Can you add another example here and leave the default example with no body? No bodyworks for AAD scenario. For non AAD case user needs to pass in credential

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    added

    Copy link
    Member

    @raunakpandya raunakpandya left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 11, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    Copy link
    Member

    @raunakpandya raunakpandya left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @chiragg4u
    Copy link
    Contributor

    Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

    @akashkeshari
    Copy link
    Contributor Author

    Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

    Will require you approval on the PR in order to request the SDK release. https://portal.azure-devex-tools.com/tools/request-api-release

    Please approve

    @qianwens qianwens merged commit 32af5f5 into Azure:master Sep 15, 2020
    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    …e#10766)
    
    * added request body for list credential api
    
    * Added another example for non aad scenario for list credential api
    
    * removed required properties in authentication object
    
    * made properties back reqd since body is optional
    
    Co-authored-by: Akash Keshari <akkeshar@microsoft.com>
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
    …into formrecognizer_regeneration
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits)
      [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757)
      added new api version (Azure#10784)
      updated apispec (Azure#10719)
      Bump up version number for "old" preview api (Azure#10768)
      [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699)
      [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487)
      Update provisioningStatus field name for assignment (Azure#10754)
      [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755)
      Add Metrics Advisor API Properties. (Azure#10722)
      Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796)
      Update keys.json (Azure#10495)
      Add new API version 2020-09-01 (Azure#10737)
      Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791)
      Add support for filter by deviceId (Azure#10771)
      Update openapi-authoring-automated-guidelines.md (Azure#10606)
      Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766)
      Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705)
      add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789)
      Update workbooks api to include sourceId (Azure#10781)
      [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753)
      ...
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants