Dev/ivarandj/instance pool operations api #29932

ivanarandjelovic · 2024-07-22T12:01:33Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-07-22T12:01:37Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-07-22T12:01:38Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.2
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-sql [Preview SDK Changes]

️⚠️ azure-sdk-for-net-track2 warning [Detail]

FAQ

⚠️Warning in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.

️✔️Azure.ResourceManager.Sql [Preview SDK Changes] Breaking Change Detected

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Sql.Models.ManagedInstancePropertiesProvisioningState' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.Sql.Models.QueryMetricInterval> Azure.ResourceManager.Sql.Models.QueryStatisticsProperties.Intervals.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Sql/Debug/netstandard2.0/Azure.ResourceManager.Sql.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj::TargetFramework=netstandard2.0]

Parse Suppression File Errors
No suppression file added.

Please refer to the guidance for suppressing SDK breaking changes.

️❌ azure-sdk-for-java failed [Detail]

FAQ

❌Code Generator Failed in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmdout	[Java-Sdk-Automation] [ERROR] COMPILATION ERROR :
cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/src/main/java/com/azure/resourcemanager/sql/generated/fluent/models/BackupShortTermRetentionPolicyProperties.java:[101,91] cannot find symbol
cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/src/main/java/com/azure/resourcemanager/sql/generated/implementation/SqlVulnerabilityAssessmentImpl.java:[124,61] incompatible types: com.azure.resourcemanager.sql.generated.models.VulnerabilityAssessmentName cannot be converted to com.azure.resourcemanager.sql.generated.models.SqlVulnerabilityAssessmentName
cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated/src/main/java/com/azure/resourcemanager/sql/generated/implementation/SqlVulnerabilityAssessmentImpl.java:[132,61] incompatible types: com.azure.resourcemanager.sql.generated.models.VulnerabilityAssessmentName cannot be converted to com.azure.resourcemanager.sql.generated.models.SqlVulnerabilityAssessmentName
cmdout	[Java-Sdk-Automation] 2024-07-23 10:19:37 [ERROR] [COMPILE] Maven build fail.
cmdout	[Java-Sdk-Automation] 2024-07-23 10:19:37 [ERROR] You can inquire in "Language - Java" Teams channel. Please include the link of this Pull Request in the query.
cmderr	[Java-Sdk-Automation] Traceback (most recent call last):
cmderr	[Java-Sdk-Automation]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/automation/generate.py", line 429, in <module>
cmderr	[Java-Sdk-Automation]     main()
cmderr	[Java-Sdk-Automation]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/automation/generate.py", line 340, in main
cmderr	[Java-Sdk-Automation]     return sdk_automation(args["config"][0], args["config"][1])
cmderr	[Java-Sdk-Automation]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/automation/generate.py", line 118, in sdk_automation
cmderr	[Java-Sdk-Automation]     packages = sdk_automation_autorest(config)
cmderr	[Java-Sdk-Automation]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/automation/generate.py", line 206, in sdk_automation_autorest
cmderr	[Java-Sdk-Automation]     "changelog": {"content": changelog, "hasBreakingChange": breaking},
cmderr	[Java-Sdk-Automation] UnboundLocalError: local variable 'changelog' referenced before assignment
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-java]: ./eng/automation/generate.py
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/sql/armsql [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-sql [Preview SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.2
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️⚠️ azure-powershell warning [Detail]

FAQ

⚠️Warning in generating from eeef9159bde59a0a4607b34bfa0025e120c308ed. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.sql.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-07-22T12:01:38Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/ddcdbf3100fb45bbaafb400a9a70d425?revisionId=496d9d14c4c14018b987fbb0dd766fd3
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/129721cd69b541de821b5e7227b49902?revisionId=de4f685382bd4618bf4408307029cd7b
.Net	Azure.ResourceManager.Sql	https://apiview.dev/Assemblies/Review/1e3ea1e2dc2c4679b3acd45b20b81a18?revisionId=ae311d90ab9f4296892bdc3655a9a511
Swagger	Microsoft.Sql	https://apiview.dev/Assemblies/Review/86f9467cec6a49f899d90b4872280851?revisionId=4541c426764e4a6baf6a0270a035a687

ericshape · 2024-07-22T23:01:18Z

@ivanarandjelovic please fix https://github.com/Azure/azure-rest-api-specs/pull/29932/checks?check_run_id=27748070049
in dsmain and swagger

ivanarandjelovic · 2024-07-23T10:54:10Z

@ivanarandjelovic please fix https://github.com/Azure/azure-rest-api-specs/pull/29932/checks?check_run_id=27748070049 in dsmain and swagger

Fixed. DsMainDev PR: https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev/pullrequest/1411050

...on/sql/resource-manager/Microsoft.Sql/preview/2024-05-01-preview/InstancePoolOperations.json

ms-bogdan-rotaru · 2024-07-30T09:17:58Z

/azp run

azure-pipelines · 2024-07-30T09:18:17Z

Azure Pipelines successfully started running 4 pipeline(s).

… ModelValidation (and it should not be failing)

* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* Adding folders and examples changes for Version 2024-05-01 preview version (Azure#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (Azure#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (Azure#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (Azure#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (Azure#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (Azure#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (Azure#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (Azure#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (Azure#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

ivanarandjelovic requested review from jamestao, ericshape and jeremyfrosti as code owners July 22, 2024 12:01

azure-sdk mentioned this pull request Jul 22, 2024

[AutoPR sdk/resourcemanager/sql/armsql] Dev/ivarandj/instance pool operations api azure-sdk/azure-sdk-for-go#10627

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 22, 2024

razvanbadea-msft reviewed Jul 23, 2024

View reviewed changes

...on/sql/resource-manager/Microsoft.Sql/preview/2024-05-01-preview/InstancePoolOperations.json Show resolved Hide resolved

razvanbadea-msft reviewed Jul 23, 2024

View reviewed changes

...on/sql/resource-manager/Microsoft.Sql/preview/2024-05-01-preview/InstancePoolOperations.json Show resolved Hide resolved

razvanbadea-msft reviewed Jul 23, 2024

View reviewed changes

...on/sql/resource-manager/Microsoft.Sql/preview/2024-05-01-preview/InstancePoolOperations.json Outdated Show resolved Hide resolved

razvanbadea-msft reviewed Jul 23, 2024

View reviewed changes

...on/sql/resource-manager/Microsoft.Sql/preview/2024-05-01-preview/InstancePoolOperations.json Show resolved Hide resolved

razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 23, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 23, 2024

ivanarandjelovic removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 30, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 30, 2024

ms-bogdan-rotaru approved these changes Jul 30, 2024

View reviewed changes

ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 30, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 30, 2024

ivanarandjelovic added the MergeRequested label Jul 30, 2024

ms-bogdan-rotaru enabled auto-merge (squash) July 31, 2024 09:08

ivanarandjelovic force-pushed the dev/ivarandj/InstancePools_operations_api branch from 72142c4 to 10c53f7 Compare July 31, 2024 09:23

Ivan Arandjelovic added 6 commits July 31, 2024 11:23

Add instance pool operations swagger and examples

8d85929

Address prettier check errors

e825920

Fix Swagger LintDiff errors

4a39120

Fix parameter names to match parameter patterns

90b052b

Remove validation for resourceGroupName parameter as it fails Swagger…

51bb009

… ModelValidation (and it should not be failing)

Replace bool with enum (PR review remark)

10c53f7

ms-bogdan-rotaru merged commit c145fd6 into Azure:release-sql-Microsoft.Sql-2024-05-01-preview Jul 31, 2024
23 of 28 checks passed

dhruvesh mentioned this pull request Aug 23, 2024

Release sql microsoft.sql 2024 05 01 preview #30165

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev/ivarandj/instance pool operations api #29932

Dev/ivarandj/instance pool operations api #29932

ivanarandjelovic commented Jul 22, 2024

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading

ericshape commented Jul 22, 2024

ivanarandjelovic commented Jul 23, 2024

ms-bogdan-rotaru commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

Dev/ivarandj/instance pool operations api #29932

Dev/ivarandj/instance pool operations api #29932

Conversation

ivanarandjelovic commented Jul 22, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jul 22, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jul 22, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jul 22, 2024 • edited Loading

Generated ApiView

ericshape commented Jul 22, 2024

ivanarandjelovic commented Jul 23, 2024

ms-bogdan-rotaru commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 22, 2024 •

edited

Loading