Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview #30030

ravigautam1896 · 2024-07-31T01:06:49Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-07-31T01:06:53Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-07-31T01:06:53Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/ddcdbf3100fb45bbaafb400a9a70d425?revisionId=06b1a83e617342e1b9c0cca3a5d3e42d
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/129721cd69b541de821b5e7227b49902?revisionId=0678827bb67842b6ba45dba2aed2fef3
.Net	Azure.ResourceManager.Sql	https://apiview.dev/Assemblies/Review/1e3ea1e2dc2c4679b3acd45b20b81a18?revisionId=39d95ef8964549e1aff2ffa77cc80dfa
Swagger	Microsoft.Sql	https://apiview.dev/Assemblies/Review/86f9467cec6a49f899d90b4872280851?revisionId=45fba1b3373148d9a1cbd5eae23fea64

ravigautam1896 · 2024-08-07T15:20:29Z

/azp run

azure-pipelines · 2024-08-07T15:20:51Z

Azure Pipelines successfully started running 4 pipeline(s).

…ravi/release-2024-05-01-preview_minorchanges

ravigautam1896 · 2024-08-08T14:49:51Z

/azp run

azure-pipelines · 2024-08-08T14:50:12Z

Azure Pipelines successfully started running 4 pipeline(s).

…ravi/release-2024-05-01-preview_minorchanges

* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* Adding folders and examples changes for Version 2024-05-01 preview version (Azure#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (Azure#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (Azure#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (Azure#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (Azure#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (Azure#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (Azure#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (Azure#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (Azure#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

Ravi Gautam added 2 commits July 29, 2024 19:34

taking changes from dsmaindev side

90f3216

resolving merge conflicts

99d418a

ravigautam1896 requested review from jamestao, ericshape and jeremyfrosti as code owners July 31, 2024 01:06

removing further DatabaseAdvisor.json changes

e249fd9

azure-sdk mentioned this pull request Jul 31, 2024

[AutoPR sdk/resourcemanager/sql/armsql] Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview azure-sdk/azure-sdk-for-go#10716

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2024

ravigautam1896 mentioned this pull request Jul 31, 2024

Adding swagger files related to Release 2024-05-01 preview branch #30003

Closed

8 tasks

ravigautam1896 changed the title ~~Adding swagger files and example files related to release 2024-05-01 preview branch~~ Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview Jul 31, 2024

azure-sdk mentioned this pull request Jul 31, 2024

[AutoPR azure-mgmt-sql] Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview azure-sdk/azure-sdk-for-python#7827

Closed

Ravi Gautam added 3 commits August 5, 2024 06:53

resolving spellcheck validation

d831219

resolving ModelValidation errors

43b49e8

resolving avocado errors

2c22128

Merge branch 'release-sql-Microsoft.Sql-2024-05-01-preview' into dev/…

6c107ff

…ravi/release-2024-05-01-preview_minorchanges

Ravi Gautam added 2 commits August 10, 2024 06:50

resolving LRO Headers Validation and xmsEnum Validation

7ffc934

resolving indentation

ce95079

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 10, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 10, 2024

ericshape approved these changes Aug 10, 2024

View reviewed changes

ravigautam1896 added the MergeRequested label Aug 10, 2024

Merge branch 'release-sql-Microsoft.Sql-2024-05-01-preview' into dev/…

3aebb88

…ravi/release-2024-05-01-preview_minorchanges

gary-x-li merged commit e226d06 into Azure:release-sql-Microsoft.Sql-2024-05-01-preview Aug 12, 2024
24 of 28 checks passed

dhruvesh mentioned this pull request Aug 23, 2024

Release sql microsoft.sql 2024 05 01 preview #30165

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview #30030

Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview #30030

ravigautam1896 commented Jul 31, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 31, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 31, 2024 •

edited

Loading

ravigautam1896 commented Aug 7, 2024

azure-pipelines bot commented Aug 7, 2024

ravigautam1896 commented Aug 8, 2024

azure-pipelines bot commented Aug 8, 2024

Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview #30030

Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview #30030

Conversation

ravigautam1896 commented Jul 31, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jul 31, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jul 31, 2024 • edited Loading

Generated ApiView

ravigautam1896 commented Aug 7, 2024

azure-pipelines bot commented Aug 7, 2024

ravigautam1896 commented Aug 8, 2024

azure-pipelines bot commented Aug 8, 2024

ravigautam1896 commented Jul 31, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 31, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 31, 2024 •

edited

Loading