-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lintdiff enum error in InstancePoolOperations API #30383
Merged
ivanarandjelovic
merged 1 commit into
Azure:release-sql-Microsoft.Sql-2024-05-01-preview
from
ivanarandjelovic:dev/ivarandj/fix_lintdiff_enum_errors
Sep 2, 2024
Merged
Fix lintdiff enum error in InstancePoolOperations API #30383
ivanarandjelovic
merged 1 commit into
Azure:release-sql-Microsoft.Sql-2024-05-01-preview
from
ivanarandjelovic:dev/ivarandj/fix_lintdiff_enum_errors
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
This was referenced Aug 30, 2024
7984546
to
e3cd8a5
Compare
ravigautam1896
approved these changes
Sep 2, 2024
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
f3038a5
into
Azure:release-sql-Microsoft.Sql-2024-05-01-preview
20 of 28 checks passed
ravigautam1896
added a commit
that referenced
this pull request
Sep 16, 2024
* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
jaskisin
pushed a commit
to jaskisin/azure-rest-api-specs
that referenced
this pull request
Sep 16, 2024
* Adding folders and examples changes for Version 2024-05-01 preview version (Azure#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (Azure#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (Azure#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (Azure#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (Azure#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (Azure#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (Azure#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (Azure#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (Azure#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
grangasamy-msft
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <rmanda@microsoft.com> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> --------- Co-authored-by: Ravi Gautam <ravigautam@microsoft.com> Co-authored-by: psong-ms <147777703+psong-ms@users.noreply.github.com> Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com> Co-authored-by: Ivan Arandjelovic <ivan.arandjelovic@gmail.com> Co-authored-by: Ivan Arandjelovic <ivarandj@microsoft.com> Co-authored-by: akromm <87152103+akromm@users.noreply.github.com> Co-authored-by: Roopesh Manda <rmanda@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
SQL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Enum types should have x-ms-enum tag
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.