-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Networkwatcer] add FlowLogFormatParameters #4374
[Networkwatcer] add FlowLogFormatParameters #4374
Conversation
…e/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties
…rk/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a.
…e/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters
Can one of the admins verify this patch? |
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-rubyA PR has been created for you: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-nodeA PR has been created for you: |
I want to merge to the Nov release. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * [Networkwatcer] add FlowLogFormatParameters (#4374) * Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters * [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420) * Make NIC VM ref readonly (#4443) * Mark private IP address read-only (#4447) * change container nics property type on container nic config to resourceid (#4459) * Port fix from PR 4459 to 2018-10-01 (#4463) * Application Gateway - Adds Rewrite rule set for Header CRUD (#4331) * Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly * Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (#4459)" This reverts commit baf31d9. * Fixes the missing array for the header actions (#4497) * Network py 2018-10 * add package-2018-10 to Go SDK codegen * Application gateway Identity and Keyvault support (#4387) * identity and keyvault * Capitalization comment * Ported fix from master branch (#4547)
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * [Networkwatcer] add FlowLogFormatParameters (#4374) * Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters * [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420) * Make NIC VM ref readonly (#4443) * Mark private IP address read-only (#4447) * change container nics property type on container nic config to resourceid (#4459) * Port fix from PR 4459 to 2018-10-01 (#4463) * Application Gateway - Adds Rewrite rule set for Header CRUD (#4331) * Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly * Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (#4459)" This reverts commit baf31d9. * Fixes the missing array for the header actions (#4497) * Network py 2018-10 * add package-2018-10 to Go SDK codegen * Application gateway Identity and Keyvault support (#4387) * identity and keyvault * Capitalization comment * Ported fix from master branch (#4547) * Add support for list api for global reach connections * address farhan comment
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger