Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for List Operation on global reach connections #4589

Merged
merged 19 commits into from
Nov 27, 2018
Merged

Add support for List Operation on global reach connections #4589

merged 19 commits into from
Nov 27, 2018

Conversation

dedhar
Copy link
Contributor

@dedhar dedhar commented Nov 27, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [Y ] I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

MikhailTryakhov and others added 18 commits October 30, 2018 12:42
@MikhailTryakhov
Adds base for updating Microsoft.Network from version stable/2018-08-…
a656032 
…01 to version 2018-10-01
@MikhailTryakhov
Updates readme
c3cd206
@MikhailTryakhov
Updates API version in new specs and examples
1c4c949
@zwswim @dsgouda
[Networkwatcer] add FlowLogFormatParameters (Azure#4374)
6361217 
* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json

[Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties

* Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json"

This reverts commit f4f438a.

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json

[networkwatcer] add FlowLogFormatParameters
@zwswim @dsgouda
[Network wathcer] add a new field trafficAnalyticsInterval for TA (Az…
66d8777 
…ure#4420)
@EvgenyAgafonchikov @dsgouda
Make NIC VM ref readonly (Azure#4443)
92d2e0a
@fanymanea @jianghaolu
Mark private IP address read-only (Azure#4447)
5a95c8f
@Flip-Liquid @dsgouda
change container nics property type on container nic config to resour…
baf31d9 
…ceid (Azure#4459)
@EvgenyAgafonchikov @MikhailTryakhov
Port fix from PR 4459 to 2018-10-01 (Azure#4463)
5ea0c7b
@sai-manoj-kumar @MikhailTryakhov
Application Gateway - Adds Rewrite rule set for Header CRUD (Azure#4331)
633d12d 
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* Adds Rewrite rule set for Header CRUD

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

* Adds examples for the Header CRUD in application gateway

* Fix the examples; replacing rules with rewriteRules.

* Fixing the properties of application Gateway rewriteRule

* Revert "Fixing the properties of application Gateway rewriteRule"

This reverts commit 05c9c91.

* Fixing the properties of application Gateway rewriteRule

* Mark the provisioning state as readOnly

* Mark etag as readOnly
@Flip-Liquid @dsgouda
Revert "Model ContainerNic refs under ContainerNicConfig as sub resou…
a18fe30 
…rces" (Azure#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (Azure#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (Azure#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (Azure#4459)"

This reverts commit baf31d9.
@sai-manoj-kumar @dsgouda
Fixes the missing array for the header actions (Azure#4497)
f321a6c
@lmazuel
Network py 2018-10
8f92958
@jhendrixMSFT
add package-2018-10 to Go SDK codegen
d5e3525
@akshaysngupta @MikhailTryakhov
Application gateway Identity and Keyvault support (Azure#4387)
e582297 
* identity and keyvault

* Capitalization comment
@EvgenyAgafonchikov @MikhailTryakhov
Ported fix from master branch (Azure#4547)
89199d6
@dedhar
Merge branch 'network-november-release' of https://github.com/Azure/a…
9273ebf 
…zure-rest-api-specs
@dedhar
Add support for list api for global reach connections
b9c1d43
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dedhar
Copy link
Contributor Author

dedhar commented Nov 27, 2018

https://msazure.visualstudio.com/One/_workitems/edit/3334271 -- Tracking workitem

@dedhar dedhar requested review from vinayada1 and syfarogh November 27, 2018 17:44
@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#593

@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@dedhar
Copy link
Contributor Author

dedhar commented Nov 27, 2018

Tested the change using local NRP and ARM Client
D:>armclient get "http://127.0.0.1/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections?api-version=2018-02-01"
{
"value": [
{
"name": "circuitConnectionCktAToB",
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections/circuitConnectionCktAToB",
"etag": "W/"e7c5535a-40c8-4c47-810a-2a6f09b6c383"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_peer526/peerings/AzurePrivatePeering"
},
"addressPrefix": "10.0.0.0/29",
"circuitConnectionStatus": "Connected"
},
"type": "Microsoft.Network/expressRouteCircuits/peerings/connections"
},
{
"name": "circuitConnectionCktAToC",
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering/connections/circuitConnectionCktAToC",
"etag": "W/"e7c5535a-40c8-4c47-810a-2a6f09b6c383"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_local526/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/873b0459-81fb-4b4d-a304-68c4abb58ce6/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/circuit_third526/peerings/AzurePrivatePeering"
},
"addressPrefix": "20.0.0.0/29",
"circuitConnectionStatus": "Connected"
},
"type": "Microsoft.Network/expressRouteCircuits/peerings/connections"
}
]
}

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3779

syfarogh
syfarogh reviewed Nov 27, 2018
View reviewed changes
Copy link

@syfarogh syfarogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3422

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4205

@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@MikhailTryakhov
Copy link
Contributor

merge directly to master approved cause we haven't created new branch yet

@MikhailTryakhov
Copy link
Contributor

@jianghaolu please merge

@jianghaolu jianghaolu merged commit 2aebd7d into Azure:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syfarogh syfarogh syfarogh approved these changes

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@vinayada1 vinayada1 Awaiting requested review from vinayada1

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.