Fixes the missing array for the header actions #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
|
removing @sergey-shandar and putting @dsgouda since he has more context on this according to @sai-manoj-kumar and Dinesh. @dsgouda feel free to punt one to sergey :) |
|
@sai-manoj-kumar could you provide a bit of context here |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
|
Will merge on CIs passing |
This is a fix for the bug which was introduced as part of this PR. The bug is that the missed items { } notation. This is added as part of the network-november-release branch. |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goA PR has been created for you: |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmpj6v2csel/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpj6v2csel/azure-sdk-for-node', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.107'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.107->2.1.107)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated. |
jianghaolu
pushed a commit
that referenced
this pull request
Nov 27, 2018
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * [Networkwatcer] add FlowLogFormatParameters (#4374) * Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters * [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420) * Make NIC VM ref readonly (#4443) * Mark private IP address read-only (#4447) * change container nics property type on container nic config to resourceid (#4459) * Port fix from PR 4459 to 2018-10-01 (#4463) * Application Gateway - Adds Rewrite rule set for Header CRUD (#4331) * Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly * Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (#4459)" This reverts commit baf31d9. * Fixes the missing array for the header actions (#4497) * Network py 2018-10 * add package-2018-10 to Go SDK codegen * Application gateway Identity and Keyvault support (#4387) * identity and keyvault * Capitalization comment * Ported fix from master branch (#4547)
jianghaolu
pushed a commit
that referenced
this pull request
Nov 27, 2018
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * [Networkwatcer] add FlowLogFormatParameters (#4374) * Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters * [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420) * Make NIC VM ref readonly (#4443) * Mark private IP address read-only (#4447) * change container nics property type on container nic config to resourceid (#4459) * Port fix from PR 4459 to 2018-10-01 (#4463) * Application Gateway - Adds Rewrite rule set for Header CRUD (#4331) * Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly * Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (#4459)" This reverts commit baf31d9. * Fixes the missing array for the header actions (#4497) * Network py 2018-10 * add package-2018-10 to Go SDK codegen * Application gateway Identity and Keyvault support (#4387) * identity and keyvault * Capitalization comment * Ported fix from master branch (#4547) * Add support for list api for global reach connections * address farhan comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist: