Merge master into Network release branch #5464

anton-evseev · 2019-03-25T12:31:56Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

* Swagger fixes * Error fix * edits to descriptions * per nschonni * fix interchangeable * removing runtime swagger - in different PR

* Add servicePrincipalsByAppId method to Graph Api Example : GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipalsByAppId/9469b9f5-6722-4481-a2b2-14ed560b706f/objectId?api-version=1.6 HTTP/1.1 {"odata.metadata":"https://graph.windows.net/72f988bf-86f1-41af-91ab-2d7cd011db47/$metadata#Edm.String","value":"3eb9d9f3-371c-4d24-a60a-d7681c48c071"} * Update graphrbac.json * Update graphrbac.json * Update graphrbac.json * Update graphrbac.json

…ersion 2017-01-01 (Azure#5241) * AddSuppress * AddNewDefinitionForPatchWebService * RevertWebServiceDefinition * Formatting * fix validation 'Model validation check' failures * revert last commit

* NFSAAS-1505 minor update and validation fixes * NFSAAS-1505 bring in line with RP Put (and patch) for snapshots. Service level definition changes. * NFSAAS-1505 correct resource reference and limits * NFSAAS-1505 resource and property changes Incorrect pool resource reference Name elements of property not required Correction to return status code * NFSAAS-1505 status codes * NFSAAS-1505 tidy up examples * NFSAAS-1505 tidy up examples * NFSAAS-1644 remove mt get and add put status code * NFSAAS-1644 remove mt get and add put status code * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 Update to R3.5 Standard (#11) * Nfsaas 1875 swagger update (#12) * NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * Nfsaas 1875 swagger update (#13) * NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 updated from review comments

…add version 2017-11-11-preview (Azure#5410) * [Azure Search] Make connectionString create-only to fix validation warning This change is just to satisfy Swagger spec validation; It has no effect on code generation (at least for C#). * [Azure Search] Fix various Swagger validation errors This is our first major push towards making searchservice.json pass all Swagger validation. The validator found several issues that this change fixes: - "Extensible enums" were being modeled incorrectly. On the wire, they are just strings, but we were modeling them as objects with a "name" property. This reflected the generated code, but not the wire format. The solution is to model them as proper enums in the Swagger. This causes new validation errors, since these enums should be open-ended, but that's an issue with the validator not understanding "extensible enums"; it's not a problem with our spec per se. - Properties of Skill were marked as "required", when they were being omitted or set to null in examples. This is because these properties actually appear to be optional from the point of view of the REST API, so now we model them as such. - "documentdb" was deprecated as a DataSourceType, but not replaced with "cosmosdb" in the examples. This is now fixed. - The example for "Get Indexer Execution Status" included properties in the response that aren't modeled in the Swagger. These properties actually do appear on the wire, but they shouldn't and will be removed in a future API version. In the meantime, I have removed them from the example. * [Azure Search] Applying consistent JSON formatting to Swagger spec * [Azure Search] Make inputs/outputs properties of Skill required It turns out these properties are required by the API. Also replaced the deprecated NER skill in examples. * [Azure Search] Standardize formatting of JSON examples * [Azure Search] Rolling back NamedEntityRecognition example update * [Azure Search] Make Swagger spec accurately reflect the semantics of Field Before this change, the descriptions in the Swagger for the Field type did not accurately describe the semantics of the Azure Search REST API, particularly around what the default values of the searchable, filterable, sortable, and facetable properties were. Instead, they reflected the defaults of our custom implementation of Field in the .NET SDK. This change corrects the descriptions to accurately reflect the REST API. It also adds more detail in anticipation of generating REST API documentation from the Swagger (which we don't currently do). A few other changes to Field are related to code generation: - Removed the x-ms-external flag so that AutoRest can generate this type. - Removed x-nullable: false and x-ms-client-name since they again reflect only the custom .NET code and not the desired REST API semantics. - Added regex transform rules to readme.md so that we can keep some of our custom code for Field in .NET purely for backward compatibility purposes. Our intention going forward for other languages is to rely solely on code generation for the Field type.

* Added NetwrokruleSet API * updated uri to networkRuleSets as per ARM guideline * updated with review comments

…on 2018-11-01-preview (Azure#5429) * Adds base for updating Microsoft.Consumption from version preview/2017-12-30-preview to version 2018-11-01-preview * Updates readme * Updates API version in new specs and examples * GTM consumption APIs Swagger for 2018-11-01-preview versions of GTM consumption APIs * Adding missing resource * Adding missing parameters * More missing definitions * Fixing model errors * fixing chargeSummaryProperties mods * fixing naming errors * Fixing charges mods * Fixing pricesheet models * Removing budgets since that isn't supported for 2018-11-01-preview

…re#5390) * add name and version to webhook list-events schema * trigger new azure-sdk-for-net build * trigger new azure-sdk-for-net build

* Added NetwruleSet to 2017 version * fixed indentation and aded default value to single value enum * fixed default for enum * updated the URI to networkRuleSets as per ARM guideline * updated with review comments resolve

…Azure#5096) * Adding swagger spec for healthcareapis resource manager and examples. * Change accessControlSettings to accessPolicies. * Remove Sku and change cosmosDbSettings to cosmosDbConfiguration * Updates and adding .md files * Fix version * Fix operationID

* Kusto: Suppress R2016 warning * Address comment

…ich already created (Azure#5434)

…zure#5415)

…e#5437) * Initialize FrontDoor WAF 2019-03-01-preview directory * Update FrontDoor WAF API definitions and examples * Fix parameter order and enum names for SDK generation

* Base commit to diff new version vs old version * Add 3.0 version of swagger for Training and Prediction * Add examples for v3.0 * Update release to 3.0 * Update Training API * Rename arg, update comment. * Update ruby readme * Update comments and incorporate feedback. * Remove text/json * Update required / x-nullable usage Fix Prediction and examples Fix Training API and examples * Fix required/readonly * Update examples * remove nullable * Add missing field * Update HttpDelete operation to be consistent. * Add missing error. * Add ruby swagger-to-sdk parts * Update ruby.md

* addign specifications for Peering * updating Swagger * removing ts and cs files * Create readme.python.md * Delete readme.python.md * renaming * renaming * adding md for other languages * fixing typo * updating ruby.md * updating readme.ruby.md * fixing PR comments * updated swagger specs * added new line * adding new line * updated resource return. * updated the true marker causing a failure in cloudbuild * Removed the required tag * Fixing code review comments * Updated Spec by removing the discriminator tag * Removed discriminator tag and required from Properties * Added 201 response for PeerAsn * Made recommended changes and fixed spelling errors. * Added Resource as allOf Property

…rsion 2019-03-01-preview (Azure#5359) * CloudConnector,ExternalBillingAccount,ExternalSubscription updates * Managment -> Management typo fix * CloudConnector verify * CloudConnector status readonly * Fix Showback validation errors * Fix validation errors * Fix Showback validation errors * address showback validation issues * validation checks * Remove ExternalSubscription_ManyUpdateManagementGroup

* First Avocado reference. * direct call * It should work now * only folders * only dir files * No readme.md errors * continueOnError * dontmerge.json * handle error * pretty output * JSON error * JSON error * different error * restore * ready to merge

* Add RunErrorMessage to RP Run * Remove Identity * remove IdentityProperties * nit fix * nit fix * Add more detailed description to runErrorMessage * make property readonly

…e#5091) * 3 new APIs added * fix typos * resolve comments

Updated description of scope paramater

* NFSAAS-1505 minor update and validation fixes * NFSAAS-1505 bring in line with RP Put (and patch) for snapshots. Service level definition changes. * NFSAAS-1505 correct resource reference and limits * NFSAAS-1505 resource and property changes Incorrect pool resource reference Name elements of property not required Correction to return status code * NFSAAS-1505 status codes * NFSAAS-1505 tidy up examples * NFSAAS-1505 tidy up examples * NFSAAS-1644 remove mt get and add put status code * NFSAAS-1644 remove mt get and add put status code * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 Update to R3.5 Standard (#11) * Nfsaas 1875 swagger update (#12) * NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * Nfsaas 1875 swagger update (#13) * NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 updated from review comments * NFSAAS-1875 small correction

* Fixes for: Issue #1 : Azure#4576 (comment) Typo in the DeltaOperationType Enum. Issue #2 : Azure#4844 (comment) GlobalAdmins list is marked as an object, while it's an array. * Updated the Specification as example for Risky IP Download report. * Added the Result details * Fixed review comments, changed the URI scheme as well as changed get/post methods * Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri * Added new operation to get connector metadata. * Addressing PR Comments * Fixing typo * Updated examples with real values

…ter-into-network

AutorestCI · 2019-03-25T12:32:00Z

Automation for azure-sdk-for-js